Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp3606012rwo; Mon, 24 Jul 2023 13:45:22 -0700 (PDT) X-Google-Smtp-Source: APBJJlGSnqqvfBchN4XOzCSrvhxZBDaiSUeYJPlie+ipwPAL8Y6TyNVUIGHZi0RcoSqnNWqKlGjQ X-Received: by 2002:a19:e609:0:b0:4f9:69e9:4fa6 with SMTP id d9-20020a19e609000000b004f969e94fa6mr5713239lfh.23.1690231521726; Mon, 24 Jul 2023 13:45:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690231521; cv=none; d=google.com; s=arc-20160816; b=kP4AfQA6KRA9AjnG79yF90BaGTn90fAYlHCsW/W/2C4uZKk9PmelraE7YmvuSz119k J3Oq3KIBl4OtYIoFYwnRcXVP+Kazbt8TXxPaRvc+GAfA+wvW99AF7H3YjDnpqZXzkeA4 /NDumvwAncQfVhhpFPjRLb6lDPQr+/HU6SeMFBj7dV5e7u5W50ykiGflawPeJn+Y/wQO XckoNkghvVLorhIjSpGaHOsjpsPCklr+5Vt61mk65OOgTqBCN0Wb5+HQg36TLxFwmcim sfplqdV5WLFtRJbGN7dlc89AQNdvJdcIENWJHgSoEWMjBYNqUYCjXHOPpctMpvfjHAVH iO/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=vnlMkc92vUFRyZ3B/DU+WA5/IQ5tuJamsGmdHRMZJgs=; fh=ZW1TCI44tqBGjPf6i4ZzpA/J2Y0WWjqqIls9JMkTQRA=; b=Ni2IGLqR0euGKZToXTnu6oepD46TGJj8n09YJR5oey7p2tZWdrIJZE5kWPUGk7bNzi IxSu8BjaKgEIsLyXhXcJnp/Q5NYwr9K9gWVAMYm5zsibuz/BGSECxZ6u0onyCzcMROUI CY2VPbONilJ1klX5sj+33llp+qigaJsXuuwx/1MM3O1qIG/z6z3Yrmsxk4tNwJhcjx65 KkPDVXLNjQyh4Pbr8PWzg3rgeOgJdzI6jtUhuGFuQPkwZGCK6el2Sfoya0YwdeYuwRui NSjB7NBPzMFzfziq713X2nD9zdxWjX5fUHSS+QalrzaOIII6Xdav2H9HJ9f5aZbHwxCN +YUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bkQms3eD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x3-20020aa7d383000000b0052227f13c0csi2904296edq.394.2023.07.24.13.44.57; Mon, 24 Jul 2023 13:45:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bkQms3eD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230323AbjGXT7D (ORCPT + 99 others); Mon, 24 Jul 2023 15:59:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbjGXT7C (ORCPT ); Mon, 24 Jul 2023 15:59:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6451611C for ; Mon, 24 Jul 2023 12:59:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F0D3E61355 for ; Mon, 24 Jul 2023 19:59:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 984CBC433C7; Mon, 24 Jul 2023 19:58:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690228740; bh=I7HE1Vuyn6NFH+9L/Nxorax52ASCtQoSy5QHBoB33wc=; h=From:To:Cc:Subject:Date:From; b=bkQms3eDYZ43wC6kjvZ+zpuL188LFkwigmDowb8l4RnjWLttRubKDE9cCkhIoY39t o6m3gPTfq3p63Kn/OFRcJbwNDvdfYDrjF4wx2SBSkwj1Wknx0chLpUcoioeroBwk88 0uw0P5eORGOPGfR5zoY6eluIzMQXAPfvzqE3x2r2k/jDNTsoC9YuB1MlIXyfWL67vX /97cERJeZWXmczOFQqCqVb3p7MGjtGIfGp+uMqPRUXNBq+vzt8P5Qo58eAZ9NDRU/6 NvJn9phR7bip05/9BB1XbPZNHCECRpm0DGgfKugQ3Y0ZcihNDcFZbb7dp3Vo9v8VEo BjV16NWCnJjFQ== From: Arnd Bergmann To: Peter Zijlstra Cc: Arnd Bergmann , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org Subject: [PATCH] sched/fair: make update_entity_lag static Date: Mon, 24 Jul 2023 21:58:29 +0200 Message-Id: <20230724195854.2491142-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann The newly introduced function is only used in this one file, so we get a warning when it is in the global namespace: kernel/sched/fair.c:702:6: warning: no previous prototype for function 'update_entity_lag' [-Wmissing-prototypes] void update_entity_lag(struct cfs_rq *cfs_rq, struct sched_entity *se) kernel/sched/fair.c:702:1: note: declare 'static' if the function is not intended to be used outside of this translation unit Fixes: 86bfbb7ce4f67 ("sched/fair: Add lag based placement") Signed-off-by: Arnd Bergmann --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index b42e0a2cadbf4..7566e67e314b2 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -699,7 +699,7 @@ u64 avg_vruntime(struct cfs_rq *cfs_rq) * * XXX could add max_slice to the augmented data to track this. */ -void update_entity_lag(struct cfs_rq *cfs_rq, struct sched_entity *se) +static void update_entity_lag(struct cfs_rq *cfs_rq, struct sched_entity *se) { s64 lag, limit; -- 2.39.2