Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230724074800.9099-1-xujianghui@cdjrlc.com> <d6c3b91864b9f3f90d8a2d3cd952bada@208suo.com>
In-Reply-To: <d6c3b91864b9f3f90d8a2d3cd952bada@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 24 Jul 2023 17:49:36 -0400
Message-ID: <CADnq5_PgmnmoNRoePzH1_DShKv8qJt8KVcZGGEqO+wu10VdYnA@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c
To:     sunran001@208suo.com
Cc:     alexander.deucher@amd.com, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Mon, Jul 24, 2023 at 3:49=E2=80=AFAM <sunran001@208suo.com> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: "foo* bar" should be "foo *bar"
> ERROR: spaces required around that '=3D' (ctx:VxW)
> ERROR: space prohibited before that close parenthesis ')'
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>   drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> index 3ecb900e6ecd..b26e9ac1ac30 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> @@ -691,7 +691,7 @@ int smu_cmn_feature_set_enabled(struct smu_context
> *smu,
>
>   #undef __SMU_DUMMY_MAP
>   #define __SMU_DUMMY_MAP(fea)  #fea
> -static const char* __smu_feature_names[] =3D {
> +static const char *__smu_feature_names[] =3D {
>         SMU_FEATURE_MASKS
>   };
>
> @@ -927,7 +927,7 @@ int smu_cmn_get_metrics_table(struct smu_context
> *smu,
>                               void *metrics_table,
>                               bool bypass_cache)
>   {
> -       struct smu_table_context *smu_table=3D &smu->smu_table;
> +       struct smu_table_context *smu_table =3D &smu->smu_table;
>         uint32_t table_size =3D
>                 smu_table->tables[SMU_TABLE_SMU_METRICS].size;
>         int ret =3D 0;
> @@ -969,7 +969,7 @@ void smu_cmn_init_soft_gpu_metrics(void *table,
> uint8_t frev, uint8_t crev)
>         struct metrics_table_header *header =3D (struct metrics_table_hea=
der
> *)table;
>         uint16_t structure_size;
>
> -#define METRICS_VERSION(a, b)  ((a << 16) | b )
> +#define METRICS_VERSION(a, b)  ((a << 16) | b)
>
>         switch (METRICS_VERSION(frev, crev)) {
>         case METRICS_VERSION(1, 0):