Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230724032920.7892-1-xujianghui@cdjrlc.com> <d88773902f7a8536a8be83ead18981b3@208suo.com>
In-Reply-To: <d88773902f7a8536a8be83ead18981b3@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 24 Jul 2023 17:39:24 -0400
Message-ID: <CADnq5_M7x2js7C4fAUVsOd6YAfExqjVW5AapiqDxRQo2e4stBA@mail.gmail.com>
Subject: Re: [PATCH] drm/radeon: add missing spaces after ',' and else should
 follow close brace '}'
To:     sunran001@208suo.com
Cc:     alexander.deucher@amd.com, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

Alex

On Sun, Jul 23, 2023 at 11:30=E2=80=AFPM <sunran001@208suo.com> wrote:
>
> ERROR: else should follow close brace '}'
>
> ERROR: space required after that ',' (ctx:VxV)
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>   drivers/gpu/drm/radeon/radeon_connectors.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c
> b/drivers/gpu/drm/radeon/radeon_connectors.c
> index 07193cd0c417..4ceceb972e8d 100644
> --- a/drivers/gpu/drm/radeon/radeon_connectors.c
> +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
> @@ -198,8 +198,7 @@ int radeon_get_monitor_bpc(struct drm_connector
> *connector)
>                                 DRM_DEBUG("%s: HDMI deep color 10 bpc exc=
eeds max tmds clock. Using
> %d bpc.\n",
>                                                   connector->name, bpc);
>                         }
> -               }
> -               else if (bpc > 8) {
> +               } else if (bpc > 8) {
>                         /* max_tmds_clock missing, but hdmi spec mandates=
 it for deep color.
> */
>                         DRM_DEBUG("%s: Required max tmds clock for HDMI d=
eep color missing.
> Using 8 bpc.\n",
>                                           connector->name);
> @@ -1372,7 +1371,7 @@ radeon_dvi_detect(struct drm_connector *connector,
> bool force)
>                                         /* assume digital unless load det=
ected otherwise */
>                                         radeon_connector->use_digital =3D=
 true;
>                                         lret =3D encoder_funcs->detect(en=
coder, connector);
> -                                       DRM_DEBUG_KMS("load_detect %x ret=
urned:
> %x\n",encoder->encoder_type,lret);
> +                                       DRM_DEBUG_KMS("load_detect %x ret=
urned: %x\n",
> encoder->encoder_type, lret);
>                                         if (lret =3D=3D connector_status_=
connected)
>                                                 radeon_connector->use_dig=
ital =3D false;
>                                 }