Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230724034415.8257-1-xujianghui@cdjrlc.com> <304e90636af5cb6843ae603cd973680f@208suo.com>
In-Reply-To: <304e90636af5cb6843ae603cd973680f@208suo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 24 Jul 2023 17:44:14 -0400
Message-ID: <CADnq5_M4uLoVGn02NC7bCFwbMieOsr7MOzSoTXgXnruDNzCy4g@mail.gmail.com>
Subject: Re: [PATCH] drm/radeon: Move assignment outside if condition
To:     sunran001@208suo.com
Cc:     alexander.deucher@amd.com, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Sun, Jul 23, 2023 at 11:45=E2=80=AFPM <sunran001@208suo.com> wrote:
>
> Fixes the following checkpatch errors:
>
> ERROR: do not use assignment in if condition
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>   drivers/gpu/drm/radeon/radeon_legacy_tv.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_legacy_tv.c
> b/drivers/gpu/drm/radeon/radeon_legacy_tv.c
> index 12e180b119ac..7883e9ec0bae 100644
> --- a/drivers/gpu/drm/radeon/radeon_legacy_tv.c
> +++ b/drivers/gpu/drm/radeon/radeon_legacy_tv.c
> @@ -724,12 +724,14 @@ void radeon_legacy_tv_mode_set(struct drm_encoder
> *encoder,
>         }
>
>         for (i =3D 0; i < MAX_H_CODE_TIMING_LEN; i++) {
> -               if ((tv_dac->tv.h_code_timing[i] =3D hor_timing[i]) =3D=
=3D 0)
> +               tv_dac->tv.h_code_timing[i] =3D hor_timing[i];
> +               if (tv_dac->tv.h_code_timing[i] =3D=3D 0)
>                         break;
>         }
>
>         for (i =3D 0; i < MAX_V_CODE_TIMING_LEN; i++) {
> -               if ((tv_dac->tv.v_code_timing[i] =3D vert_timing[i]) =3D=
=3D 0)
> +               tv_dac->tv.v_code_timing[i] =3D vert_timing[i];
> +               if (tv_dac->tv.v_code_timing[i] =3D=3D 0)
>                         break;
>         }