Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <8f293bb51a423afa71ddc3ba46e9f323ee9ffbc7.1689768831.git-series.apopple@nvidia.com>
 <20230719225105.1934-1-sj@kernel.org> <877cqvl7vr.fsf@nvdebian.thelocal>
 <ZL7AbLJ+RUUgzt8O@bombadil.infradead.org>
User-agent: mu4e 1.8.13; emacs 28.2
From:   Alistair Popple <apopple@nvidia.com>
To:     Luis Chamberlain <mcgrof@kernel.org>
Cc:     linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
        Pankaj Raghav <p.raghav@samsung.com>,
        SeongJae Park <sj@kernel.org>, kevin.tian@intel.com,
        x86@kernel.org, ajd@linux.ibm.com, kvm@vger.kernel.org,
        linux-mm@kvack.org, catalin.marinas@arm.com, seanjc@google.com,
        will@kernel.org, linux-kernel@vger.kernel.org, npiggin@gmail.com,
        zhi.wang.linux@gmail.com, jgg@ziepe.ca, iommu@lists.linux.dev,
        nicolinc@nvidia.com, jhubbard@nvidia.com, fbarrat@linux.ibm.com,
        akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
        linux-arm-kernel@lists.infradead.org, robin.murphy@arm.com
Subject: Re: [PATCH v2 3/5] mmu_notifiers: Call invalidate_range() when
 invalidating TLBs
Date:   Tue, 25 Jul 2023 10:20:52 +1000
In-reply-to: <ZL7AbLJ+RUUgzt8O@bombadil.infradead.org>
Message-ID: <87v8e8zvmz.fsf@nvdebian.thelocal>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZyENK2BIcQ5IWgp+X9tHTNXPyEU2ibIZKb/CxXI7KPjGUXl2e1C2NjDvWLEy?=
 =?us-ascii?Q?FCE7ql9oHYZnGFD7yPmqjKzdjlGs5nxc0B/2+1/78nTSY+PXPzsmedG1U2tY?=
 =?us-ascii?Q?DvUsvPk90g7GOec06g20huyXnTlkyFZvqKG7wynGda5SpiSsVNy//xbKKmFZ?=
 =?us-ascii?Q?4fVZkz195vhwdNJfyTeMiroNal2tPv7oyk+dypUhWTBO+nmm/Faf3afCyGle?=
 =?us-ascii?Q?OaiDn9FjxPf7A/27VlZnDJjQjyO/fexi3lCnVV8U/pKbm7hvPGY/BllJmM8G?=
 =?us-ascii?Q?2eOBjFGGuQ1EMorDmCL7tfIr+ub2FOYH49AOsGznIeT72IXfNLGVhvmprD0+?=
 =?us-ascii?Q?fFE7sEfz7tVuivNsGnJGsIfT92Ty6uKfBXwZ9z/UQUZPET9RSvxunw0XwMtx?=
 =?us-ascii?Q?QGQfUpC4EptsRoglaoOSIYmlUmRcNcEYGrgDwb7d88tkEtkiWYO8atgzsPzQ?=
 =?us-ascii?Q?XQLG/fCAxX7nc+J2TNWud49o1zbXaaiWco/bBQn0AEspmz3iS+Z6cdBrPViB?=
 =?us-ascii?Q?zR9zQGdjqGBFp4h7K7oZl78p0tgoUlGn7nKuJzEqsDUlo+crpHXEoo7YRFYo?=
 =?us-ascii?Q?V7pI73iJpwdKBDo+Vv9ryW/xjGu6fYKKvTEUSpwOr5Hd21gBFpb9lY/jjOxP?=
 =?us-ascii?Q?aPUoiEH3y5Bi/hiPSf4MdeEN9kf+G7MtUTZg+7f9u4/WylIrqMqWudmaOsvR?=
 =?us-ascii?Q?e002RKAENuJk9uJ7rG3ZkSRLGzNbtcRI/Y9IM3eJvpiRkHwqfpK+YMp3Ubdk?=
 =?us-ascii?Q?2r55Bv+ixReWr0L2So9UjZZVYmHiRBpZmxXfHYO5RwlHo8EEMVZvs4d7+HZs?=
 =?us-ascii?Q?Rz3UnkBnwXmmI89M7T6XhHnJYvU9crECnHqPA5QYuQj6uh6JOdbqOGJdFJce?=
 =?us-ascii?Q?BUoQEw0dgszYgqG+u11LJ4TKPxdFdszj49y55tEKwVwugjvfc4s6JVGoLfdA?=
 =?us-ascii?Q?x6JbPFmMjOq4xBLt5k//MKiyQX+sHUH0e53UC5JApyJmhbUhFd232DrdvfM9?=
 =?us-ascii?Q?V2rskMU4Njjco3qKO5Gx85ybYeCc+9qyneJIzalvi0fd+Fl1RX9UcZQVrCmH?=
 =?us-ascii?Q?76hN2qLIhVud1cwyqJeqJlV34hMTJ2CTBA3+aNfM2yWFDIXvBZDG84GZ1+HK?=
 =?us-ascii?Q?VbhEgahty7wb+WNBZXeKBBhaRiqOeBH58cytgiU8ZUxZNeiyk/tC6orRSMZs?=
 =?us-ascii?Q?SKjZAMAsIlxC1nJMqK5GOmlQbO8FmIiUAKzb/yLvGzARhMu7AAn2SENY7TQl?=
 =?us-ascii?Q?WhGpF2oAsO/Whxg9cRrwB6cRPa7hAmTX86LiIc/hvKCx+FeKgjjAYM6TQHJG?=
 =?us-ascii?Q?2RJRl/n1sVXTTvIGrLnW9KSSU6hcOrKNWVPBP6B4f1pnxEDmwvAEejfPhZ5W?=
 =?us-ascii?Q?ynTzvyvS3nwiUKeNhTSwX21JZigGHyyh/6vR+sQHrHEo29GL38/ABjO21srJ?=
 =?us-ascii?Q?zyod2d5ILmLm1CI7qxzq1zmCSgEGL1jfUlbgrdSdIlDO1Qn6xKiXar475e0q?=
 =?us-ascii?Q?luHlPvAulu15qyucFAim1QDreiIygQX+AE+Q9Ek8f6da/gEG3gSSgR0vzoHK?=
 =?us-ascii?Q?EKywRnJG3sP18fYRfnm2tUygPXqLy7J6vmVK60ZE?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f49de129-5bb2-4bb7-a2a6-08db8ca56d99
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2023 00:23:54.1641
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ReXHcJFhI812pCDjT2afAZrcaKRkKrRr85XtzIEtPfHZTzrKl/Dd8y2PkKPUY8EW4JYPcWveeNVV7H4KOl+Bwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5405
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Luis Chamberlain <mcgrof@kernel.org> writes:

>> diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
>> index 837e4a50281a..79c46da919b9 100644
>> --- a/arch/x86/include/asm/tlbflush.h
>> +++ b/arch/x86/include/asm/tlbflush.h
>> @@ -4,6 +4,7 @@
>>  
>>  #include <linux/mm_types.h>
>>  #include <linux/sched.h>
>> +#include <linux/mmu_notifier.h>
>>  
>>  #include <asm/processor.h>
>>  #include <asm/cpufeature.h>
>> @@ -282,6 +283,7 @@ static inline void arch_tlbbatch_add_pending(struct arch_tlbflush_unmap_batch *b
>>  {
>>  	inc_mm_tlb_gen(mm);
>>  	cpumask_or(&batch->cpumask, &batch->cpumask, mm_cpumask(mm));
>> +	mmu_notifier_arch_invalidate_secondary_tlbs(mm, 0, -1UL);
>>  }
>>  
>>  static inline void arch_flush_tlb_batched_pending(struct mm_struct *mm)
>> diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
>> index 0b990fb56b66..2d253919b3e8 100644
>> --- a/arch/x86/mm/tlb.c
>> +++ b/arch/x86/mm/tlb.c
>> @@ -1265,7 +1265,6 @@ void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch)
>>  
>>  	put_flush_tlb_info();
>>  	put_cpu();
>> -	mmu_notifier_arch_invalidate_secondary_tlbs(current->mm, 0, -1UL);
>>  }
>>  
>>  /*
>
> This patch also fixes a regression introduced on linux-next, the same
> crash on arch_tlbbatch_flush() is reproducible with fstests generic/176
> on XFS. This patch fixes that regression [0]. This should also close out
> the syzbot crash too [1]
>
> [0] https://gist.github.com/mcgrof/b37fc8cf7e6e1b3935242681de1a83e2
> [1] https://lore.kernel.org/all/0000000000003afcb4060135a664@google.com/
>
> Tested-by: Luis Chamberlain <mcgrof@kernel.org>

Thanks Luis. The above fix/respin is already in yesterdays linux-next
(next-20230724) so hopefully you are no longer seeing issues.

>   Luis