Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230724131741.954624-1-james.clark@arm.com>
In-Reply-To: <20230724131741.954624-1-james.clark@arm.com>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Tue, 25 Jul 2023 02:41:16 +0200
Message-ID: <CANiq72nJP+i10CZysua0QU=V=Cn=jdnLuV8KOqm6_NNFdg9S3w@mail.gmail.com>
Subject: Re: [PATCH] scripts/kallsyms: Fix build failure by setting errno
 before calling getline()
To:     James Clark <james.clark@arm.com>
Cc:     linux-kbuild@vger.kernel.org, masahiroy@kernel.org,
        linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Zhen Lei <thunder.leizhen@huawei.com>,
        Miguel Ojeda <ojeda@kernel.org>,
        Boqun Feng <boqun.feng@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>, Nicolas Schier <n.schier@avm.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jul 24, 2023 at 3:18=E2=80=AFPM James Clark <james.clark@arm.com> w=
rote:
>
> This fixes the following build failure if scripts/kallsyms launches with
> a non-zero errno value:

The code change sounds good to me, but could you please describe the
situation where you found the build failure?

Cheers,
Miguel