Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Viresh Kumar <vireshk@kernel.org>,
        Sergey Shtylyov <s.shtylyov@omp.ru>,
        Damien Le Moal <dlemoal@kernel.org>,
        linux-ide@vger.kernel.org (open list:LIBATA PATA ARASAN COMPACT FLASH
        CONTROLLER), linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v5] ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer()
Date:   Tue, 25 Jul 2023 11:06:25 +0800
Message-Id: <20230725030627.1103-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LnsQ/eAWcITzPU9ts+WUGeKqcpDwRkm6ycDLKL38mIMbKKdQ1OSF1YBm7VkG?=
 =?us-ascii?Q?pnCtjtn4LdJROJdEZotqmZNIqirGEFL1TSEcREY8jrg1MlJZz9DHH5LlmZxL?=
 =?us-ascii?Q?CCrJg/7RRZ3WyAtKKfkRPxqLRQHXdg1XP78RSdcG1sL9eUYGpy76S3vou1R4?=
 =?us-ascii?Q?LKQydVdx3iaY+oLlu7IpGMpvgvhFh2EnHIvObC8uUxCbU6FlbtyamUTSj2D2?=
 =?us-ascii?Q?uWo5GMZf3qEUN4YIe2K7FXq1uDYh0OWBO4DJvlslIG0oG2VOmPEQpJr92D2Q?=
 =?us-ascii?Q?xtbuKxFcaYBl1EklJZmJ635Blw2P0UmvZCmX7Sgvo22v6FnZh5BTRWdbVm68?=
 =?us-ascii?Q?iZMjpvqZz9hdcRFtz/loDoVKK42c28froNSakxW7pALN3Kun1sLq7dRp2bsM?=
 =?us-ascii?Q?zc/XWmZSil2qzoQML7NYs2WU59UNG/aUuN0o2f2Pd9tc6BHa11kr/OhOw5GI?=
 =?us-ascii?Q?hENMzJzTuEnBWSYZ/1wbCVLTxoRa9rAxCLutYxbrD+PM1KMa4iLXN2YRreIb?=
 =?us-ascii?Q?Woz8QSBjsjL6toREqhPsDjXhjg5DPPnxfrURgy02ywxfzCg+W8RocDzOD5MG?=
 =?us-ascii?Q?6MYtoa71exmZJ9c2XWA6C1UhxhjLt86mluHkmK8j8931TB1O6X1CPCrRCp2Q?=
 =?us-ascii?Q?h4xbFsYB5bYHJCu2JNc3DfH4WC++9OPOVRe7omuuNsPsr6MiZLhkUb37Q8F1?=
 =?us-ascii?Q?DYPYeXH8l4pg3FTjNmpLM1+xvUaOrNbHirtz6leD2RVhPrt6PUrQIWN7eV45?=
 =?us-ascii?Q?fdRIbpLpnL/xDKJBBeSrSnKQ6bOFN/EYRgVQvVqbnO1sPhYHFx54XWBrI0mO?=
 =?us-ascii?Q?H0Amc9sw8C71MKQ8yCIGTxtR57Lhf865Qzf2sfoHx6066tTOzoPDWoEtFBlf?=
 =?us-ascii?Q?jtTP1Tmhtb/UGaobanT/K3ufB0yhjMlr3DkDaXh+pesoKqQmztnAXyWuvOwx?=
 =?us-ascii?Q?cwEmXmgwPIuEPPNmLexsMc28lhY3/XQrN1beNhlMuwbo9YTlghe7S0L/tXnZ?=
 =?us-ascii?Q?tx5IsJPax1MnVbHl24a99r7+YnitPINgI9TlxMgyLnRnlTcGgVMJtgiW16x3?=
 =?us-ascii?Q?2DEULG+5Ji35fcLqH/4Lr+ca5bD4BBKy/M2lxv8XNEi42yK9V3vbcJz9py9q?=
 =?us-ascii?Q?qyDwVkrrRoANOdJ13jKxoYv8gnenjfLYjCDXCZwZkBHgs279RLTgr2K5aPs7?=
 =?us-ascii?Q?G9hM9tXI8pxVVXiSKE2XDFkaN0Gl/It7gzau8SoVdGFMTJHh4mNJed0vcUON?=
 =?us-ascii?Q?+F2cS65qJpOmo/GGaKMdMeOCA9DDweo29xermQdHt6EsEcTBDY0jqAeFyxFq?=
 =?us-ascii?Q?l0W72zsiNcVBzDgJ7NEHWkkuj7ZmPsHPL5qi/9otZ3oLsafR8bsPFrQZKZct?=
 =?us-ascii?Q?BYYt1GRDiUeMkNOb5kA2SLStqJpbLFdqumxkzwvdIjHgwWtb1ROBQPoL6Mnt?=
 =?us-ascii?Q?km+Bm31uaXPcAWd/277oqz6QyknXx6NCU/ZHZT/2xYpIfJwYc/4kn6HvXOut?=
 =?us-ascii?Q?EKztlaw3BV2Pyrd7+/zEqDUt58M3zNNjGe8BmKKW6B+R+sraBKCJAv+BH3ja?=
 =?us-ascii?Q?fn84PT6Zu5TUegngcMrtG8HEjP46fxP9ZmO/P6el?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f2af69a-e668-47ef-56f7-08db8cbc2954
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2023 03:06:38.0705
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: boh0fMjlP5FhQhwgl9C+ZopSFj7IZ+9bDLBM6Grze+tQ6WFrJh1EXqsZFQ96sHinuiX9gybSAQLWr1ddvWI2WA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB4602
X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It is possible for dma_request_chan() to return EPROBE_DEFER, which means
acdev->host->dev is not ready yet.
At this point dev_err() will have no output.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
V2 -> V5: Fixed code formatting errors.
---
 drivers/ata/pata_arasan_cf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
index 6ab294322e79..b32d47112c0a 100644
--- a/drivers/ata/pata_arasan_cf.c
+++ b/drivers/ata/pata_arasan_cf.c
@@ -529,7 +529,8 @@ static void data_xfer(struct work_struct *work)
 	/* dma_request_channel may sleep, so calling from process context */
 	acdev->dma_chan = dma_request_chan(acdev->host->dev, "data");
 	if (IS_ERR(acdev->dma_chan)) {
-		dev_err(acdev->host->dev, "Unable to get dma_chan\n");
+		dev_err_probe(acdev->host->dev, PTR_ERR(acdev->dma_chan),
+			      "Unable to get dma_chan\n");
 		acdev->dma_chan = NULL;
 		goto chan_request_fail;
 	}
-- 
2.39.0