Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Vladimir Oltean <olteanv@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Richard Cochran <richardcochran@gmail.com>,
        linux-spi@vger.kernel.org (open list:FREESCALE DSPI DRIVER),
        linux-kernel@vger.kernel.org (open list),
        netdev@vger.kernel.org (open list:PTP HARDWARE CLOCK SUPPORT)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v2] spi: fsl-dspi: Use dev_err_probe() in dspi_request_dma()
Date:   Tue, 25 Jul 2023 11:50:37 +0800
Message-Id: <20230725035038.1702-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ISMchyrGBNBoGknPlS6KrwmrjSNecwrVmEidDWjwFvZ4p+zN2C++e2qRpgy+?=
 =?us-ascii?Q?IamZji12EwdWlseJ40et/03er+E8F1+jPJQinUljtsXXO0+kaPUSZv7iPQqj?=
 =?us-ascii?Q?HXZPU3Ly8IUQzhUTgC05mAMgDkFjnqxwWNMKa7ejCvm2yURiRiOX4P9cumEJ?=
 =?us-ascii?Q?HxtVlGzkzvBCstqyzMrEeIVjv4njgfJaW8l8DSfAiRWXiLAfxh+juRy+RBnZ?=
 =?us-ascii?Q?VcYsUTu3LDWDLiVg8psJz5vQQYtdkwvnx6j0jETy7o2aSk5dKAQkv1Pjokuz?=
 =?us-ascii?Q?qOa2xMlY2JSejo2A6hLSCTJNnXRS47glAJlK/EpU2YELSYGUoQW65Xl++yE5?=
 =?us-ascii?Q?YtRKpMN31MCDlTV1UHvXE990EqUzbx8BHVqk468eM5+sqd3jO8+cpUp1Obeq?=
 =?us-ascii?Q?Ipk5i54fVajIycZVj/ly0/WQpiABqFDYuB8/JTy7ozPVmS8mgfDHGrRloxsg?=
 =?us-ascii?Q?ir3AZnTUtgd2r2w8Ww4Zy/qmkDiVVkKrsbX+KhqxWU8iJ8zZAkU7/8lJIBx/?=
 =?us-ascii?Q?TLvvl1I5c49PftO6i9JDdI9pztbLUS1U2mk3BvDkNIa5UrIeKzPhAL6ZX0ea?=
 =?us-ascii?Q?E4wexN1QU1tAixrn9F+vEkGDfScjdCtv0pJN7bvqZLGlbpsbu7cp37mPAyE6?=
 =?us-ascii?Q?NrFuyE4wCxlo3CuTRKs6dABfUmtIS9aIk7szOHXdL6xMTwAU8RtwKQDpfWT7?=
 =?us-ascii?Q?aip4IBfA+vf8aY7cJ3ujTViL9AHdiSLrMAGW30y3Qty6ZYQ73knHoXpONbKR?=
 =?us-ascii?Q?kMirpMPjq5Za6pEuGZycjsSjuzOefK/rAkgoZdy7iUDdf6hVG9FlFXoeGlRO?=
 =?us-ascii?Q?LOx7SysYfuBykrVvAD+P/dLfFshLhEIrubRdiFnHQpWXhQgLTvXtrNWO0Dp6?=
 =?us-ascii?Q?y9HrWgVtBQPsIZAUcUrTo28yxfkfAt/hVjrzGqkS7vKVLRG+NeH4DGYTJokS?=
 =?us-ascii?Q?a9iXw3nvLTc/ysCwVzHklIkJZuUf+H+eJoYwil/5v8WH5yZEJqVzf40v6SbD?=
 =?us-ascii?Q?VzDb08EyZWIztD/ut26rT7FiZBzjkDabNs3NPqpJclSSFaGoF0sFQl63QlQF?=
 =?us-ascii?Q?5TREtmQa0KVPyfrZNb7fA+EWhAzqa7gzJwfDyK0hgMSym5OADXxWLccsIUWX?=
 =?us-ascii?Q?dbQy3cDuwPVSmgYAx+rCXlD/iT/Mycz0ZWVpL6yIgvvc+K6yXqwOwdBcBe2H?=
 =?us-ascii?Q?pWLmme1ndd3U4qH+a2GDJucHLsY6WDT+Ng4QXWVVHbL6d28X+QfiG/tg8/Ll?=
 =?us-ascii?Q?kVlGnQ1O9pcQMvT/jr4Or8VfeXuWv6+G/al7dCrG2uCdnBnoIqZrmtkoWl71?=
 =?us-ascii?Q?Kz2Y5PIflFmSsaQK8gkKojkLQnb+JcQ9JQHhSSZ9f79ZySDvKVW9XBtkSjPR?=
 =?us-ascii?Q?JKVgqvUcsT2LqBYIeo7nl1ooVAUVPBvYbtwfL6TBLVLAfu/QuUzKuThl/lzC?=
 =?us-ascii?Q?V+G/cf50Qi3vS5rXRU2vHExG7R9PV8HTd0fPqtxnzzl/pdo6g5EkAymyzhQf?=
 =?us-ascii?Q?JLsAcsHm8go4mk5DWtvSGVFyo71NAwV6AwNjU3mRPDrMQc915fERyXq2T4N7?=
 =?us-ascii?Q?F+XhQ179pSlZqirWZCtFSfHQuQ+KY67+JnDflixA?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a17237e0-3f09-4f4a-4916-08db8cc25770
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2023 03:50:52.4251
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hb0I6Zqs5YPnajTigQ4IQxMdee45yOW1G9rZhAWpzzkYQz9WVZ/Dgpg0BO+pj84DiF8R7oSpUrcj7DCnHYescA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB6223
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It is possible for dma_request_chan() to return EPROBE_DEFER, which means
dev is not ready yet.
At this point dev_err() will have no output.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/spi/spi-fsl-dspi.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
index ca41c8a8b..6aaa529b7 100644
--- a/drivers/spi/spi-fsl-dspi.c
+++ b/drivers/spi/spi-fsl-dspi.c
@@ -503,15 +503,14 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr)
 
 	dma->chan_rx = dma_request_chan(dev, "rx");
 	if (IS_ERR(dma->chan_rx)) {
-		dev_err(dev, "rx dma channel not available\n");
-		ret = PTR_ERR(dma->chan_rx);
-		return ret;
+		return dev_err_probe(dev, PTR_ERR(dma->chan_rx),
+			"rx dma channel not available\n");
 	}
 
 	dma->chan_tx = dma_request_chan(dev, "tx");
 	if (IS_ERR(dma->chan_tx)) {
-		dev_err(dev, "tx dma channel not available\n");
 		ret = PTR_ERR(dma->chan_tx);
+		dev_err_probe(dev, ret, "tx dma channel not available\n");
 		goto err_tx_channel;
 	}
 
-- 
2.39.0