Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1fed3f09-75e4-bb44-71d7-f7319f1b0c3c@ti.com>
Date:   Tue, 25 Jul 2023 09:49:04 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] arm64: dts: ti: k3-am62a7-sk: Enable dual role support
 for Type-C port
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, <nm@ti.com>,
        <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <rogerq@kernel.org>
References: <20230724115133.2226-1-r-gunasekaran@ti.com>
 <c907c3aa-84b8-c667-e8ea-dd7e5bd4a54b@linaro.org>
Content-Language: en-US
From:   Ravi Gunasekaran <r-gunasekaran@ti.com>
In-Reply-To: <c907c3aa-84b8-c667-e8ea-dd7e5bd4a54b@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/24/2023 7:27 PM, Krzysztof Kozlowski wrote:
> On 24/07/2023 13:51, Ravi Gunasekaran wrote:
>> USB0 is interfaced with a Type-C DRP connector and is managed via a
>> USB PD controller. Add support for the Type-C port with dual data
>> and power sink role.
>>
>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
>> ---
>>  arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 33 +++++++++++++++++++++++++
>>  1 file changed, 33 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>> index d2cca6182738..b478b794de00 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>> @@ -226,6 +226,24 @@
>>  	pinctrl-names = "default";
>>  	pinctrl-0 = <&main_i2c0_pins_default>;
>>  	clock-frequency = <400000>;
>> +
>> +	typec_pd0:tps6598x@3f {

Thanks for reviewing the patch.

> Missing space after:

I will fix this in v2.

>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Thanks for pointing to the section. I checked it and also few other node names
in the existing DTs.
TPS6598 is a USB Type C and Power Delivery Controller. So does a node name
"type-c-pd-controller" sound fine?

>
> Best regards,
> Krzysztof
>

Regards,
Ravi