Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Jul 2023 11:00:07 +0530
From:   Pavan Kondeti <quic_pkondeti@quicinc.com>
To:     Mike Tipton <quic_mdtipton@quicinc.com>
CC:     <djakov@kernel.org>, <gregkh@linuxfoundation.org>,
        <rafael@kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-pm@vger.kernel.org>, <quic_okukatla@quicinc.com>,
        <quic_viveka@quicinc.com>
Subject: Re: [PATCH 0/3] Add interconnect debugfs client
Message-ID: <b96376a1-4d53-4288-9380-caf9e83817cb@quicinc.com>
References: <20230725012859.18474-1-quic_mdtipton@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230725012859.18474-1-quic_mdtipton@quicinc.com>
Precedence: bulk

On Mon, Jul 24, 2023 at 06:28:56PM -0700, Mike Tipton wrote:
> This series introduces interconnect debugfs files that support voting
> for any path the framework supports.
> 
> We've historically relied on an out-of-tree module for this, which used
> the old icc_get() that was recently removed in [0]. The old icc_get()
> took integer endpoint IDs, which made identifying paths in our old
> implementation non-intuitive. The logical node names typically don't
> change much chip-to-chip, but the raw integer IDs do. Take this
> opportunity to introduce an icc_get() that uses string names instead,
> which allows for a more intuitive and generic debugfs interface.
> 
> We rely on this support for debug, test, and verification. Hopefully
> it'll be useful for other vendors as well.

Thanks Mike for working on this series. The downstream driver has been
helpful in quickly pushing NOCs to max during throughput issues
debugging. I have tested this series on v6.4 + revert mentioned here on
SM8550 MTP and it works as advertised.

Thanks,
Pavan