Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Jul 2023 23:31:31 -0700 (PDT)
From:   Hugh Dickins <hughd@google.com>
To:     Randy Dunlap <rdunlap@infradead.org>
cc:     linux-kernel@vger.kernel.org,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Hugh Dickins <hughd@google.com>, linux-mm@kvack.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org
Subject: Re: [PATCH] tmpfs: fixup Docs table for huge mount options
In-Reply-To: <20230725052333.26857-1-rdunlap@infradead.org>
Message-ID: <329bd13b-8970-ce41-1068-2928d4dd7b24@google.com>
References: <20230725052333.26857-1-rdunlap@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 24 Jul 2023, Randy Dunlap wrote:

> A table's header and footer lines must match its text columns in
> width, so extend the header/footer for column 1 to match the text.
> 
> Fixes this documentation build error:
> Documentation/filesystems/tmpfs.rst:116: ERROR: Malformed table.
> Text in column margin in table line 4.
> 
> Fixes: a0ebb5aa2de3 ("tmpfs: fix Documentation of noswap and huge mount options")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Link: https://lore.kernel.org/lkml/3084e97c-3a7d-ace8-2e9c-31642fd663df@google.com/T/#me28ed2124bca2e632eee86ff1d986e5c1f731a7c
> Cc: Hugh Dickins <hughd@google.com>
> Cc: linux-mm@kvack.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> ---
> I guess that Andrew will merge this since he merged the previous patch.

Acked-by: Hugh Dickins <hughd@google.com>

Many thanks, Randy: your rapid rescue service is much appreciated.

> 
>  Documentation/filesystems/tmpfs.rst |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff -- a/Documentation/filesystems/tmpfs.rst b/Documentation/filesystems/tmpfs.rst
> --- a/Documentation/filesystems/tmpfs.rst
> +++ b/Documentation/filesystems/tmpfs.rst
> @@ -110,13 +110,13 @@ configured with CONFIG_TRANSPARENT_HUGEP
>  your system (has_transparent_hugepage(), which is architecture specific).
>  The mount options for this are:
>  
> -===========  ==============================================================
> -huge=never   Do not allocate huge pages.  This is the default.
> -huge=always  Attempt to allocate huge page every time a new page is needed.
> +================ ==============================================================
> +huge=never       Do not allocate huge pages.  This is the default.
> +huge=always      Attempt to allocate huge page every time a new page is needed.
>  huge=within_size Only allocate huge page if it will be fully within i_size.
> -             Also respect madvise(2) hints.
> -huge=advise  Only allocate huge page if requested with madvise(2).
> -===========  ==============================================================
> +                 Also respect madvise(2) hints.
> +huge=advise      Only allocate huge page if requested with madvise(2).
> +================ ==============================================================
>  
>  See also Documentation/admin-guide/mm/transhuge.rst, which describes the
>  sysfs file /sys/kernel/mm/transparent_hugepage/shmem_enabled: which can