Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>
To:     "apopple@nvidia.com" <apopple@nvidia.com>
CC:     "Yedireswarapu, SaiX Nandan" <saix.nandan.yedireswarapu@intel.com>,
        "Saarinen, Jani" <jani.saarinen@intel.com>,
        "Kurmi, Suresh Kumar" <suresh.kumar.kurmi@intel.com>,
        "Nikula, Jani" <jani.nikula@intel.com>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Regression in linux-next
Thread-Topic: Regression in linux-next
Thread-Index: AQHZvsM91PW1SDpunUS9z3A/B3yYEQ==
Date:   Tue, 25 Jul 2023 06:42:54 +0000
Message-ID: <SJ1PR11MB61296D265E3407D447188EF6B903A@SJ1PR11MB6129.namprd11.prod.outlook.com>
References: <SJ1PR11MB6129592BDF5D06949F99816CB95B9@SJ1PR11MB6129.namprd11.prod.outlook.com>
 <SJ1PR11MB6129A7F5C08E2C47748F2BA5B97E9@SJ1PR11MB6129.namprd11.prod.outlook.com>
 <SJ1PR11MB612980562220A376CA90E105B97E9@SJ1PR11MB6129.namprd11.prod.outlook.com>
In-Reply-To: <SJ1PR11MB612980562220A376CA90E105B97E9@SJ1PR11MB6129.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?llmNEzf3RxwS1mIyYh+jkc7NwKfT7c06WTzXojIKrESYeus4rWZVG3xiM5Hf?=
 =?us-ascii?Q?oXvq/OjTE2SBVU/5KDWzIF3aJoVrOSaSHB4gpd4hXndZn5eyBv+pZazmi///?=
 =?us-ascii?Q?R3AZTtYZ7P+p190a2XzzUovD6hAlrhfYySlsF/wWQHiAjcK6RLIz0CpwO5tM?=
 =?us-ascii?Q?b43KD2KIJQ/FczhEhopnms5ENRbtxCmo309eDt/npGRBtZPbwUqQeCxNCrNk?=
 =?us-ascii?Q?nIzsdvSAEIhCcic7/aLFsrHaopDG4FBSgNvXlTbv/tjMM95JuyEv4nv8S41f?=
 =?us-ascii?Q?xfAcfZKucIJcYu21xcx6/biLJZAKVcNrtYtOI3XxEFaR917dRj+ne/7de8oX?=
 =?us-ascii?Q?/3fonvv6RL8uh/5+pubz9slJlF8HtcCtla5/1JuktIdz0D2NY9muUS1zGCj4?=
 =?us-ascii?Q?bYkOv1ZnXMPoyIdMJno9OUnFMTIqTWOsgfINE6+OIaDdor3HzfiDjV82HJgx?=
 =?us-ascii?Q?vqSc7y8pcb+akXQDHrpldz2ISPlH2ZID7+RQcahScncx0USUlOtW1q6Pw/v4?=
 =?us-ascii?Q?VovsTrzykqGlJo8ooTIHCIdEFjt6Al1J7+OHQOcjaCiGQMj3c/a3ZeTsG7t9?=
 =?us-ascii?Q?kW+3CYjVEl1seh2re18t6HPpfjg2Krg19bVqCgmEhP5F8sgw5UGugXJawcIz?=
 =?us-ascii?Q?g9nUl+ZERGTnY++lsIiknC7TMULMZIH8tUlKF+P3Rr/c8CoIj/J8RkMUam34?=
 =?us-ascii?Q?Aa+eYB6xqq+LEDn6aV4o9whyIgEiyXupwKFJhi6AemsuHUeonsXveBcy2eMC?=
 =?us-ascii?Q?ILs4SkwVIWuXOWRC3YWWaw/omvQumZoxHSSpKXUoG2chIqWfZDsBdwUnmO3j?=
 =?us-ascii?Q?wMcNeJl2Dque00f1cTQ0ynCkNGu1qWRGWebp0fhPQbBY9/cUIL8HoqOh2GaO?=
 =?us-ascii?Q?KRRgs+/DjbdxCruIAqz/7mwCwEPQ1ToGMcjRVwDo56zQ73h2HkoR1+6nl/kq?=
 =?us-ascii?Q?i57jMrOv++8G3EaJwFHBzVP62E9DKaArY7zIB3m9nZBcRZBaHsPjZaxE0WwR?=
 =?us-ascii?Q?fM/2hAPhQBJ9VdX4zSH5ZbzsorjHtC1RXVbblpSncbtKMqcNF6eXZw1usEs0?=
 =?us-ascii?Q?cgIj0rFnsBytqQ3UmMJg4ynTezAApIQXn4I3j2aU3/qPjnL1lq1jIISH0xJz?=
 =?us-ascii?Q?7JnyQTX3Kj0o8oFabi1YU7Lfk1kKnVfniw7OXcLnmvwzQ6bWsnRziZjtvkYX?=
 =?us-ascii?Q?G+MPQpGujBSDena7hADAaz3RYCQwrY+NAxtLwBToKsHGvZQ1EExIj2PLnggJ?=
 =?us-ascii?Q?+eB2Oj8YT+c/Csl3JM4C+2Sv+t/1iTljPaY/x2Ti3yH8sSE5vJ+II8jp7qYC?=
 =?us-ascii?Q?pjZ3ZQyiyKZFfqHsiF7WCVVy6iWO5X3K5VhZ6835/FP5M5u/7MHhh4qQRP3H?=
 =?us-ascii?Q?y+A3Ii0A+vEGqVm6HnSxbrqtuhy2G9bUWnu/NbS3a7DQw8e2miZnOxHO4QmZ?=
 =?us-ascii?Q?su6xYTrAqTAdfDOBd+b0Oc/hoRiFTsVcz2CyLL0HBgdsqsdoGd2DzAzY7rBI?=
 =?us-ascii?Q?oICUxUuMzz6PsUbx6rxgZ+kFSZl/Fx8PyjwixZTNYDLRXqqS46BsxnvQkMgS?=
 =?us-ascii?Q?huY2nKJLjnsRV29YPJ9EBh9nyOt4NAaUyzrionIjWq0KZn3R5SuSqSGEh5Xh?=
 =?us-ascii?Q?Dg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6129.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4b6d51c-ff1a-4861-66b7-08db8cda601e
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2023 06:42:54.6256
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BP1iFkwAwe/cZZRI+J4Wvk9kYGsIT/wKWkeYPoxmTadLVdQ/tHts8i9WVhbLLJJRywTEdesL3LO2qY9dv+yQy3tUaLHNiqBrLUDFd/seiwg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5620
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Alistair,

Hope you are doing well. I am Chaitanya from the linux graphics team in Int=
el.
=20
This mail is regarding a regression we are seeing in our CI runs[1] on linu=
x-next
repository.
=20
On next-20230720 [2], we are seeing the following error

<4>[   76.189375] Hardware name: Intel Corporation Meteor Lake Client Platf=
orm/MTL-P DDR5 SODIMM SBS RVP, BIOS MTLPFWI1.R00.3271.D81.2307101805 07/10/=
2023
<4>[   76.202534] RIP: 0010:__mmu_notifier_register+0x40/0x210
<4>[   76.207804] Code: 1a 71 5a 01 85 c0 0f 85 ec 00 00 00 48 8b 85 30 01 =
00 00 48 85 c0 0f 84 04 01 00 00 8b 85 cc 00 00 00 85 c0 0f 8e bb 01 00 00 =
<49> 8b 44 24 10 48 83 78 38 00 74 1a 48 83 78 28 00 74 0c 0f 0b b8
<4>[   76.226368] RSP: 0018:ffffc900019d7ca8 EFLAGS: 00010202
<4>[   76.231549] RAX: 0000000000000001 RBX: 0000000000001000 RCX: 00000000=
00000001
<4>[   76.238613] RDX: 0000000000000000 RSI: ffffffff823ceb7b RDI: ffffffff=
823ee12d
<4>[   76.245680] RBP: ffff888102ec9b40 R08: 00000000ffffffff R09: 00000000=
00000001
<4>[   76.252747] R10: 0000000000000001 R11: ffff8881157cd2c0 R12: 00000000=
00000000
<4>[   76.259811] R13: ffff888102ec9c70 R14: ffffffffa07de500 R15: ffff8881=
02ec9ce0
<4>[   76.266875] FS:  00007fbcabe11c00(0000) GS:ffff88846ec00000(0000) knl=
GS:0000000000000000
<4>[   76.274884] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4>[   76.280578] CR2: 0000000000000010 CR3: 000000010d4c2005 CR4: 00000000=
00f70ee0
<4>[   76.287643] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 00000000=
00000000
<4>[   76.294711] DR3: 0000000000000000 DR6: 00000000ffff07f0 DR7: 00000000=
00000400
<4>[   76.301775] PKRU: 55555554
<4>[   76.304463] Call Trace:
<4>[   76.306893]  <TASK>
<4>[   76.308983]  ? __die_body+0x1a/0x60
<4>[   76.312444]  ? page_fault_oops+0x156/0x450
<4>[   76.316510]  ? do_user_addr_fault+0x65/0x980
<4>[   76.320747]  ? exc_page_fault+0x68/0x1a0
<4>[   76.324643]  ? asm_exc_page_fault+0x26/0x30
<4>[   76.328796]  ? __mmu_notifier_register+0x40/0x210
<4>[   76.333460]  ? __mmu_notifier_register+0x11c/0x210
<4>[   76.338206]  ? preempt_count_add+0x4c/0xa0
<4>[   76.342273]  mmu_notifier_register+0x30/0xe0
<4>[   76.346509]  mmu_interval_notifier_insert+0x74/0xb0
<4>[   76.351344]  i915_gem_userptr_ioctl+0x21a/0x320 [i915]
<4>[   76.356565]  ? __pfx_i915_gem_userptr_ioctl+0x10/0x10 [i915]
<4>[   76.362271]  drm_ioctl_kernel+0xb4/0x150
<4>[   76.366159]  drm_ioctl+0x21d/0x420
<4>[   76.369537]  ? __pfx_i915_gem_userptr_ioctl+0x10/0x10 [i915]
<4>[   76.375242]  ? find_held_lock+0x2b/0x80
<4>[   76.379046]  __x64_sys_ioctl+0x79/0xb0
<4>[   76.382766]  do_syscall_64+0x3c/0x90
<4>[   76.386312]  entry_SYSCALL_64_after_hwframe+0x6e/0xd8
<4>[   76.391317] RIP: 0033:0x7fbcae63f3ab

Details log can be found in [3].

After bisecting the tree, the following patch seems to be causing the
regression.

commit 828fe4085cae77acb3abf7dd3d25b3ed6c560edf
Author: Alistair Popple apopple@nvidia.com
Date:   Wed Jul 19 22:18:46 2023 +1000

    mmu_notifiers: rename invalidate_range notifier

    There are two main use cases for mmu notifiers.  One is by KVM which us=
es
    mmu_notifier_invalidate_range_start()/end() to manage a software TLB.

    The other is to manage hardware TLBs which need to use the
    invalidate_range() callback because HW can establish new TLB entries at
    any time.  Hence using start/end() can lead to memory corruption as the=
se
    callbacks happen too soon/late during page unmap.

    mmu notifier users should therefore either use the start()/end() callba=
cks
    or the invalidate_range() callbacks.  To make this usage clearer rename
    the invalidate_range() callback to arch_invalidate_secondary_tlbs() and
    update documention.

    Link: https://lkml.kernel.org/r/9a02dde2f8ddaad2db31e54706a80c12d1817aa=
f.1689768831.git-series.apopple@nvidia.com


We also verified by reverting the patch in the tree.

Could you please check why this patch causes the regression and if we can f=
ind
a solution for it soon?

[1] https://intel-gfx-ci.01.org/tree/linux-next/combined-alt.html?
[2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/com=
mit/?h=3Dnext-20230720=20
[3] https://intel-gfx-ci.01.org/tree/linux-next/next-20230720/bat-mtlp-6/dm=
esg0.txt