Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3770f13f-0621-48af-4c79-880a0ffaa8a6@suse.com>
Date:   Tue, 25 Jul 2023 09:18:05 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH V3 1/2] xen: Update dm_op.h from Xen public header
Content-Language: en-US
To:     Viresh Kumar <viresh.kumar@linaro.org>
Cc:     Vincent Guittot <vincent.guittot@linaro.org>,
        =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>,
        stratos-dev@op-lists.linaro.org,
        Erik Schilling <erik.schilling@linaro.org>,
        Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
References: <ffae9d7021829fea19fd93fda3c30b52b0af923e.1690190453.git.viresh.kumar@linaro.org>
 <1498bef6-ded0-1b1f-a5ca-e8755800b489@suse.com>
 <20230725070914.m3dxlokedrgjlgcu@vireshk-i7>
From:   Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20230725070914.m3dxlokedrgjlgcu@vireshk-i7>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVI0YXJRTHorTVhGL3pMbytRbE9QOHNVaU5HV3pCZWNHODI3TFZFdUdwQ3Nk?=
 =?utf-8?B?YkdvM0hWbkZtd25lTlRkb1pLbE9Od3FkNzlwVVVaNmo0QUlYdStXYmViZXZt?=
 =?utf-8?B?aHoxQmdPYVQzZmJuRkdwY0dMNjNwN3IwcVNOTG0zQU0wTWJ2eGJKMzFscnBV?=
 =?utf-8?B?K3hsb1FhdVpQS1FQN3k3NVZ3K0VCeFVVQjM3STBtaUY4bk9ETVpZVklnUWZR?=
 =?utf-8?B?c1BDL0t3QW15VE13U2tCczRmK0ZnSzQ3OFpNc1BYemQyK2hCZHdUNHg5Wnlu?=
 =?utf-8?B?RE50ekVLZG1NMEpvcEwyNFJBUndCUVV0TTNtSzZLdW03bDY4elQwSHBlWUpq?=
 =?utf-8?B?Z1JtSHpRRVBXdUZMRzBrN20rcnovcGtjVFIyTUxiazZjaGtKMUFLZ0dLWWpp?=
 =?utf-8?B?K3pWa0dCR2g3czcxZENueGEybEhQQ0l4eFpudVNzY3B4QmZtZllZTDZSOW93?=
 =?utf-8?B?aHlEV09wRmk5bXFWb1ZoZzlHMWtYWm5CbmtFNUVtbmpSQTVTL3FaaUg0MXhq?=
 =?utf-8?B?aFoxc3ovcERabnVCWXRNVFkvNFFSZUhaL0M3WjJZN1paVTRUWlF6N3NKQTJK?=
 =?utf-8?B?Szkwbkt4ZnlnOVgyVHBOT2xYdzBDR0gwSjhmekF1QkVHQi9FLzVDWUtYMXhH?=
 =?utf-8?B?VEdHSG80bWxSL0s5T1RZTzlZQVR0aVJlam9WMy9LYk1rRzdya21BNE9XNlV0?=
 =?utf-8?B?dG1YNUVjRThrNTl0dUU0RFdlcUdJMjRROWRYRTNsRWdBeWduWVdubXBmT0E2?=
 =?utf-8?B?ZEJpN0RIRVlWbkU1VW1XRnNudjRNcTJQaU1NK2QvYnlISFZ5UGxJSXloWFY0?=
 =?utf-8?B?NnpwcTNIZmNROTk3RUJyR0ZiazJYWVhPY3ViS2tzV2trYVZ3WU1YU0l3OGFB?=
 =?utf-8?B?UzdYMlovZzBKckk5Ri8ybldZQTFHaTlwRzN1VGxEbFhueWdOODQvL3pSRnkv?=
 =?utf-8?B?YWZ0YUV5ZWhDakZMV3dQWm5NbFV2L0VWMnY0Zi9JTUxocVJBQWpucUdBd0Zn?=
 =?utf-8?B?ZzVUUk9IeHA4Yy9zL3NYQXkxYndNOFBTM2o2RDh3R09mWkFMS2RSU01TTjV1?=
 =?utf-8?B?YkFXaVRXQlJhaGFWWkQ0cURGV1ZmbGlkZDk1Y2wzNjAzQUNPc0YzVVUwcVht?=
 =?utf-8?B?UkYxYjVoTXFNeXZMd3VFamY3ay9qaUxmaVpsZ2h6TW1JbUpQcWVMSVpYZjIw?=
 =?utf-8?B?U01FVjhMQkZrd01wOHNlQ3l3UG1XRU4xZW9jZFhnUXpYaWE5SkNwS3pGbEI3?=
 =?utf-8?B?UllvdWRaVEtpK01tVlFWOTdyR1RNZkJOZVRERlAzelhkRTIzNWxTVlNFYnd0?=
 =?utf-8?B?dmxBbGtldit2ODFaWGpETlh1M2Y5Wi9YbUg0K2UyZENDZlAzaVBkNWQyanoy?=
 =?utf-8?B?ZGNBb3ppYXVXcmpZYkI0TkZxdTk0MW9Ic1pOaUQyWGJYOTFkMUZWSks4THVy?=
 =?utf-8?B?a21YYTVEMkF0bENXOGo0emdJSjV6UnM2N2NyMVMxeHA4UTcwTHRQL081SXVZ?=
 =?utf-8?B?QUVMczZ6Z3ZyRzBTdFpmS3g0eFQwekJsS2k1UjRwdng4R1NlSWNnbnI2TjVj?=
 =?utf-8?B?NGUxVVcwK2dDZXZjQnpDclMwUlF6UUl3bjlMTDFNbVJoOUFPTUdud1JmZnhX?=
 =?utf-8?B?aSsreUM2RCtwU2h1M3JSMGd1a09XUE1iclphSkVSWnpJRDRCcGlEZW9VUmRh?=
 =?utf-8?B?T1ZaWXovVGMwdS9Tck1MQlp3WXE5ZlgrU2Fwd2pKcFAxWkQ5UmdYbDJFMWdy?=
 =?utf-8?B?K200L2hBZGI0TmxkWTg4bkxzT1lSbjlwMmdTR0drTytkSHllckZHSHM2TXFq?=
 =?utf-8?B?NmhVeFFyTDRRZGpZVUNOZnhCQWhydkFGZWtRYXVwVkR2RnVkZXlpTExzaU9D?=
 =?utf-8?B?T0oxTHJSOGpXUFcyMGw5VWJlTEZSSGFWbnZ1VGVyRzdmS2RmZmd2Ulo1UmtZ?=
 =?utf-8?B?ZUY4UDVWTU1TVVd6bzI4VEpkb2d6MXlOdkFLMWJoMEw2YldvUXVzcGcrbmlo?=
 =?utf-8?B?b2t4SitNbXNzdzU3Q1ZVaTZVdU95TnQ0NFZ5elBFYUVaRDRnSmRaZkpmdVcr?=
 =?utf-8?B?cUV5RzVxWVkzamhTZ0tVWGc2MG5IOVdWQ0NwR1ZINHBTMmRDUldDalBZSXE2?=
 =?utf-8?Q?c0JHU9pvzCLztsofPvDGHoobq?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d9ae417d-a3dd-4223-9432-08db8cdf4b8d
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2023 07:18:07.7375
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xo79Dc1IE5uq52cmMGFbEh8vYrAZFdXGnWbZwUc/MAy+dtJEeBTuRwKJ0mv5J5DPj121EOcuYPu7NrDefjatBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8791
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 25.07.2023 09:09, Viresh Kumar wrote:
> On 25-07-23, 09:04, Jan Beulich wrote:
>> On 25.07.2023 08:47, Viresh Kumar wrote:
>>> +struct xen_dm_op {
>>> +    uint32_t op;
>>> +    uint32_t pad;
>>> +    union {
>>> +        struct xen_dm_op_create_ioreq_server create_ioreq_server;
>>> +        struct xen_dm_op_get_ioreq_server_info get_ioreq_server_info;
>>> +        struct xen_dm_op_ioreq_server_range map_io_range_to_ioreq_server;
>>> +        struct xen_dm_op_ioreq_server_range unmap_io_range_from_ioreq_server;
>>> +        struct xen_dm_op_set_ioreq_server_state set_ioreq_server_state;
>>> +        struct xen_dm_op_destroy_ioreq_server destroy_ioreq_server;
>>> +        struct xen_dm_op_track_dirty_vram track_dirty_vram;
>>> +        struct xen_dm_op_set_pci_intx_level set_pci_intx_level;
>>> +        struct xen_dm_op_set_isa_irq_level set_isa_irq_level;
>>> +        struct xen_dm_op_set_irq_level set_irq_level;
>>> +        struct xen_dm_op_set_pci_link_route set_pci_link_route;
>>> +        struct xen_dm_op_modified_memory modified_memory;
>>> +        struct xen_dm_op_set_mem_type set_mem_type;
>>> +        struct xen_dm_op_inject_event inject_event;
>>> +        struct xen_dm_op_inject_msi inject_msi;
>>> +        struct xen_dm_op_map_mem_type_to_ioreq_server map_mem_type_to_ioreq_server;
>>> +        struct xen_dm_op_remote_shutdown remote_shutdown;
>>> +        struct xen_dm_op_relocate_memory relocate_memory;
>>> +        struct xen_dm_op_pin_memory_cacheattr pin_memory_cacheattr;
>>> +        struct xen_dm_op_nr_vcpus nr_vcpus;
>>> +    } u;
>>> +};
>>
>> Is sync-ing for the sake of sync-ing really useful? For example, are any
>> of the ioreq server elements halfway likely to ever be used in the kernel?
> 
> The only field, out of the union, I am using for now is:
> 
>         struct xen_dm_op_set_irq_level set_irq_level;
> 
> I am not sure if some of the others are going to be used or not in the
> future.

I question that use, btw, but it is not up to me to decide whether to
accept such a layering violation in Linux. dm-op is, as its name says,
for device models to use. Your intended use doesn't fall in that
category, aiui. Imo the present contents of dm_op.h in Linux is indeed
all a kernel is supposed to know about, unless it was to gain in-kernel
device models.

Jan