Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp4147274rwo; Tue, 25 Jul 2023 01:02:30 -0700 (PDT) X-Google-Smtp-Source: APBJJlHT1qvxYO6M+B1bDFvKiDKlX4CsR+7P7+IGfW+x1fRDZSerTPHCZRKKvi5bvQw9G0WsbYgm X-Received: by 2002:a05:6402:2c5:b0:519:6a6a:7659 with SMTP id b5-20020a05640202c500b005196a6a7659mr10331041edx.18.1690272149883; Tue, 25 Jul 2023 01:02:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690272149; cv=none; d=google.com; s=arc-20160816; b=qQ+0TcrxPiCPvDs80FMzcA5Wdgqoj0GwrjJXNM66sg90bfwt/ryrwW/R5EArIw4MCY rkx/hankDntUfVm2WRiVFUBET//EKknNnn2pydpOsvhLBvyQ6gcOKIykp0VV76X1Q3Zi 8I9qKuFLtwkkL6SGjg20bxIZwpRnF8pMpzGLLLM0jcHKB+ORNIq4Oj6I/IgXnTjErNSp ChqHMW4aMZRU6wno0a8qcPeHNi48wwIV7YrctKcobtaWIb6owDfi1+OB0w06b5fX3/d5 0Wwkrg+CdilmJ8ylWTTE95ZlkvgwBcZNEOORMn9gOlhtwiDIgZrBXG96gM855qffPpej 8Bvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=mjQ9DjT0yTaiMVBc3Ma+o3NbfN7zDXILdrptF71yeT8=; fh=+PArvOrmmh0iVc/5XGads6zY/5UXlaaY8lrP6PsZ1cY=; b=cvswbfv96g4FHwlsPRFU2PNQOKRto8nZ5aqHCDugTHfSDakvDoT932iq8GXRhKlC9/ 3lvBbudgGLanExvkmV6qB/1F2nTALF6cPW2jPRsAy+nw3Iv3h/bBKxNiIwr4FFuln3eP vC+Grt7DjTRSP8xLcL5GjPoaR775Oab9zEfezr4GCxNXnB6+G0HX/NqvHTtTKzXPQFo0 Amh22SX4Gp0XGgosNzpSqNAY1tDxZPkVk8PSZGW1l0qwFqAUtgkPd9iW0GKs3Rf8c5+v jDxQpoaWWM8XFzBlMkfCslzVpmE6DFbnG06kQ6HYC1LqD8CElQkcE05FKjxOhoU8scbF BWcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=TpVqrT9y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f21-20020a056402069500b005221d1d1de5si4434128edy.344.2023.07.25.01.02.05; Tue, 25 Jul 2023 01:02:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=TpVqrT9y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232536AbjGYHrK (ORCPT + 99 others); Tue, 25 Jul 2023 03:47:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232001AbjGYHrH (ORCPT ); Tue, 25 Jul 2023 03:47:07 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B527CBD for ; Tue, 25 Jul 2023 00:47:06 -0700 (PDT) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madras.collabora.co.uk (Postfix) with ESMTPSA id DC12066015A0; Tue, 25 Jul 2023 08:47:04 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1690271225; bh=FqkQljsrQQYOynoMT2kuaNXBVI9Ga1goxxlMyTMz8vw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TpVqrT9yeALla9A5G8KsleNW0whIR/H/Z7xqayb6QGZmAsHfE91SHNvep7FB7R3ww fF5BxvA3MWogzwUihj5xkXJLBwV0NGQNSsiovbDAOGm207wFLqm8nDBPeHp2SRwQHQ v5RC1zPn8ZquR8Y7sCR0a6+0wgrZeCNbISd4ruSWFxkCK2r49WnG9cFMVVoqaaowX9 +WYJG72rZ+GKWdT+s3xIZdTon+KyaeEIZw2mLXqh9CazPCfuZzN+WYL+36aR76AkRs +VbJW1HOmaxxIx67dn9a1ljF/lMWNsQG4fCtPxQnWFROSRkfK0aAjGOcjISNiIjKus uNx7TKYgVA/pQ== Date: Tue, 25 Jul 2023 09:47:02 +0200 From: Boris Brezillon To: Dmitry Osipenko Cc: David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Christian =?UTF-8?B?S8O2bmln?= , Qiang Yu , Steven Price , Emma Anholt , Melissa Wen , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v14 10/12] drm/shmem-helper: Refactor locked/unlocked functions Message-ID: <20230725094702.4322fbb5@collabora.com> In-Reply-To: <20230722234746.205949-11-dmitry.osipenko@collabora.com> References: <20230722234746.205949-1-dmitry.osipenko@collabora.com> <20230722234746.205949-11-dmitry.osipenko@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 23 Jul 2023 02:47:44 +0300 Dmitry Osipenko wrote: > Add locked/unlocked postfixes to drm-shmem function names to make clear > where reservation lock is taken and where not. Uh, ignore my comment on patch 1 then... > Add more common helpers to drm_gem_shmem_helper.h I'd do the renaming and exporting in separate patches. > > Suggested-by: Boris Brezillon > Signed-off-by: Dmitry Osipenko