Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a3a401fe-dbc6-03dd-ce6f-13abf30ef984@quicinc.com>
Date:   Tue, 25 Jul 2023 13:44:55 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 1/2] dt-bindings: power: qcom,rpmhpd: Add Generic RPMh PD
 indexes
Content-Language: en-US
To:     Bjorn Andersson <andersson@kernel.org>
CC:     Pavan Kondeti <quic_pkondeti@quicinc.com>, <agross@kernel.org>,
        <konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>
References: <1689744162-9421-1-git-send-email-quic_rohiagar@quicinc.com>
 <1689744162-9421-2-git-send-email-quic_rohiagar@quicinc.com>
 <e77c39fe-b7cf-49b3-9260-ecf4872e8fdf@quicinc.com>
 <7517b2ca-7d7f-dc0c-7f60-a6281b37ab40@quicinc.com>
 <a4zztrn6jhblozdswba7psqtvjt5l765mfr3yl4llsm5gsyqef@7x6q7yabydvm>
From:   Rohit Agarwal <quic_rohiagar@quicinc.com>
In-Reply-To: <a4zztrn6jhblozdswba7psqtvjt5l765mfr3yl4llsm5gsyqef@7x6q7yabydvm>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/22/2023 8:35 AM, Bjorn Andersson wrote:
> On Fri, Jul 21, 2023 at 06:47:42PM +0530, Rohit Agarwal wrote:
>> On 7/21/2023 11:14 AM, Pavan Kondeti wrote:
>>> On Wed, Jul 19, 2023 at 10:52:41AM +0530, Rohit Agarwal wrote:
>>>> diff --git a/include/dt-bindings/power/qcom,rpmhpd.h b/include/dt-bindings/power/qcom,rpmhpd.h
> [..]
>>>> +
>>>> +#endif
>>>> -- 
>>> I see the PD performance levels (RPMH_REGULATOR_LEVEL_xxx) are still
>>> coming from qcom-rpmpd.h. Which means Socs with RPMh also need to
>>> include the older header for these definitions along with this newly
>>> created header. something to improve for the clarity sake?
>> Agreed. I think we can move these to the new header so that the new SoC with
>> RPMH can completely
>> move to rpmhpd.h.
> Sounds very reasonable, please do that in a follow up patch.
> I'm picking this as is.
I have a doubt related to this about sending the patches.

Since I will be moving the regulators level into the same rpmhpd.h 
header, we
would need to update all the qcom soc dtsi file changes as well. Also 
there is a
remaining dt-bindings patch that update the older rpmhpd bindings to 
these new
ones basically the cleanup is remaining.
Shall I create a unified series updating all these in one and tagging 
all the the
related maintainers in the CC
OR
should I create separate series where the dt changes are updated first 
then the
followup cleanup dt-bindings series?

Thanks,
Rohit.
> Thanks,
> Bjorn