Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c8220210-033e-018a-460a-1b87232cfdb8@ti.com>
Date:   Tue, 25 Jul 2023 13:53:14 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] arm64: dts: ti: k3-am62a7-sk: Enable dual role support
 for Type-C port
To:     Roger Quadros <rogerq@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
References: <20230724115133.2226-1-r-gunasekaran@ti.com>
 <c907c3aa-84b8-c667-e8ea-dd7e5bd4a54b@linaro.org>
 <1fed3f09-75e4-bb44-71d7-f7319f1b0c3c@ti.com>
 <dd800ec2-684a-d6fc-2fb3-d146b95a8370@kernel.org>
Content-Language: en-US
From:   Ravi Gunasekaran <r-gunasekaran@ti.com>
In-Reply-To: <dd800ec2-684a-d6fc-2fb3-d146b95a8370@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/25/2023 1:13 PM, Roger Quadros wrote:
>
> On 25/07/2023 07:19, Ravi Gunasekaran wrote:
>>
>> On 7/24/2023 7:27 PM, Krzysztof Kozlowski wrote:
>>> On 24/07/2023 13:51, Ravi Gunasekaran wrote:
>>>> USB0 is interfaced with a Type-C DRP connector and is managed via a
>>>> USB PD controller. Add support for the Type-C port with dual data
>>>> and power sink role.
>>>>
>>>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
>>>> ---
>>>>  arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 33 +++++++++++++++++++++++++
>>>>  1 file changed, 33 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>>>> index d2cca6182738..b478b794de00 100644
>>>> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>>>> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
>>>> @@ -226,6 +226,24 @@
>>>>  	pinctrl-names = "default";
>>>>  	pinctrl-0 = <&main_i2c0_pins_default>;
>>>>  	clock-frequency = <400000>;
>>>> +
>>>> +	typec_pd0:tps6598x@3f {
>> Thanks for reviewing the patch.
>>
>>> Missing space after:
>> I will fix this in v2.
>>
>>> Node names should be generic. See also an explanation and list of
>>> examples (not exhaustive) in DT specification:
>>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>> Thanks for pointing to the section. I checked it and also few other node names
>> in the existing DTs.
>> TPS6598 is a USB Type C and Power Delivery Controller. So does a node name
>> "type-c-pd-controller" sound fine?
> Type-c is irrelevant in node name.
> The name needs to indicate it has something to do with USB, Power Control and Role control.
>
> e.g.
> usb-power-controller
> or
> usb-role-controller
> ?

I will use the node name "usb-power-controller'.

>
>>> Best regards,
>>> Krzysztof
>>>
>> Regards,
>> Ravi