Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   carlos.song@nxp.com
To:     u.kleine-koenig@pengutronix.de, andi.shyti@kernel.org,
        aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com
Cc:     carlos.song@nxp.com, xiaoning.wang@nxp.com, haibo.chen@nxp.com,
        linux-imx@nxp.com, linux-i2c@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4] i2c: imx-lpi2c: return -EINVAL when i2c peripheral clk doesn't work
Date:   Tue, 25 Jul 2023 16:31:17 +0800
Message-Id: <20230725083117.2745327-1-carlos.song@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZwaZWpRFVRlXQKHtDOmnnqSHu2j8vboRVFnQJS4eLyLZSCIzWi0evPiNY+gr?=
 =?us-ascii?Q?CZFtTF0XD4VcAOvTLeWFis9Kttj8bQ2zelHSQxs/Hv4zwWohzTT8SV8irhd5?=
 =?us-ascii?Q?EJzwFIX7r9IaF9BhSfCIh60CkMf9gp9JqQ65Wc9l7O4Oc/mynoneDzrYPEP6?=
 =?us-ascii?Q?j1vpJ+1bKJ55505I9nGuewwpmNmE62y+x06Qe/TQQMtRx0PnbbWzxE42QhoE?=
 =?us-ascii?Q?MdRxEc8mUqAvA6vIdjEP976ndtxI/RwF3XhAuGAUm1pYT/PgcoLRW8/LC7LV?=
 =?us-ascii?Q?m/MZ+L/b+y9foBc3omiIDNCk3y1zEntL9BwrdfC0sYDh3mq/zA2dCvQNzlFf?=
 =?us-ascii?Q?Ja06IttwAg64b4LzyEcVMKvJBTdHzWN/Xan+7NEx3VKJ3fl7bSjB4vpXsDWR?=
 =?us-ascii?Q?QiADXAoiXGM0tzsWKtko3xtWYDD18ZCvNxLricYeJOnyG/VTzjLcpxroXF7V?=
 =?us-ascii?Q?vldPei7KsbfcmCj/A1UiS+MxTiwJRgw8JotMjsrax47UCuRwfMKwPKTlKqd3?=
 =?us-ascii?Q?YIoBiDSbdCaydg8EJDvhgx5VoQSfy4jw4SqUOEXy0ulUTbLYTqN+HoWTmW7o?=
 =?us-ascii?Q?EcdgxiUmd9usOFvLON/7Us2ZXp7d5JQMJYGDQFuc+RXIwQvyeGKPVJ1DdKKv?=
 =?us-ascii?Q?ROqs+OzMUnkJjQyBB6s8QYUPmPRpstLF5IddM2TMUL7ojeD+OWGLtmJlM6/L?=
 =?us-ascii?Q?YFv1WcXtR6Dw0gHiF9TvZ9pUXOYvU+hbt9FPxXlHW0m4JrAA+lkZjP2KoCr7?=
 =?us-ascii?Q?O+Ye5ZzbvFYRvrvLhO4znGYYeqPhT0Qaot1USVvi6Wg1ZKGJ09JP7LePrNWk?=
 =?us-ascii?Q?hEHTE5Oqh9j7bT8tvINKQTwlc3LoaD+fWvN3i+pQ9xsfAgrZFd2zi9CsVifX?=
 =?us-ascii?Q?dH6Ru6KpMMbhMIhfT8Z6CNTRto5SC+AB/gutyolqnitboplpNgSUUlNZCYVY?=
 =?us-ascii?Q?s5A0Aj6t6y8oJD0NCphS/AELJrSmJTHBFGInjjMpv+bFx2LHuY9VGKgztzPj?=
 =?us-ascii?Q?jkm7lMCNsM0yOD/tg27PudmDavJmH0rcaZGgOL0d7jeP3woo+wiRK0s3T0gm?=
 =?us-ascii?Q?vAwpVZFpe9OkH+zZlpCuQ2kKhjpDcfpw0IPTMhTxjluE1mUKLwzfTFHM12Lc?=
 =?us-ascii?Q?r92yzPFopHYOTWWsav8vliPlJslFMI5FXJXF7Tb03XpoBpA8SUIdfOSbxqAV?=
 =?us-ascii?Q?wK2mxjW8Pprm101BYYXaPrJckKKAmQpqv6LUu4FZG+ea3YGgjD+L8UWnPExU?=
 =?us-ascii?Q?VvcbAqzInJxF4pCTv0u7USdcKPyQuofKtkyQmJ5ogNlu12xBlzaWazEZUi/6?=
 =?us-ascii?Q?Nse0bpuX73rnIuqvKImpVg90hiKWfEmGzA+sGZUhingOjCTTOw+fTmiH6cFm?=
 =?us-ascii?Q?betgYz1d+Mc0PJ3QDgF3h9W2OzxgD54rUKh/1FPiA1sB2W63RhCdrbL5+6k4?=
 =?us-ascii?Q?UvD2t+9Zn6q5s/Miuv3vGb4c0S1igSVcSvQGOy6FXZubxd4gMiUuCs06CbK3?=
 =?us-ascii?Q?ylCPlXKDOV8TVXtmFLlox4kYD9FTcaGiNx9heAIAH2axvY1uAACi9vY9Y4bE?=
 =?us-ascii?Q?YI6uzqFnMT88e4iy4hV5mEdn+bYHJildi189dy34?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bc1e4165-69a5-43b8-2273-08db8ce8fe45
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5005.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2023 08:27:33.2814
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WdXnR2YREnVtJu5PL1UuSHX5on99GJGkFAglZIl8TCoool0v0EAnjpWpNv8gViVC0Z+4zjHREJbny1v7wo/omA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8562
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Gao Pan <pandy.gao@nxp.com>

When i2c peripheral clk rate is 0 directly return -EINVAL.

Signed-off-by: Gao Pan <pandy.gao@nxp.com>
Signed-off-by: Carlos Song <carlos.song@nxp.com>
---
Changes for V2:
- adjust the subject from "debug message" to "error message"
Changes for V3:
- remove output error log when i2c peripheral clk doesn't work
- adjust commit log and subject
---
 drivers/i2c/busses/i2c-imx-lpi2c.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
index c3287c887c6f..150d923ca7f1 100644
--- a/drivers/i2c/busses/i2c-imx-lpi2c.c
+++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
@@ -209,6 +209,9 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct *lpi2c_imx)
 	lpi2c_imx_set_mode(lpi2c_imx);
 
 	clk_rate = clk_get_rate(lpi2c_imx->clks[0].clk);
+	if (!clk_rate)
+		return -EINVAL;
+
 	if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST)
 		filt = 0;
 	else
-- 
2.34.1