Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Jul 2023 11:38:48 +0200
From:   Petr Mladek <pmladek@suse.com>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Luis Chamberlain <mcgrof@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>, Rong Tao <rongtao@cestc.cn>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Will Deacon <will@kernel.org>,
        Quentin Perret <qperret@google.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] samples/hw_breakpoint: fix building without module
 unloading
Message-ID: <ZL-YKHxMfTIg16Hl@alley>
References: <20230725082546.941346-1-arnd@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230725082546.941346-1-arnd@kernel.org>
Precedence: bulk

On Tue 2023-07-25 10:25:36, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> __symbol_put() is really meant as an internal helper and is not available
> when module unloading is disabled, unlike the previously used symbol_put():

Ah, I have missed this.

> samples/hw_breakpoint/data_breakpoint.c: In function 'hw_break_module_exit':
> samples/hw_breakpoint/data_breakpoint.c:73:9: error: implicit declaration of function '__symbol_put'; did you mean '__symbol_get'? [-Werror=implicit-function-declaration]
> 
> The hw_break_module_exit() function is not actually used when module
> unloading is disabled, but it still causes the build failure for an
> undefined identifier. Enclose this one call in an appropriate #ifdef to
> clarify what the requirement is. Leaving out the entire exit function
> would also work but feels less clar in this case.

> --- a/samples/hw_breakpoint/data_breakpoint.c
> +++ b/samples/hw_breakpoint/data_breakpoint.c
> @@ -70,7 +70,9 @@ static int __init hw_break_module_init(void)
>  static void __exit hw_break_module_exit(void)
>  {
>  	unregister_wide_hw_breakpoint(sample_hbp);
> +#ifdef CONFIG_MODULE_UNLOAD
>  	__symbol_put(ksym_name);
> +#endif
>  	printk(KERN_INFO "HW Breakpoint for %s write uninstalled\n", ksym_name);
>  }

I see that both symbol_put() and symbol_put_addr() are defined
as noops twice:

   + when !defined(CONFIG_MODULE_UNLOAD)
   + when !defined(CONFIG_MODULES)

This patch is enough because samples/hw_breakpoint/data_breakpoint.c
could be built only as a module, so feel free to use:

Reviewed-by: Petr Mladek <pmladek@suse.com>

But even better solution would be to define symbol_put_name() as
a noop in both situations and use it.

Best Regards,
Petr