Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d80ed0b8-c92a-f76a-6ed9-b844d58c0d14@redhat.com>
Date:   Tue, 25 Jul 2023 11:09:42 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] docs: mm: Fix number of base pages for 1GB HugeTLB
Content-Language: en-US
To:     Usama Arif <usama.arif@bytedance.com>, songmuchun@bytedance.com
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, fam.zheng@bytedance.com,
        liangma@liangbit.com
References: <20230207114456.2304801-1-usama.arif@bytedance.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20230207114456.2304801-1-usama.arif@bytedance.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 07.02.23 12:44, Usama Arif wrote:
> 1GB HugeTLB page consists of 262144 base pages.
> 
> Signed-off-by: Usama Arif <usama.arif@bytedance.com>
> ---
>   Documentation/mm/vmemmap_dedup.rst | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/mm/vmemmap_dedup.rst b/Documentation/mm/vmemmap_dedup.rst
> index a4b12ff906c4..689a6907c70b 100644
> --- a/Documentation/mm/vmemmap_dedup.rst
> +++ b/Documentation/mm/vmemmap_dedup.rst
> @@ -1,3 +1,4 @@
> +
>   .. SPDX-License-Identifier: GPL-2.0
>   
>   =========================================
> @@ -17,7 +18,7 @@ HugeTLB pages consist of multiple base page size pages and is supported by many
>   architectures. See Documentation/admin-guide/mm/hugetlbpage.rst for more
>   details. On the x86-64 architecture, HugeTLB pages of size 2MB and 1GB are
>   currently supported. Since the base page size on x86 is 4KB, a 2MB HugeTLB page
> -consists of 512 base pages and a 1GB HugeTLB page consists of 4096 base pages.
> +consists of 512 base pages and a 1GB HugeTLB page consists of 262144 base pages.
>   For each base page, there is a corresponding ``struct page``.
>   
>   Within the HugeTLB subsystem, only the first 4 ``struct page`` are used to

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb