Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7c6d14f3-0453-af11-de07-db937c49e60e@suse.com>
Date:   Tue, 25 Jul 2023 12:00:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v4 01/32] xhci: add support to allocate several
 interrupters
Content-Language: en-US
To:     Wesley Cheng <quic_wcheng@quicinc.com>, agross@kernel.org,
        andersson@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        catalin.marinas@arm.com, will@kernel.org, mathias.nyman@intel.com,
        gregkh@linuxfoundation.org, lgirdwood@gmail.com,
        broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
        srinivas.kandagatla@linaro.org, bgoswami@quicinc.com,
        Thinh.Nguyen@synopsys.com
Cc:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-usb@vger.kernel.org, alsa-devel@alsa-project.org,
        quic_jackp@quicinc.com, pierre-louis.bossart@linux.intel.com,
        oneukum@suse.com, albertccwang@google.com, o-takashi@sakamocchi.jp,
        Mathias Nyman <mathias.nyman@linux.intel.com>
References: <20230725023416.11205-1-quic_wcheng@quicinc.com>
 <20230725023416.11205-2-quic_wcheng@quicinc.com>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20230725023416.11205-2-quic_wcheng@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wk5ielUyMGJJUnpwRXZ3MVJsV2tSZDBiNEkydyswRTdOL0NDKzF1RWVLejJP?=
 =?utf-8?B?MXZMSVJQUFdTRVJISjZmSEF4MzdKUy9qa3hVTWx6WDY2dUMzcEVYTXR2Y3RP?=
 =?utf-8?B?RFZCRHpqcmluN01EL2pubjEyY292eEdLZU1lUytrQ3pLdkNBcW51bXJ3VjhN?=
 =?utf-8?B?eHVjUTNXOUsrQ3VvWjY5MkJaUmMwREh0TUxjUGllRzNRZ3NQS2lwcXNSaVF2?=
 =?utf-8?B?RzJNVGJ2cGVaMjVXa3lyRjRCcW9yaTVuR0M1Ny9WS28wVnlzZE9YQWVndjN2?=
 =?utf-8?B?cmpvZDl2b3RHZHdkNXdScUgzUWw4bzc5VlovV1dtRk14ZTFOWE10bDVhS0xv?=
 =?utf-8?B?N2QyM1libkVUMytyMDNXUUk4RGFHWXo1QWRLR1NzajBPVC94Q1VCMExraC9M?=
 =?utf-8?B?azQzbjdWd2tGUXJWbUpBeEYrQTJkZUJDcldZek9YL1dyU2NoOGhOMGg3dVdj?=
 =?utf-8?B?Vi8vdkcwZlhjdWthaHQzL3NwSFBjRXgxeGJEQUlpTVpGL051WXJrVTNuWFVY?=
 =?utf-8?B?MkZ1a2hBb0I4VFpqSnFvcXo0NWpMMktnTlJad0RPVlFaZFlsTDR5aWtIb01r?=
 =?utf-8?B?LzdyZTBOc2ZZbU9mdzRuTGxBaG9iRFVoK05wZlU3M0JBbC9XWWc3eERmM3d3?=
 =?utf-8?B?aGExbW5mbElEbCtYYkI5L0Flc2tWNUVhTHFDOVhhKzlnR1ZWMDJ6eld5czJ6?=
 =?utf-8?B?anlqUUNNUWZvbjN5WVlHWnBRL2hnYmlVTFQwZU8xZ09VRXJVRXo3bjhmV1lK?=
 =?utf-8?B?ckppNndMeVBSTDFGcFFXK1doNmhmbWNkOEVWSnovTlY3RGErWGFMeDJ5S1lz?=
 =?utf-8?B?bUFNUlVaemdxZzhpWDlKK3N1VjN0WlJiZFllUnh1cjJITWRienBqZSt3UUUx?=
 =?utf-8?B?blZvL2dIaXNTUngzRndMTFRFSi81WElGeEFSdWVSUnhwN1dKMTJMeWRZNVFD?=
 =?utf-8?B?dURJd0FXc0QxcXUzZ0t4QTJxeXpzSm9qc2hCOFN3VGEvL2M2elphbmNBQk9l?=
 =?utf-8?B?MjBZVjJvajZ0cXhlVzVYbjU5VlNIbkh6TmlvN0l3bHF2YmVYeXBpL2tEcWFC?=
 =?utf-8?B?Q0xyTngxeUdzWVJwdDlkejFyb3FsT3lkQXFYbVdUMTFSczBtZWY4YytNUDJW?=
 =?utf-8?B?UWowOWNjVWFhODJ5eGp0S2tPNGhrWUl1VUowbWlVS3VxbnpTdFU0cDcxWFp5?=
 =?utf-8?B?clgvSHRoUUVCN2lEYXJjMDBQaFdvWE9KWm1rbGRFQ1RBOE5hSERkcTZRYnZm?=
 =?utf-8?B?SVBmbW1DWUwxWkNPbGNoakxWNWVPZ1BSWjkxdVRPbFdDQlAxMWxWZ3Z2QWJJ?=
 =?utf-8?B?SXVjd0d1N1JnL2NPbENIUm9sMWNGU3M2SGhMVDBXOHhWNzZYcnpvTDJnMXpz?=
 =?utf-8?B?cEtCZ05oeWtOb3pEZE9IczJWa3c1K1NsaExEci9qOGxXVDQwY1dnNjlDOXA4?=
 =?utf-8?B?MWpiN25BL3lMQ3R0MWczWEVJWW5zb013YnA2OHNsMUJWVUZpTWx1OTNVaFZS?=
 =?utf-8?B?dG5qc2RORm54SWF5K2JMZUd6ZlBkalZSOFMxVGZPOVZqWENNRVlHVnJxc04z?=
 =?utf-8?B?N3BvVVNEOGdncGo4MllpMmsySUVDdUYweU1jUDAySVZIMlVLT1dJSG1CK1pS?=
 =?utf-8?B?WjZqdGMvajhvTnp2Yjh3Nmc1YlR0WjMvRmxIWmE1YW4yazl6SzNrMnZSMHJz?=
 =?utf-8?B?YzVXNnNER0F2bVFORGo3blQ3TVpDU0VqSmJCYm9MdVRRRmUxL1kxa3pLSjlr?=
 =?utf-8?B?S0lCK09waXVwOUd6K1RuZFp4NVdWNVlEWVdLY3FEbURabFZzYXpvWVZYQm9W?=
 =?utf-8?B?ZmJrdXZnMk5HelBFZk5sNkY5MmY1NjN3MGxYYVB5U0ZDTzNCQ0VUdXlYNGpT?=
 =?utf-8?B?aGoxM252MGFsTURPdndySXBRd1ovQXU0K0YxNXVuU0czTVVNYkpSQng2Q1V2?=
 =?utf-8?B?WXhzanVaRjJqZmxWcGgzeHgrQThRVW5GTURQZmdHT01scDlxQ1BlTGJwSE54?=
 =?utf-8?B?VFY4dGRjY0FCYTlQT29IL1pWeU9sajZOKzBESlp1dVJGb2hHOHlubStJUldV?=
 =?utf-8?B?MDB6UVRTRmtqSm5SZ0pseUd6cFhRZ3Z4UllvZUZLWFZpZzVjTERnNHViYkEv?=
 =?utf-8?B?S1lyS2E3dHFuWVMrOHdpbFVpT1pzYVhJVmd0Q283Y0tnTlp4WHM1RE04Q05l?=
 =?utf-8?Q?mTTTFIuIbfcGYXZJRyb8pjs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56647b15-185a-44d8-15c9-08db8cf60a13
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2023 10:00:56.3933
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QIcKURQ3k3vf6Tw4a687trQSECJf8K/3oc4boMXdevNaxqDEvY7TydWGfUQCRzYFfSbrMpWTdpaM/ubWbLm/xQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7509
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 25.07.23 04:33, Wesley Cheng wrote:

Hi,

this is more of a stylistic remark, but this:

[..]
> +	/* Find available secondary interrupter, interrupter 0 is reserverd for primary */
> +	for (i = 1; i < xhci->max_interrupters; i++) {
> +		if (xhci->interrupters[i] == NULL) {
> +			err = xhci_add_interrupter(xhci, ir, i);
> +			break;
> +		}
> +	}
> +
> +	spin_unlock_irq(&xhci->lock);
> +
> +	if (!err) {

Making the non error case a conditional return is ...

> +		xhci_dbg(xhci, "Add secondary interrupter %d, max interrupters %d\n",
> +			 i, xhci->max_interrupters);
> +		return ir;
> +	}
> +
> +	xhci_warn(xhci, "Failed to add secondary interrupter, max interrupters %d\n",
> +		  xhci->max_interrupters);
> +
> +	xhci_free_interrupter(xhci, ir);
> +
> +	return NULL;
> +}

Was this taken out of a style guide that teaches to avoid "goto"
at any cost?

	Regards
		Oliver