Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6008bc09-7746-546f-2c00-9b9812854ff7@gmail.com>
Date:   Tue, 25 Jul 2023 11:46:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 6/7] arm64: dts: qcom: msm8976: Split lpass region
Content-Language: en-US
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht,
        Bjorn Andersson <andersson@kernel.org>,
        Andy Gross <agross@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        AngeloGioacchino Del Regno <kholk11@gmail.com>,
        Marijn Suijten <marijn.suijten@somainline.org>,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230723160827.22660-1-a39.skl@gmail.com>
 <20230723160827.22660-7-a39.skl@gmail.com>
 <fda13f70-1062-c3dc-b3ed-c7f1ad9a07db@linaro.org>
From:   Adam Skladowski <a39.skl@gmail.com>
In-Reply-To: <fda13f70-1062-c3dc-b3ed-c7f1ad9a07db@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 25.07.2023 10:44, Konrad Dybcio wrote:
> On 23.07.2023 18:08, Adam Skladowski wrote:
>> Some devices like Sony Loire uses Broadcom module over sdc3 however others
>> utilize qcom WCNSS, split shared region based on downstream pil-tz loader.
>>
>> Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
>> ---
> Looks like 0x1800000 is the generic configuration:
>
> https://git.codelinaro.org/clo/la/kernel/msm-3.10/-/blob/LA.BR.1.3.7.c26-05300-8976.0/arch/arm/boot/dts/qcom/msm8976.dtsi#L93-98
>
> Konrad

Yes, indeed however as you probably noticed this region isn't called lpass rather reloc.

Downstream sometimes tends to define pools of memory where loader will do its own job.

If you read later wcnss/lpass both point to same shared memory which im not sure without reworks will work with mainline.

On top it's not really that it will even hurt Loire at the end, if you browse around internet you can easily find gists
from Pavel which have logs of pil-tz loading of lpass:

https://gist.github.com/bartcubbins/c2ff215f39fe2b3ed5d3f8444bcec83b#file-gistfile1-txt-L1289

As you can see even on loire where region is bigger it only loads first 0x1000000.
Do we really need to complicate things just for everyone else for sake of not ending with one platform having to adjust
or even not(it probably wouldn't even make a difference for loader as it will fit anyway)

On the ending note i apologize if this msg gets broken formatting first time using thunderbird
and after redesign im unable to find most options mentioned in guide.
.