Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp4286704rwo; Tue, 25 Jul 2023 03:56:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlEIFFHLBs8p4Hply8RZnB1XehGA2GkoyO9rax3qRTNYQTdMyUy0AmN4o3ykE0J4gz2WOccv X-Received: by 2002:a05:6e02:154c:b0:348:d2fe:145e with SMTP id j12-20020a056e02154c00b00348d2fe145emr3064514ilu.1.1690282576454; Tue, 25 Jul 2023 03:56:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690282576; cv=none; d=google.com; s=arc-20160816; b=joJs0yQeDEc32cXOO3ZzFrM3qghPHGSYHhRwjMY+w+FXt3b1S+zMo82Ifko5bPPn9B Nocg/3x/fQ0vQGMuSJEzfWejFuY1sBEumP+jVJ3II2iXBm3U2sTZr9xyAyiY/TLHkYnx b7xq1Uo7tA6I6RKZfJ7dhTsne0dQQjYYDRngRk8+yeJcdOgP9lNGgutDpdE++/+qFsja gYlFt8mmhswkKpZ3Zv7ikf+yOmyumdDlTH96pIavjqWLY61UbnADSs1V06MYbKoaporL fx/26Y5WXG5ogfNRYLlcalqbVjGk5e8SjaXheEkRRT6X+UE/K/FqFzNLc5GibPAd1moj v8ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Hhl3+BBXk934TLJ9S2mLWHpMN6zvsY9iMbXXNp0vMIw=; fh=4ZLxk9WgAV0qAml8rnjq/bF/33nczUcN7lbsDuTErnk=; b=sKGC64yxB6T6gm+6q1/1v05ehl5YAFwV/rzd/MeF6YoecxT+hUNYW9QezkL9knvNNM xgd0r5oFbqnHuBY578z7oeeEy0RuXylcx5c0dVGNoaYmhjOCVBb9sHP7XB4bbNOueMcx v7MpNilt1Ur34gzKZ7Jj/EhSWWzm8RlxPq54fEX+LWXiYcZgZKTrzRNa9o2Ai7rkHgO6 ju07P6qNxzIwYPTrxYrXSz0aZ/GYKX+mYZpdtOy+LVr9Cflk12fmWag7q5AshSbrE5wU fARQh7RqMRdoqRl61WD8151UfQogn3Fwe2j2tXnO9499lEH52+16tZU+OFgqgoeeVvOR FZuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h10-20020a056a001a4a00b0068050054196si11412488pfv.299.2023.07.25.03.56.04; Tue, 25 Jul 2023 03:56:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232791AbjGYKld (ORCPT + 99 others); Tue, 25 Jul 2023 06:41:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231926AbjGYKlc (ORCPT ); Tue, 25 Jul 2023 06:41:32 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40639194; Tue, 25 Jul 2023 03:41:31 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10781"; a="371294155" X-IronPort-AV: E=Sophos;i="6.01,230,1684825200"; d="scan'208";a="371294155" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 03:41:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10781"; a="791330446" X-IronPort-AV: E=Sophos;i="6.01,230,1684825200"; d="scan'208";a="791330446" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 25 Jul 2023 03:41:28 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qOFTr-005j2B-0f; Tue, 25 Jul 2023 13:41:27 +0300 Date: Tue, 25 Jul 2023 13:41:26 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org, Alexandru Ardelean Subject: Re: [PATCH v2] gpio: lp3943: remove unneeded platform_set_drvdata() call Message-ID: References: <20230725102532.3989-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725102532.3989-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 25, 2023 at 01:25:32PM +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call, to access the private data of the driver. > Also, the private data is defined in this driver, so there is no risk of > it being accessed outside of this driver file. Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko