Subject: Re: fixing up DRM device model usage
From: Kay Sievers <kay.sievers@vrfy.org>
To: Jesse Barnes <jesse.barnes@intel.com>
Cc: Greg KH <gregkh@suse.de>, dri-devel@lists.sourceforge.net,
       linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
       Pavel Machek <pavel@ucw.cz>, jbarnes@virtuousgeek.org
In-Reply-To: <200710261431.48589.jesse.barnes@intel.com>
References: <200710181401.50470.jbarnes@virtuousgeek.org>
	 <200710261140.41016.jbarnes@virtuousgeek.org>
	 <1193425738.2190.45.camel@lov.site>
	 <200710261431.48589.jesse.barnes@intel.com>
Content-Type: text/plain
Date: Sat, 27 Oct 2007 23:12:15 +0200
Message-Id: <1193519535.5776.16.camel@lov.site>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 737
Lines: 19

On Fri, 2007-10-26 at 14:31 -0700, Jesse Barnes wrote:
> On Friday, October 26, 2007 12:08 pm Kay Sievers wrote:

> > The open coded: device_create_file(&dev->dev, &device_attrs[i])
> > should probably replaced by passing the array to the class, and the
> > core will do that for you.
> 
> You mean just set drm_class->dev_attrs = device_attrs?  I didn't see in
> the core device model code where that would create the files...

Yeah, it is in device_add_attrs() in drivers/base/core.c.

Kay

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/