Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1689703232-24858-1-git-send-email-schakrabarti@linux.microsoft.com>
 <20230719070826.GF8808@unreal>
In-Reply-To: <20230719070826.GF8808@unreal>
From:   Souradeep Chakrabarti <souradch.linux@gmail.com>
Date:   Tue, 25 Jul 2023 15:19:24 +0530
Message-ID: <CABNGXZr+rM7B-inQayHuQAYv17DP3mEKgcXCPHr30BO6xzzaxw@mail.gmail.com>
Subject: Re: [PATCH V4 net-next] net: mana: Configure hwc timeout from hardware
To:     Leon Romanovsky <leon@kernel.org>
Cc:     Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>,
        kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
        decui@microsoft.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, longli@microsoft.com,
        sharmaajay@microsoft.com, cai.huoqing@linux.dev,
        ssengar@linux.microsoft.com, vkuznets@redhat.com,
        tglx@linutronix.de, linux-hyperv@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org, schakrabarti@microsoft.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jul 19, 2023 at 12:43=E2=80=AFPM Leon Romanovsky <leon@kernel.org> =
wrote:
>
> On Tue, Jul 18, 2023 at 11:00:32AM -0700, Souradeep Chakrabarti wrote:
> > At present hwc timeout value is a fixed value. This patch sets the hwc
> > timeout from the hardware. It now uses a new hardware capability
> > GDMA_DRV_CAP_FLAG_1_HWC_TIMEOUT_RECONFIG to query and set the value
> > in hwc_timeout.
> >
> > Signed-off-by: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>
> > ---
> > V3 -> V4:
> > * Changing branch to net-next.
> > * Changed the commit message to 75 chars per line.
> > ---
> >  .../net/ethernet/microsoft/mana/gdma_main.c   | 30 ++++++++++++++++++-
> >  .../net/ethernet/microsoft/mana/hw_channel.c  | 25 +++++++++++++++-
> >  include/net/mana/gdma.h                       | 20 ++++++++++++-
> >  include/net/mana/hw_channel.h                 |  5 ++++
> >  4 files changed, 77 insertions(+), 3 deletions(-)
>
> <...>
>
> >       gc->hwc.driver_data =3D NULL;
> >       gc->hwc.gdma_context =3D NULL;
> > @@ -818,6 +839,7 @@ int mana_hwc_send_request(struct hw_channel_context=
 *hwc, u32 req_len,
> >               dest_vrq =3D hwc->pf_dest_vrq_id;
> >               dest_vrcq =3D hwc->pf_dest_vrcq_id;
> >       }
> > +     dev_err(hwc->dev, "HWC: timeout %u ms\n", hwc->hwc_timeout);
>
> Why do you print this message every time and with error level?
> Probably you should delete it.
>
In V5 I have changed it to dev_dbg from dev_err.
> Thanks