Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752240AbXJ0WYW (ORCPT ); Sat, 27 Oct 2007 18:24:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750984AbXJ0WYM (ORCPT ); Sat, 27 Oct 2007 18:24:12 -0400 Received: from netrider.rowland.org ([192.131.102.5]:3528 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750895AbXJ0WYL (ORCPT ); Sat, 27 Oct 2007 18:24:11 -0400 Date: Sat, 27 Oct 2007 18:24:10 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Maxim Levitsky cc: linux-kernel@vger.kernel.org, , Subject: Re: [linux-pm] QUESTION: How to fix race between .suspend routine and watchdog timer In-Reply-To: <200710272119.44574.maximlevitsky@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 732 Lines: 19 On Sat, 27 Oct 2007, Maxim Levitsky wrote: > > Use del_timer_sync(). It guarantees that when it returns, the timer > > will be stopped and the timer routine will no longer be running on any > > CPU. > > > Even if the timer re-enables itself, are you sure? Last time I looked at the source code, that's what it did. I'll look again... Yep, it still does. It checks to see if the timer routine is currently running; if so then it waits a little while and tries again. Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/