Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp4384761rwo; Tue, 25 Jul 2023 05:29:26 -0700 (PDT) X-Google-Smtp-Source: APBJJlFqsaIvOY4b+/XHpMXTU1nahmPot5Vszg6jf8X1hyxxHgv/16YVNG4x7g3Jw8BkboCHIpf2 X-Received: by 2002:a17:90b:1806:b0:262:ded7:63d with SMTP id lw6-20020a17090b180600b00262ded7063dmr11464011pjb.17.1690288166323; Tue, 25 Jul 2023 05:29:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690288166; cv=none; d=google.com; s=arc-20160816; b=aMa/edQ+v6XbXRZJoHiwVGUwlicVP1W9vCpLgSlmcmT0ex01kgmTVGh533F0MSd2kC sU+h4uxWNzn7rheHOarShm+QG1hA5ejXR4RvrZ6NuuOTqMTJHUtk2vrDvdn+xIWNMQ3Q 5fwjtdXhGKiAhUFvqKjfSuQt/6/eePWem6ryryaJ4sGUzVPerVlJDtnGIYNF4hTwVlBq gwL4G5enRavSRWrdvDkdVgJFO38z1TEOu9rwGag1S1EgrtUNgrlVo87TYI+jkvd2LA1U hnPccxD8TEkDEIex78AeYwE0yjUcqhdIgROhUbvNvgN0wrASdgQ31qM8Npam9GFjLF+M U6Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=1je98xYKk91uty9V//ddQUBh34yh1GHtboW9x39SKW8=; fh=6UACpRHD6QFMV/0syzGn/KwmShp17wz/EEbpiVeMjnM=; b=KvnhfIoPHbMKTu8sLnW5xLPocBX0UuCQY0RdvgrJ8v1qiynpMCfOkak3WOn50N8YcF 2FwctGavbJZzKYIgo4R+/FGkUW/+zETw1MBIhlJYlD0vkveaxw8acdk0UcoBy3UevlyC zKT3BV7UwlwmQEyxHUvznBQMQyTgvYJ82Vxvsiq4D0DwXzc6N0Tn345Y3WzTfBwysmaq k6od3HYZyS1mHzuD3c77agCifIQ1PSyKG7s1QJ7pPNcDeizi6K0+F19XrFX9QK00JtT8 gsqPp3SVnK+5aLsq3y6/EMX2sfhZZcQwmNKp2lsiAsPCaJ38BEn3TGqb7YM2bFFCvMqC LxqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LFtpn69g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a15-20020a17090ad80f00b00267f99d5b8csi7055350pjv.20.2023.07.25.05.29.09; Tue, 25 Jul 2023 05:29:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LFtpn69g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234958AbjGYLkl (ORCPT + 99 others); Tue, 25 Jul 2023 07:40:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234965AbjGYLkd (ORCPT ); Tue, 25 Jul 2023 07:40:33 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E5CD19AA for ; Tue, 25 Jul 2023 04:39:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690285185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1je98xYKk91uty9V//ddQUBh34yh1GHtboW9x39SKW8=; b=LFtpn69gusgSkmXEuDAgfVijDOCS+mPonv56MyyYLF9uH9YtJBOtlDZf2K0rCPyy+lkPeJ IwbZh0UEzjsaX36MzqlNzZjPm9tz23TCb7Owq0TQ0ZdCFxrIX7ZJpo2jQYr42o6mElo06s ihHgJ7XrXv6UlXc1yU3j/dTlljJNY50= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-344-48PiCGnxPxSkVP5K3zccCg-1; Tue, 25 Jul 2023 07:39:41 -0400 X-MC-Unique: 48PiCGnxPxSkVP5K3zccCg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 79EC58065D2; Tue, 25 Jul 2023 11:39:41 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq2.redhat.com (dell-r430-03.lab.eng.brq2.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 905C24094DC0; Tue, 25 Jul 2023 11:39:40 +0000 (UTC) From: Igor Mammedov To: linux-kernel@vger.kernel.org Cc: terraluna977@gmail.com, bhelgaas@google.com, linux-pci@vger.kernel.org, imammedo@redhat.com, mst@redhat.com Subject: [RFC 0/3] acpipcihp: fix kernel crash on 2nd resume Date: Tue, 25 Jul 2023 13:39:35 +0200 Message-Id: <20230725113938.2277420-1-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changelog: * split out debug patch into a separate one with extra printk added * fixed inverte bus->self check (probably a reason why it didn't work before) 1/3 debug patch 2/3 offending patch 3/3 potential fix I added more files to trace, add following to kernel CLI dyndbg="file drivers/pci/access.c +p; file drivers/pci/hotplug/acpiphp_glue.c +p; file drivers/pci/bus.c +p; file drivers/pci/pci.c +p; file drivers/pci/setup-bus.c +p; file drivers/acpi/bus.c +p" ignore_loglevel should be applied on top of e8afd0d9fccc PCI: pciehp: Cancel bringup sequence if card is not present apply a patch one by one and run testcase + capture dmesg after each patch one shpould endup with 3 dmesg to ananlyse 1st - old behaviour - no crash 2nd - crash 3rd - no crash hopefully Igor Mammedov (3): acpiphp: extra debug hack PCI: acpiphp: Reassign resources on bridge if necessary acpipcihp: use __pci_bus_assign_resources() if bus doesn't have bridge drivers/pci/hotplug/acpiphp_glue.c | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) -- 2.39.3