Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp4404135rwo; Tue, 25 Jul 2023 05:47:29 -0700 (PDT) X-Google-Smtp-Source: APBJJlFvlkKPivQjBRdA2ffP+1b8xKqcEi52rqg+04jwEiJuES2DDm7fjh6mTNUg5/ZMdItXf18E X-Received: by 2002:a17:90a:bf13:b0:268:b0b:a084 with SMTP id c19-20020a17090abf1300b002680b0ba084mr6550436pjs.46.1690289249055; Tue, 25 Jul 2023 05:47:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690289249; cv=none; d=google.com; s=arc-20160816; b=zKXjNRS15xEZJX2kXQpAe7jlXdZQvw0NRbTjJUA7a6BBHj7JFrbmDt2kLa614zWo1V vBBX6VEZy1hRohz/ffY2l3biARBl0etGsAEd0y2nazl2sgk0//zFGPv82I/uQG8vPSw1 3kLJHquOe8GJvSurms7YfvIsOl9n8g0n1SjCgBgMzmISD0YXQGHEhAidmdJ4IGGUzU88 MBAMiZTfiV+BR6mmniTIvgZ3lnA45Qo2EmS0cQgwms0srmqxVo42ORqNK9sQFQyOcarE y2BoksA4Mzr+VMIMNN+CyCpAwUtu8Em0J3r+gtqt1Jk9915zvszYDf8bs5nwm73yRWD7 ITjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=ks3nUOn/9qR1jrhxbqY2QCJrSfWExHFhLwuG1z7B3TE=; fh=CkSoUz+u4TRknJhT9AZu8UqMJyakGa6eWUpEMyKOU0U=; b=0wzY4lXfZn/IrOWSq/PvrT/zGZPqGWmMpq1Rn9WUIsavYpQfUqywG126jUn+EVKzLH h5EjlZvzJQg+ULbiu8/jiIPOKYjhOw1RrwnPgzwOVKwoNTSl87yJsYXeoUZquAyEL3oR dWWURUem55b/9fQCdVJ/qeWw2gZmIjAEPIq7voGr/tc1lQbjo8nvTyHCDPOgMnbJ8Egq XbzX1/wKSp2oTMOd6Glp8XSuEiqwlKn9TlHkqBsZFvBU7vAVOiNffaFsutKEjYF1iZCE Hvx/VPV+KqodQtVvbDFqT6CB3syg3iwxTSUXohtm6kWPVzrb4MHV+NwUWFSeiRw7zs+G sQTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="oG/p44ha"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n2-20020a170902e54200b001b8847d973fsi12496317plf.219.2023.07.25.05.46.59; Tue, 25 Jul 2023 05:47:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="oG/p44ha"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230409AbjGYMYl (ORCPT + 99 others); Tue, 25 Jul 2023 08:24:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232649AbjGYMYj (ORCPT ); Tue, 25 Jul 2023 08:24:39 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A09610FA for ; Tue, 25 Jul 2023 05:24:37 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4fb960b7c9dso8540947e87.0 for ; Tue, 25 Jul 2023 05:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690287876; x=1690892676; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ks3nUOn/9qR1jrhxbqY2QCJrSfWExHFhLwuG1z7B3TE=; b=oG/p44haSlMMr+HRlqE79VaQqZhwEwmSo8ZjOOxune3yqh629GMwSMWSfjhBRB6e1N Ty+ROSaV6OoS+5cfAdwcbR95051XyeG62lmnXUG5w3qZ+zOQtg5qQjfL+4WJDxj78FFu OFMo5tqWAXhiRMT6YtLLFlxatsASqPfnU0ENTThzCY6Wm9Ojz4JrWgVquG0QToNSLubx 121/JSosd5nylMRCQ8nabStMWVBxe4A8MnsaqCqMH5g+9cQJ3S9SQ71cnWg/XON5GSny MIphdr8uB18GYn4a7e85ZU/DHzuPYZ/d+rNC/Xlmh/E7Z11Vls1o6jQny4kJnAcuS+/Q jXqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690287876; x=1690892676; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ks3nUOn/9qR1jrhxbqY2QCJrSfWExHFhLwuG1z7B3TE=; b=cXvSZnh7h8RpZWRfegiyN2YYYwhp8MyBMCUlRDzKZmqTZdLqBsVfbuJ2HpY7IqXwlc HGROv/ldUtU4g47ke7OY4iG+OsopbuI1J51U6HdWIUKfqOmBkAxEtiPeDA6jQmVvnRUX 07RWcLow735m4jgSMRjkam9DhP4iUBzBEsGoFw8h1ll9f2SjjyZbBrvkkRI/neuAdh7w Zr0bxfbmUGW/pd+Difza5Q8Wk46EttxWMVmUMfR3UpSC7o4P6R/IM0+QS8b7rjuBLotr ECcCjzInPMKk+paneJ3piwCYUR68scPC4Hu01R+ZHcApo+fujMUWdzHT9ZY5U5jqE2W3 fpjg== X-Gm-Message-State: ABy/qLb0oOxYjFD7t+me78I5nK5Mg5jw2x1Wcl3skLGD054O4zdSiU3n i99ADVLWTbaOk4UKtNsuYeiv0g== X-Received: by 2002:ac2:5e2c:0:b0:4fb:92a9:cbe8 with SMTP id o12-20020ac25e2c000000b004fb92a9cbe8mr6559105lfg.18.1690287875901; Tue, 25 Jul 2023 05:24:35 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id j11-20020aa7c0cb000000b00522274c3775sm3771264edp.68.2023.07.25.05.24.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jul 2023 05:24:35 -0700 (PDT) Message-ID: Date: Tue, 25 Jul 2023 14:24:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V2 1/4] ASoC: codecs: Add code for bin parsing compatible with aw88261 Content-Language: en-US To: wangweidong.a@awinic.com, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, perex@perex.cz, tiwai@suse.com, rf@opensource.cirrus.com, shumingf@realtek.com, povik+lin@cutebit.org, 13916275206@139.com, herve.codina@bootlin.com, ryans.lee@analog.com, ckeepax@opensource.cirrus.com, ajye_huang@compal.corp-partner.google.com, sebastian.reichel@collabora.com, yijiangtao@awinic.com, trix@redhat.com, colin.i.king@gmail.com, liweilei@awinic.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: zhangjianming@awinic.com References: <20230725115649.67560-1-wangweidong.a@awinic.com> <20230725115649.67560-2-wangweidong.a@awinic.com> From: Krzysztof Kozlowski In-Reply-To: <20230725115649.67560-2-wangweidong.a@awinic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/07/2023 13:56, wangweidong.a@awinic.com wrote: > From: Weidong Wang > > Add the awinic,aw88261 property to the awinic,aw88395.yaml file > Add aw88395_lib.c file compatible with aw88261 bin file parsing code > > Signed-off-by: Weidong Wang > --- > .../bindings/sound/awinic,aw88395.yaml | 4 +- > sound/soc/codecs/aw88395/aw88395_lib.c | 194 ++++++++++++++++-- > sound/soc/codecs/aw88395/aw88395_reg.h | 1 + > 3 files changed, 181 insertions(+), 18 deletions(-) Bindings are always separate patches. Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof