Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\))
Subject: Re: [PATCH][next] bcache: remove redundant assignment to variable
 cur_idx
From:   Coly Li <colyli@suse.de>
In-Reply-To: <20230725114637.37073-1-colin.i.king@gmail.com>
Date:   Tue, 25 Jul 2023 20:49:19 +0800
Cc:     Kent Overstreet <kent.overstreet@gmail.com>,
        Bcache Linux <linux-bcache@vger.kernel.org>,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <DFEED6F9-45FE-48BA-BE50-51B780846DE3@suse.de>
References: <20230725114637.37073-1-colin.i.king@gmail.com>
To:     Colin Ian King <colin.i.king@gmail.com>
Precedence: bulk


> 2023=E5=B9=B47=E6=9C=8825=E6=97=A5 19:46=EF=BC=8CColin Ian King =
<colin.i.king@gmail.com> =E5=86=99=E9=81=93=EF=BC=9A
>=20
> Variable cur_idx is being initialized with a value that is never read,
> it is being re-assigned later in a while-loop. Remove the redundant
> assignment. Cleans up clang scan build warning:
>=20
> drivers/md/bcache/writeback.c:916:2: warning: Value stored to =
'cur_idx'
> is never read [deadcode.DeadStores]
>=20
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Looks good to me. Thanks.

Reviewed-by: Coly Li <colyli@suse.de>


Coly Li

> ---
> drivers/md/bcache/writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/md/bcache/writeback.c =
b/drivers/md/bcache/writeback.c
> index 24c049067f61..c3e872e0a6f2 100644
> --- a/drivers/md/bcache/writeback.c
> +++ b/drivers/md/bcache/writeback.c
> @@ -913,7 +913,7 @@ static int bch_dirty_init_thread(void *arg)
> int cur_idx, prev_idx, skip_nr;
>=20
> k =3D p =3D NULL;
> - cur_idx =3D prev_idx =3D 0;
> + prev_idx =3D 0;
>=20
> bch_btree_iter_init(&c->root->keys, &iter, NULL);
> k =3D bch_btree_iter_next_filter(&iter, &c->root->keys, bch_ptr_bad);
> --=20
> 2.39.2
>=20