Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <tencent_B02B6BED124665ED9563140A71C1004D0805@qq.com>
From:   Rong Tao <rtoax@foxmail.com>
To:     mcgrof@kernel.org
Cc:     ast@kernel.org, frederic@kernel.org, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, mbenes@suse.cz, mhiramat@kernel.org,
        pmladek@suse.com, prasad@linux.vnet.ibm.com, qperret@google.com,
        rongtao@cestc.cn, rtoax@foxmail.com, tglx@linutronix.de,
        will@kernel.org
Subject: Re: [PATCH] samples/hw_breakpoint: Fix kernel BUG 'invalid opcode: 0000'
Date:   Tue, 25 Jul 2023 21:38:48 +0800
In-Reply-To: <ZL7OJQBXBz1a3Sk3@bombadil.infradead.org>
References: <ZL7OJQBXBz1a3Sk3@bombadil.infradead.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Luis

The 'kernel test robot' report an error [0]:

	>> samples/hw_breakpoint/data_breakpoint.c:73:2: error: call to undeclared function '__symbol_put'; 
	ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
	           __symbol_put(ksym_name);
	           ^
	   samples/hw_breakpoint/data_breakpoint.c:73:2: note: did you mean '__symbol_get'?
	   include/linux/module.h:301:7: note: '__symbol_get' declared here
	   void *__symbol_get(const char *symbol);
	         ^
	   1 error generated.

Do I need to do something? It seems that no changes need to be made from the
mainline code.

[0] https://lore.kernel.org/oe-kbuild-all/202307250926.06DQZjVe-lkp@intel.com/

Rong