Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp4530151rwo; Tue, 25 Jul 2023 07:25:02 -0700 (PDT) X-Google-Smtp-Source: APBJJlEfcE6lci/vrWvlTTGr0xfnFhc/mbPGld5WGybYdBYOCzF0jgb4xNs40gQ7Pw+fIgZS1bPD X-Received: by 2002:a05:6a20:428b:b0:12b:2170:7b13 with SMTP id o11-20020a056a20428b00b0012b21707b13mr14996967pzj.16.1690295102684; Tue, 25 Jul 2023 07:25:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690295102; cv=none; d=google.com; s=arc-20160816; b=h8erNNuiQVgMTTPB+fRgnKXTg5AGfSrxby776svKi9B2fwnyubkaVIur1JmDn+eSWJ Ut2cXYLU495pAK2lWcsIykJP+BryQH7HfZc7k1KyIsV/MiOHlnDq16xNws1CAUh0FvgV bOfmzRECkEaGe/QMF2q7UIkA2XKCDL9S9DMp24C21JYmJkxcUu8Vl591bk+aW+nndqh0 kdbo8MmjNZgtrf8RpDyp+9OCKlcHNxAbt2h3omSAYieZ6qKnNCFGZc6U8iYLFkxgbVYQ GNkPK5neaAsTJhXJy4++fNF+Zx1IucIHCvW+L8gwUuTmrBLkzucQRzpELIFMyFTs8OaG 0bUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=tJLcEXkshOwGHlNQ9hcypQauA+THdSvywxEC9H8mR40=; fh=4ZLxk9WgAV0qAml8rnjq/bF/33nczUcN7lbsDuTErnk=; b=pYa974OLi/5lFrinDQei6ihfxTPaTjtPVIVAWB4/uT7cci8VZh6hAKv6NO2Eyqr+Ay 7+oIUmOZmsbM8+GvPBwWVX+a8y0PwRHYzpTLpXngGXey247/0opZd6ftbJRom/vpy1Z2 ScXVCg8vRccUGaKaTC17fHGsLaJ8I0zllmT/sGKgcE47t/IyOiKJS1UDPaXphEscMkfS FnQOeMwF8VZZA8pSyNgQfrowjZqJjWDrjwolh10OofQFNq9iu2hDHHxLLX3T2ROLQUjJ uf1E6g6oQaV+DsYJnQNV3n3TevtKZll1gl2B+lYj7wNLXGmscFydtB+pYCSdkQurEb5s sjrg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j192-20020a638bc9000000b0055336060fa0si338983pge.378.2023.07.25.07.24.49; Tue, 25 Jul 2023 07:25:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229483AbjGYNPL (ORCPT + 99 others); Tue, 25 Jul 2023 09:15:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjGYNPK (ORCPT ); Tue, 25 Jul 2023 09:15:10 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 150B3E77; Tue, 25 Jul 2023 06:15:10 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10781"; a="367744051" X-IronPort-AV: E=Sophos;i="6.01,230,1684825200"; d="scan'208";a="367744051" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 06:15:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10781"; a="899929292" X-IronPort-AV: E=Sophos;i="6.01,230,1684825200"; d="scan'208";a="899929292" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 25 Jul 2023 06:15:07 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qOHsY-00AzY9-0x; Tue, 25 Jul 2023 16:15:06 +0300 Date: Tue, 25 Jul 2023 16:15:06 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org, Alexandru Ardelean Subject: Re: [PATCH v2] gpio: max77620: remove unneeded platform_set_drvdata() call Message-ID: References: <20230725123623.6411-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725123623.6411-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 25, 2023 at 03:36:23PM +0300, Andrei Coardos wrote: > This function call is not required because no counterpart > platform_get_drvdata() call is present to leverage the private data of > the driver. > Since the private data is confined to this driver file, external access > is not feasible. > The use of this function appears redundant in the current context of the > driver's implementation. Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko