Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH -next] hv: hyperv.h: Remove unused extern declaration
 vmbus_ontimer()
To:     "Michael Kelley (LINUX)" <mikelley@microsoft.com>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        "wei.liu@kernel.org" <wei.liu@kernel.org>,
        Dexuan Cui <decui@microsoft.com>
CC:     "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20230725135834.1732-1-yuehaibing@huawei.com>
 <SN6PR2101MB1693201F3C3FD2BCDD0843B3D703A@SN6PR2101MB1693.namprd21.prod.outlook.com>
From:   YueHaibing <yuehaibing@huawei.com>
Message-ID: <03317f44-3c5f-e221-6fb7-41b5fcfa700d@huawei.com>
Date:   Tue, 25 Jul 2023 22:17:23 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <SN6PR2101MB1693201F3C3FD2BCDD0843B3D703A@SN6PR2101MB1693.namprd21.prod.outlook.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/7/25 22:12, Michael Kelley (LINUX) wrote:
> From: YueHaibing <yuehaibing@huawei.com> Sent: Tuesday, July 25, 2023 6:59 AM
>>
> 
> I'd suggest using "Drivers: hv: vmbus:" as the prefix in the commit message Subject.
> I see that "hv: hyperv.h:" has been used a few times in the past, but my suggestion
> is much more commonly used and would give better overall consistency.

Ok, will send v2.
> 
>> Since commit 30fbee49b071 ("Staging: hv: vmbus: Get rid of the unused function
>> vmbus_ontimer()")
>> this is not used anymore, so can remove it.
> 
> Indeed, yes!
> 
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
> 
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>>  include/linux/hyperv.h | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
>> index bfbc37ce223b..3ac3974b3c78 100644
>> --- a/include/linux/hyperv.h
>> +++ b/include/linux/hyperv.h
>> @@ -1239,9 +1239,6 @@ extern int vmbus_recvpacket_raw(struct vmbus_channel
>> *channel,
>>  				     u32 *buffer_actual_len,
>>  				     u64 *requestid);
>>
>> -
>> -extern void vmbus_ontimer(unsigned long data);
>> -
>>  /* Base driver object */
>>  struct hv_driver {
>>  	const char *name;
>> --
>> 2.34.1
> 
> .
>