Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <707c74ce-1afe-1b8c-43dc-d9c351a4a697@amd.com>
Date:   Tue, 25 Jul 2023 10:22:49 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v1 0/9] i2c: designware: code consolidation & cleanups
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Mika Westerberg <mika.westerberg@linux.intel.com>,
        Jan Dabros <jsd@semihalf.com>,
        Andi Shyti <andi.shyti@kernel.org>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linux I2C <linux-i2c@vger.kernel.org>,
        Wolfram Sang <wsa@kernel.org>
References: <20230725143023.86325-1-andriy.shevchenko@linux.intel.com>
Content-Language: en-US
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <20230725143023.86325-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1F3TFhQN2xoZGJ6Zno5ZnF4TVRQYW1QdnVKMEVGZERhWkozTDZXczQ5RjBS?=
 =?utf-8?B?WCtreFdjcEhkMytVV0RnTVlYemM3bWVzUWdtQzhyU2p5bk1tR2xpUDBoeWFE?=
 =?utf-8?B?dXFDVDdCeG1QRmVqNENYWVNWcUN6SmFnQUhjWEVDbGEvS0x4R0lxaTlrM1lB?=
 =?utf-8?B?NTZ1L2Jicmo0bkRVTGFobFNvY0wyUENzMWdwSytVNHB5RWRQSDlaYlZXT3V4?=
 =?utf-8?B?WldPcWlZc3BBc3FONlpCOGJMeUdSZ3dVM3FIMzdLSDlkQU1obmJMN2ZOMGJq?=
 =?utf-8?B?Mnp0b2ErSTB3RkNRN0psdDlwaUZKUTBCb3lXSm5uOTRFRXZrUWxIZ0pnSi9N?=
 =?utf-8?B?WjFCT0RqN2VmUjZ1Zkcrd0YvY29qaHpMVXp1WHlZSDJZYU5xUFVuM2h1anYv?=
 =?utf-8?B?WkdpcGtFdUZyRUhscGpBY3pOSGExUy8vMzVNeERMYXRsemJFeU13VmhZelFu?=
 =?utf-8?B?UkMxYkJEM0VkZXhIVEkvZjNlMlRZY3V6UkJwNXluMTYzZWIxTlk3N3l1cVVw?=
 =?utf-8?B?Tk1VTlBYY2xaT0ROOHZDMk1WRkpjSGNQbGhMMXNIYlc4aFQySG4xOU81bFpB?=
 =?utf-8?B?bmI3N2ZlUStsYWUxeGlDOEU2OStkV1RvcDdCcFh6VzVid0lBQjZFUWtGYWE2?=
 =?utf-8?B?dXpxcDRZa0QrOGh0QVhmMHRyWERJUTFaekpMd1hEVkNBSWt1RzF0NmdOYUJP?=
 =?utf-8?B?dlRTektFYVdQaVNlbjliT0FBa3BiTDJqcis3ZFI0czdtc3kvVlN5N3JGeHRj?=
 =?utf-8?B?bTRzVS9zT0wzTXUzRU1HejVpVm5pUTk2OXl4WXVabFFWM1RQVXNZNnNqUHZR?=
 =?utf-8?B?YXhNRHNzU01ISi9kRmw0ZVEvVDdQeHZrclRQQjVuMDNWelRVZ0poOHdoQUwy?=
 =?utf-8?B?dGtlVkp3THBXYUkzNUZGejVWdVdPUFBscS8xb2lLaVJNT3QrOHovd2FTckJ5?=
 =?utf-8?B?MElKdzBzTlVaa1RINWt5eSs0MkkvSTg5VVNQblhPUldkNGxqdUc4RjNRVm53?=
 =?utf-8?B?bXlMTndyVlZJSkpwK2JFQjlocVIwVFUwK2N2RFo4QUlSUno2WFN1NlN1TVp6?=
 =?utf-8?B?WkdnK3g0bVBxUEljaURySmVvcUdDZTZuelE4eUZ3d2RtQ005UHFIOVVEZlZm?=
 =?utf-8?B?QzN3a2NSRDZKb0s1cTVjc2oyTnV6clZIWlFyWUllNWF4dktFcDZzd1FRdUEx?=
 =?utf-8?B?dnhLcVBVMWk5ZWRraFlMMWMvWmp6R0crUkppZGVXQitDMk5zQWM3SVJDYnVH?=
 =?utf-8?B?SmJIcUE4Z2VFZ3kwbEc3Y0Q3aWFOWUdPTHNqSDZZZTRkcm1wc241OUNNdkUv?=
 =?utf-8?B?N2ZGOHRvcTVETFIrWExaZVNkajE5YXUvc2xCdHQ5Q0NLRUcrcksramNraGxK?=
 =?utf-8?B?UVE3c09qamRXVkhHOHdlcFMwTDRtNk5aUFpybG1kaUF2ZlgwZ2pyRmRvWFJo?=
 =?utf-8?B?bHFpckg0YkEzZWNuZGZUNjFRdTNPRFhMV0NBbTZSeUZiYlY4SUNJdEd2eVJv?=
 =?utf-8?B?R0c0d1BrWU1hTDQySTU3T1F3WGp6cGh2M3FvVUJTRFc0dm9FOHBMc0FSckRD?=
 =?utf-8?B?K0ZUdVFXNXZRNlV1d0tXdXNpdzdqaU1oakFNc09TcTNYaC9nU016SUhBejhj?=
 =?utf-8?B?RWF6aWxIV0tXMTFTM05JcEFTd2Z2VFNEcXlVRWtUelhiMFZPZTZiUVdMTEZU?=
 =?utf-8?B?S2I5a0NWWkNiVE1VTzdwZG1rWjZZL1g3MWFJNXY0by9qTVdzdjVDMHZwZXRa?=
 =?utf-8?B?RmwrYlB6NmxCV25aU2pjbTRQMVo5Q3RIaGw3bXRwcTU4ek5LeTBaVWtpNlhj?=
 =?utf-8?B?VTRmYlk4THNmUWRJSGFHV1F6aHVRaE40TnlMVGF1YktPV2dZSWJzVldzRFdN?=
 =?utf-8?B?cVI4L0NaM0FpOGNTOWZXdmN6MTgwNWUrNDhWWnNHdnFuaElEZzRSM2NLYzhu?=
 =?utf-8?B?RlRza3lLM0NkSTYwTjFzcUN6NDBpWFlvanY2MkJQcjE3b0k5THh0T2c5V3Ny?=
 =?utf-8?B?dzhQbmg5d3pyV1FNZmVZcFBxakpETjVkZVVNNE9rVjlGbTRWNmRIeGNXNGgz?=
 =?utf-8?B?V0w4b3ZjOEIvTGVzVlJ3RjltU2RtNlY0QjNXMHJTRGErK1BCOGJiZjExdkU0?=
 =?utf-8?Q?aiMeeS7mdZWAGZO4GrTQ8CXHq?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19698883-4346-4cae-5509-08db8d230325
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2023 15:22:52.1434
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Nc8keAkI+H80Ygp4EuFomsfDHaLJBukLGo6FY+MBd8GtehkRuoPTsWopC2y2aZH+7sHpn9JxbHtRHjd5AHUVMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4171
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/25/2023 09:30, Andy Shevchenko wrote:
> Mainly this is about firmware parsing and configuring code
> consolidation. Besides that some cleanups here and there.
> 
> Andy Shevchenko (9):
>    i2c: designware: Move has_acpi_companion() to common code
>    i2c: designware: Change i2c_dw_acpi_configure() prototype
>    i2c: designware: Align dw_i2c_of_configure() with
>      i2c_dw_acpi_configure()
>    i2c: designware: Propagate firmware node
>    i2c: designware: Always provide ID tables
>    i2c: designware: Consolidate firmware parsing and configure code
>    i2c: desingware: Unify firmware type checks
>    i2c: designware: Get rid of redundant 'else'
>    i2c: designware: Fix spelling and other issues in the comments
> 
>   drivers/i2c/busses/i2c-designware-amdpsp.c  |  10 +-
>   drivers/i2c/busses/i2c-designware-common.c  |  84 +++++++++++---
>   drivers/i2c/busses/i2c-designware-core.h    |  25 ++---
>   drivers/i2c/busses/i2c-designware-master.c  |  15 ++-
>   drivers/i2c/busses/i2c-designware-pcidrv.c  |  13 +--
>   drivers/i2c/busses/i2c-designware-platdrv.c | 117 ++++++--------------
>   drivers/i2c/busses/i2c-designware-slave.c   |   6 +-
>   7 files changed, 131 insertions(+), 139 deletions(-)
> 

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>