Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <856ad175-26f8-90ea-d801-c722d2b19b2e@intel.com>
Date:   Tue, 25 Jul 2023 08:26:18 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v5 12/19] selftests/resctrl: Remove
 "malloc_and_init_memory" param from run_fill_buf()
Content-Language: en-US
To:     Shuah Khan <skhan@linuxfoundation.org>,
        =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, "Shuah Khan" <shuah@kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        "Fenghua Yu" <fenghua.yu@intel.com>,
        Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
        <linux-kernel@vger.kernel.org>
References: <20230717131507.32420-1-ilpo.jarvinen@linux.intel.com>
 <20230717131507.32420-13-ilpo.jarvinen@linux.intel.com>
 <7bba4db8-eaac-238d-b764-89d0ae2a9bba@linuxfoundation.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <7bba4db8-eaac-238d-b764-89d0ae2a9bba@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWhKL3RYTnF5dFNjeHNSaG9RdUE5ZFQzUm5rSXVjcHUwZHFPR2kvZjR6MXpQ?=
 =?utf-8?B?Nnh3NStJdER6UVMzNSsyem1vMnEzcmkvL0VJTTM2S2NqYTloUVp4MzRiWkEy?=
 =?utf-8?B?VkYyMHZUeStvc3FIMVl0MEpqY1hhdGx0bEdCYXV1ekRISUIwb1dIVnVRd0Rl?=
 =?utf-8?B?R21Kdlh2THV0VEszbUtwVUJseTAzaG1RUlVFTlFjRXl1Tm9WK3pVcTFpZTVN?=
 =?utf-8?B?Vm8ycGRIUW4yL3o3cXF3TjkvMFAybkdyN2ZVK1FtOXBOZlV3OGNRbE90MFFV?=
 =?utf-8?B?emU5emNaQ3MzMkNINWxjRlRyWUR3aThUNWkzeHZWcWo4WkpIdzZqQ3V3VndI?=
 =?utf-8?B?QzZ6Qi9OZUFiVFpibEUvUnhjV1B5UEljZU5GckRQbWRkMm1UNkR6SlllQ1lD?=
 =?utf-8?B?ZE1saE95Z1BrNmFHQk5OdDc3RDBsdTNXU0VNdlVYSjRneWVReUdhS0hzWEpL?=
 =?utf-8?B?NmJ1NDMwaVJveEZkU3VJTnZRWjFOMjlaTmtMS0ljQS9LTEtON2lZWnZWdnZX?=
 =?utf-8?B?V0d6TW5oOERzQWZNSTVsOFUvalFmOU9CUUxrZ0lQWWt6R0VnWU01N1MzR0RI?=
 =?utf-8?B?N2JEM2lQSFZFc3pPQzVRcXpxYUhqTjNBU0ZDa1p1aWY1QVk3TWpldDR4Y1N5?=
 =?utf-8?B?cXQrbUhyWnp6cUJxVk4yTkRzWUpkcFFMclNnUUhMaTNmM29ZYXlNOTJjelY1?=
 =?utf-8?B?dDgvN2dCQTk2d2ROeWk2M2U3YXRTMUZxbzh1em4zYXEySXNJbFp6V3c1bGw3?=
 =?utf-8?B?aHZzZmVhd1NqVi95TlFzVjNqNEhFajllVWJraVR5UDBoYXFmaSt5WS91RUJS?=
 =?utf-8?B?cnVNeHdmcE9DQXBFK0YxWEZ4b3cxVk1YeUVMNmVWS285aEhQRE52aG1Cb3dl?=
 =?utf-8?B?YWJGMjZvR1VZb1BRdHRYbXRIQVQ3Z1NRaU5GWWMvc0ZnRDUxMEFxclVHUllw?=
 =?utf-8?B?WTlJQnBMTXVNWmN3aDRhdnRQMjhhZ1lEbTR5WTNvS1haVUI2dmtVL3A3L2lU?=
 =?utf-8?B?REp2TUZXdVFPK0JsN2lxUjVsWVVuMDZSUEJPVEtFbElzVVl2N3JEVDNFeWI5?=
 =?utf-8?B?aHdpVEkwNzRRQWdGRUpBU0lQZXQySVRSd0szMlNGOGs2THAwODBETXFzdUVT?=
 =?utf-8?B?ajZwNmpVMU9HUmtKQUE5SStCNDd5NjVaVHdPdS9RbzNoQXBKSGJCdld3YUlU?=
 =?utf-8?B?RmxSaS92ZjIvd0kyRXo0KzZ0ZXZtQWxlcFl2eGxlYStVRGw4M2xmTGdLY1Ba?=
 =?utf-8?B?NW5EODZPWWkvdndZSis0Z2UwOXd4QXliK21VUld2S25QNmc3TGZ5WnBUaEJu?=
 =?utf-8?B?ZVY3R0FtOVFFSHpWUGRHVC9qNHFjbm44Zk5aV0N5V29palA0RHFxR3lXaitM?=
 =?utf-8?B?SzBSZGZLRGhoYmRlNFdzbnBUaDJVbUkvQWJ4S0pVQnFMK2xFdFFrelk5Wlhz?=
 =?utf-8?B?dHVXUjZTOFUyUjlTVlZIZ1RFcjBVVUVMeVNPY2xKcExpQTJ2aTRzeThZQjF6?=
 =?utf-8?B?cTVTREx5YWo4NkhGYU9PUUlvOU1uaGRQbWZzbHd3VStjNWQ4RjNBTE9sYlp5?=
 =?utf-8?B?ZlNFbnJmZ3VibGpVZWF3eEZtK2tlSDlHUWNKWkhacGZzNjZzWXpZbGNUZXR3?=
 =?utf-8?B?a3FMQXdmRU4xVVZaVEVuZlM3aGEyRmpJYkdZRzNPdkxLM1FSODBQdHhRSEJQ?=
 =?utf-8?B?NXgrVEYvbVQ5TDM5NzBoekZLVmwxRTVweVpNV1FDc1lEQUJHcStVVU11V25a?=
 =?utf-8?B?L0lEcEM4YitseUVtejFicmQ3aTY4SDRXU1dxN3c5aVZiWTdvVnhoUXMxRnFt?=
 =?utf-8?B?ZWIwYkQzUk1HbUZ2YWtFc0g0eTM2V283aFk0RmgzcjhleUpMZE5OZmNCY3Y3?=
 =?utf-8?B?V0x5WmxBWWJsY1ZMNWFnSElmL1dMZnVyZ3NtaHI1eTR2WU94eWl6TTFnQ2FN?=
 =?utf-8?B?SjBxem9LQ3I2NFh2eHJtN0hPUE42ZjRFV3VCZE9xK0twYk1lVnBDaUFpN1RO?=
 =?utf-8?B?amE3UlVyUW9vVHYycWJ0WVc0SUo5Zld2eFZOT2Rjd2gwVkovQzI0ZzhNb3pr?=
 =?utf-8?B?VlV1TWFNbG9ZZlNUbjZlL0Q5WHU0SGpsVE0xbXN6bk9UMEhrSlpqbXJucE9B?=
 =?utf-8?B?d3FsK1V5blEwbk1ZSDErNjYzaVZQQ3QzY3FMOFR5K1NRMDBURXB3a2F2ZGs4?=
 =?utf-8?B?dFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 64ba2591-315e-465b-9385-08db8d237f18
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2023 15:26:19.9936
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y5SCRhlUUml1Pl1KWHrnr5w4D4XpBpB1qRzIsdciNnepEA69scCf2f/temLcV4jFX8yJTI9APM+B/J1voaf6/k3tz1jpv8fVPw0SmoYvZnc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7769
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shuah,

On 7/25/2023 7:49 AM, Shuah Khan wrote:
> WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
> #233: FILE: tools/testing/selftests/resctrl/resctrl_tests.c:276:
> +        strcpy(benchmark_cmd[3], "0");
> 
> WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
> #234: FILE: tools/testing/selftests/resctrl/resctrl_tests.c:277:
> +        strcpy(benchmark_cmd[4], "");
> 
> total: 0 errors, 2 warnings, 142 lines checked
> 
> I am applying the patch set to linux-kselftest next - please fix
> the aboe and send a patch on top of linux-kselftest next

Is strscpy() available to userspace? I found lib/strscpy_kunit.c
that makes me think this is currently only available to kernel code.

Reinette