Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Tue, 25 Jul 2023 08:19:48 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Andre Werner <werneazc@gmail.com>
Cc:     jdelvare@suse.com, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, robh+dt@kernel.org,
        linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Andre Werner <andre.werner@systec-electronic.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: Add description for new hwmon
 driver hs3001
Message-ID: <0340a749-7073-4002-ada4-c1866f90054d@roeck-us.net>
References: <20230718112810.21322-1-andre.werner@systec-electronic.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230718112810.21322-1-andre.werner@systec-electronic.com>
Precedence: bulk

On Tue, Jul 18, 2023 at 01:28:09PM +0200, Andre Werner wrote:
> This is the initial description.
> 
> Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

checkpatch:

WARNING: From:/Signed-off-by: email address mismatch: 'From: Andre Werner <werneazc@gmail.com>' != 'Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>'

Sorry, you'll have to resend this. The e-mail addresses need to match.

Note that, when doing so, I would suggest to add a sensible description.
"This is the initial description." is not a useful description.
"Add binding for Renesas HS3001 Temperature and Relative Humidity Sensor"
would be more sensible. Also, regarding the subject: bindings don't describe
the driver, they describe the chip.

Thanks,
Guenter

> ---
> v1: Using separate dt-binding hs300x.yaml
> v2: Reviewer recommends documentation of driver dt-binding in
> trivial-devices.yaml because the driver has no special properties
> to describe.
> v3: Simplify description of sensors compatible
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index ba2bfb547909..96eb59e56eb7 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -315,6 +315,8 @@ properties:
>            - plx,pex8648
>              # Pulsedlight LIDAR range-finding sensor
>            - pulsedlight,lidar-lite-v2
> +            # Renesas HS3001 Temperature and Relative Humidity Sensors
> +          - renesas,hs3001
>              # Renesas ISL29501 time-of-flight sensor
>            - renesas,isl29501
>              # Rohm DH2228FV