Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <586c5547-1606-45b1-53c8-c322d7954c8b@intel.com>
Date:   Tue, 25 Jul 2023 08:26:00 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
From:   Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [PATCH v5 04/19] selftests/resctrl: Close perf value read fd on
 errors
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
        Babu Moger <babu.moger@amd.com>,
        Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
        <linux-kernel@vger.kernel.org>
References: <20230717131507.32420-1-ilpo.jarvinen@linux.intel.com>
 <20230717131507.32420-5-ilpo.jarvinen@linux.intel.com>
Content-Language: en-US
In-Reply-To: <20230717131507.32420-5-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWpmSWdrcnFsTjhnd2xoTmo5cVJJRGN2L0Q1c29mdHQveFZFVk1xWWxNdzFk?=
 =?utf-8?B?bnZDMkdVT3JQNGRYM1k1bnpBUE1yTDdtQ3FOdWlrRXVFa2RhaS84WXFMdC9L?=
 =?utf-8?B?VlFyMkRqMktVYnN2QW00OGg1OGpkR2hTN0RiUDkzQ21GMW4xS1RreGtpNUVG?=
 =?utf-8?B?SkluUXU5WlJYcXVFaTd4c3llR2IwNHJQQ29kY1ZIdCt1ek5qTjYzVHc2RzVq?=
 =?utf-8?B?N0tKekpmL2xrc2Q4UW91VzlseGZNUTBSSDJQYVg5cGNibUl6cnRiVzd0eTZh?=
 =?utf-8?B?aE5EYlhTWVBEbU1iMnphaTJTOEh5VFpXYmNwUEJTcXBpbCtZMUwySTlkdGtv?=
 =?utf-8?B?MlhTUlhyaDNzMlpuQzJhMWZhUXJmdmhhUHp3bklwVENnYmNSTzM0YXpzWEJ1?=
 =?utf-8?B?UjQwRUdHVGtTUWJjN3lOc1RpeUxrWmoxRCt1Rmw3elIwVFRxNjlCWVhtVDVp?=
 =?utf-8?B?ZU1LTUdPNjYzU0Y0Q2RJMzdUTmVFRzc2UEhXTWx6N3FwWkZRKzBIVlR1QTM4?=
 =?utf-8?B?T3hSOWhjSUtsUm90ZjJib2JmT3FiWkhGRE5LcUtuZDE2WGViK054aU0xbTUy?=
 =?utf-8?B?OXlIV2E2R3YrK09EOW5zS1g0U2dUT3pJRkFBVHVsRjdhcG0wUGdjemVTQmpi?=
 =?utf-8?B?TzRaTGxpd2NPUGlldWJXOHpsOTh4UDZBQmtDb0ZXY3VDQktKMDNWemUrRFlW?=
 =?utf-8?B?dCtTR2tEQWNQRnlDSVZubmV6N09yaHpVOHFEdlVOMHZJaXNkWGN5NUJ1UC9q?=
 =?utf-8?B?OFNRSWVrbDcwVC9teVBSb2ZDc25hb3FvejR2c1l3dzBqSzVIeXV2dXFsR1B6?=
 =?utf-8?B?dmlrMHVFUEdWSlNvN3RyYzNTcDRNMVExSmtoUFEvOVNJbUN4b3NlaUxxOXF6?=
 =?utf-8?B?cTJpSEZBNXZ6VlBRSS8vMWlWcmplSEVmdFVVdWcvN2E2SlRzT0xCVkp2UmZ0?=
 =?utf-8?B?M1NEVjA2c2RVZkxqeGN3MTFCQWttVnRHYUhvcFU0elYzUnM5UHVEQlJ5TzVB?=
 =?utf-8?B?aEdRQmxtckNiSmFta1AzWVZhNjVFbWY4cTJwekVyZDVZZ25WTlVoMnM1Q3Mx?=
 =?utf-8?B?M0tIT3dva1BxTFRPcXVsSjQ4bkVyck1yZUJJT0JqZzBXSmJYbTU3ZUM3MmQw?=
 =?utf-8?B?VzlSTGN5TndJRmFHbmUxdjBGNnlWTDgwS1VrS3NCVWFtRG1jLzFsemFxa2J6?=
 =?utf-8?B?R3lkakxjcEFsWk1MR29PSW5CTzdXNHEzUG9YOHo5MFNxSUg4UG85d05DcDMy?=
 =?utf-8?B?RUg3bVNhdDNPY09mb2phcWZ2VG1TM2NzQmxFVFRodm9tdkdEOWZ4UE5RdUhi?=
 =?utf-8?B?c2J5ZjJWVS9tdnhKMXZ1enpIaStQRkNNL2ZHek9vZWVIcWNmZDlBNEhTd1RM?=
 =?utf-8?B?V1ZQbFhjeEhTNkw2NW1IMFpxT092aVdsc2cwWCsvbTF6MXI0WU1yVXBmZHQv?=
 =?utf-8?B?anhJb1djNDFwcFBRQmk2QkJBaTBVaUp6UGJpZDNlT2xLR2N6bGhYcDZPQXRO?=
 =?utf-8?B?VEFYOFdycFFLQkdDNTZ1dERDc0dDVFJZY21pZGhXcEpxeW84M0RvdVN0YUNL?=
 =?utf-8?B?aHJiR1VYMkxLT2NZbDlhTkpjVXdIakJKdjFFZm1TWnYzTCtwMGE5TGt4aDJT?=
 =?utf-8?B?a3RrODBUV1QzZHozR2ZRYTdONzBLSGNoQlN6WlVUemdIQVk5bGpuV3NTOXRu?=
 =?utf-8?B?VEpVc3FPZjYrOGs1dlZGYytheDF0bk9vZWFhUjJZV1BJcHZrd2x4aHoyYkdG?=
 =?utf-8?B?TERRelBFZExMZUxhZ2MrTGgxekxHVHFTNndJMHl2dWxGdnJ3NEFoNlhGWnZv?=
 =?utf-8?B?VEZrK2VVQisyK3hOZmdrRG04Q3pmTlhzNXZ5dW1zNGt6K29ISnJPbG5hb3pl?=
 =?utf-8?B?dXg1YURIaDYrMkdITmhXU05qRzFzVXI1SFl5d01OU2VZWHRQcTcyUTdyL1VD?=
 =?utf-8?B?anlxTndlMlFCeFhRdm5xS2FlbnMxN2o4a3hUVmJoRjduV2lwTlJ6WEQrQmgw?=
 =?utf-8?B?Z0xLY2VNN1lDZ05VR2txakVtc2s3eHMxVWZGMGVNUzFGVDI4Zm8zMkZXTzI3?=
 =?utf-8?B?dTVQbWthdlZ1ZWVvNjZQUVJybHp5OWUxdXpwNnM5SU5jY0ZWYW11cS9ESk9E?=
 =?utf-8?B?Zm8xNHIxbjNoZUhmT0xWd2xRUyt3emdPa012ZElkU2tMMERHZVMrRVQ3RmVB?=
 =?utf-8?B?a1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 647de627-77da-4432-dcff-08db8d2374bd
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2023 15:26:03.0280
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WmoG/0cZjLrppUSmkXhQCBa+SvhzVyCgGPDZpiwRxvFHm5wD0EoxaQfsKXLjkSWLBwPNR+N6lVkZy4Lf2oDwssDm89tRL3Q1E8vJ80ySUfk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7769
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 7/17/2023 6:14 AM, Ilpo Järvinen wrote:
> Perf event fd (fd_lm) is not closed when run_fill_buf() returns error.
> 
> Close fd_lm only in cat_val() to make it easier to track it is always
> closed.
> 
> Fixes: 790bf585b0ee ("selftests/resctrl: Add Cache Allocation Technology (CAT) selftest")
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  tools/testing/selftests/resctrl/cache.c | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)
> 
> diff --git a/tools/testing/selftests/resctrl/cache.c b/tools/testing/selftests/resctrl/cache.c
> index 8a4fe8693be6..289b619116fe 100644
> --- a/tools/testing/selftests/resctrl/cache.c
> +++ b/tools/testing/selftests/resctrl/cache.c
> @@ -87,21 +87,19 @@ static int reset_enable_llc_perf(pid_t pid, int cpu_no)
>  static int get_llc_perf(unsigned long *llc_perf_miss)
>  {
>  	__u64 total_misses;
> +	int ret;
>  
>  	/* Stop counters after one span to get miss rate */
>  
>  	ioctl(fd_lm, PERF_EVENT_IOC_DISABLE, 0);
>  
> -	if (read(fd_lm, &rf_cqm, sizeof(struct read_format)) == -1) {
> +	ret = read(fd_lm, &rf_cqm, sizeof(struct read_format));
> +	if (ret == -1) {
>  		perror("Could not get llc misses through perf");
> -
>  		return -1;
>  	}

Above changes seem to be remnant of previous version that are
not needed.

Reinette