Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3af0795f-2ba8-2033-8b4e-e6fa889767aa@redhat.com>
Date:   Tue, 25 Jul 2023 17:54:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] mm/mprotect: fix obsolete function name in
 change_pte_range()
Content-Language: en-US
To:     Miaohe Lin <linmiaohe@huawei.com>, akpm@linux-foundation.org
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20230723033114.3224409-1-linmiaohe@huawei.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20230723033114.3224409-1-linmiaohe@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23.07.23 05:31, Miaohe Lin wrote:
> Since commit 79a1971c5f14 ("mm: move the copy_one_pte() pte_present check
> into the caller"), the explanation of preserving soft-dirtiness is moved
> into copy_nonpresent_pte(). Update corresponding comment.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>   mm/mprotect.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/mprotect.c b/mm/mprotect.c
> index 5c3112d92466..3f36c88a238e 100644
> --- a/mm/mprotect.c
> +++ b/mm/mprotect.c
> @@ -213,7 +213,7 @@ static long change_pte_range(struct mmu_gather *tlb,
>   			} else if (is_writable_device_private_entry(entry)) {
>   				/*
>   				 * We do not preserve soft-dirtiness. See
> -				 * copy_one_pte() for explanation.
> +				 * copy_nonpresent_pte() for explanation.
>   				 */
>   				entry = make_readable_device_private_entry(
>   							swp_offset(entry));

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb