Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Jul 2023 18:11:56 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Eugen Hristev <eugen.hristev@collabora.com>
Cc:     linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        netdev@vger.kernel.org, david.wu@rock-chips.com, heiko@sntech.de,
        krzysztof.kozlowski+dt@linaro.org, kernel@collabora.com
Subject: Re: [PATCH] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay
 defaults in schema
Message-ID: <20230725161156.22uscijrot7gbnvj@mercury.elektranox.org>
References: <20230725155254.664361-1-eugen.hristev@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ofxuz3hwyjtmd4j4"
Content-Disposition: inline
In-Reply-To: <20230725155254.664361-1-eugen.hristev@collabora.com>
Precedence: bulk


--ofxuz3hwyjtmd4j4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Jul 25, 2023 at 06:52:54PM +0300, Eugen Hristev wrote:
> The defaults are specified in the description instead of being specified
> in the schema.
> Fix it by adding the default value in the `default` field.
>=20
> Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-sc=
hema")
> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
> ---

Maybe also fix the allowed range while at it? I.e.

minimum: 0x00
maximum: 0x7F

-- Sebastian

>  Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/=
Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> index bb943c96c196..6d08260ad828 100644
> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> @@ -92,12 +92,14 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/phandle
> =20
>    tx_delay:
> -    description: Delay value for TXD timing. Range value is 0~0x7F, 0x30=
 as default.
> +    description: Delay value for TXD timing. Range value is 0~0x7F.
>      $ref: /schemas/types.yaml#/definitions/uint32
> +    default: 0x30
> =20
>    rx_delay:
> -    description: Delay value for RXD timing. Range value is 0~0x7F, 0x10=
 as default.
> +    description: Delay value for RXD timing. Range value is 0~0x7F.
>      $ref: /schemas/types.yaml#/definitions/uint32
> +    default: 0x10
> =20
>    phy-supply:
>      description: PHY regulator
> --=20
> 2.34.1
>=20
>=20
> --=20
> To unsubscribe, send mail to kernel-unsubscribe@lists.collabora.co.uk.

--ofxuz3hwyjtmd4j4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmS/9D4ACgkQ2O7X88g7
+pqWAw//R7tq9H+hx6ddYWSomL1O1WHXSMG7plrm8NK9/POt61Z3yqFvP/yXBTDF
k1S9ivLyv7/A0rA5lu2CzCRxud21fiGTeRd2KpShauXWdvX0kJ9W/tpEInhOqhz4
7K4+ODw8kq+XcL54ZFeGp6fUeGbBrNRMhA2aORfec0QeFlPT1WKQdXnnRsm/PzXf
j7Hg1kk4MrINxtXUHqMqbTI9kduWnUSJIWkAX72lkQdzMjAcBBwhu/7S58VfKVhi
rsermYFcMTE3/R5VIxpMn+AW3691H3fc6GUEE1PTUkyRdK4BCDVVrm1zxuE9xF74
eKEowlL2LPRPVELnykN89ye3brTb0vovCVbcy5EXZj8viiKyclNM7EaX+jXsEJXl
8ohKS0TVDtRfnin+C7d2RM/qADwemGT8v6B0JFFIp+ofNyNv06e5tsHJ8l9GrEof
tVtL8ziPZp7kgTtKv9MiLbw4yzXxPvZfDrZI3y2VE4QGaRZ7JF6opNqtwsZaz19Z
0H4BPh0zCa4HWNrxWg525tOF8VvHS/k3kRvjH6EQwoCipVjdMm+BnmOhPs7PtcBR
Wuay9qKw7uepG9tRdZlMu4PORfpswZvng1nmtcU0rrprFzFL99T0NVqWzHdrP3q9
iTh6q2vKVetxxA4bME4nIDiyr2xTGKb+FDh49TgmQtDfOhJ8vsw=
=vZvT
-----END PGP SIGNATURE-----

--ofxuz3hwyjtmd4j4--