Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp4746020rwo; Tue, 25 Jul 2023 10:15:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlEvpTx/GlqeLVgW13igmIlOKXODFEKOozTO8isxy91lOEYJKdqvqkqclfltEzswjoAFT2o7 X-Received: by 2002:a05:6a20:8e1f:b0:12d:23ea:9ccc with SMTP id y31-20020a056a208e1f00b0012d23ea9cccmr15422717pzj.39.1690305349483; Tue, 25 Jul 2023 10:15:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690305349; cv=none; d=google.com; s=arc-20160816; b=OAe5Kx6OACrYLGiNbJC/s9qHSqgiNii7aNsJIEeAEhaYtUOHQovZUn9a++66rhO7Fc uteebPa+94FGmlibgRPX/ZU5isgadt82a29uUuBYHF2nzb8Vcyt0CEIAiDUxArb3OVJ1 MmKlVwII0jtoLLQ6Z+ZpHZoqMz1G79EwMk67k1iyo8voRcS5jJP1RmMR2mvmH3AL61Ji OnQOJxpLSIZIXPP6InMgE8GCHoCAMB32ngofItsKsrB+9N/7pA3uI8HjcV55nPFrDU6B gRXMmu0/MXdTlk2LS3wls674d7kEkrsLtOAld6kOmq4kUujsc4s3jpGcS/tPWyFRC2w7 M+yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=oXu7I2w2GulAbsjkAbhBaZ0d5Ez9Ymu2aocx4QCikLk=; fh=F27ve0invja90mawS5Yxhii5MaA4EsSjzRkeU2kPUZI=; b=rU3po++JsEeBBWw3rW7c/Bs/clCOSJBHpZ5hjFVWgvi1JzyNEa9jS3JCRibiooZvMQ 4iisSYziu3+qkYcEdqAe6bX/UYeEAIhzE5WhDfyWsJE+LpFZUyVzgWpptVgeyVJAoYjS PWuKDbX69ujqav1yUXQkqVvGPPXDSaVzj077+YkUme47SWg7nw13aXV3AqnoEgeLNd7E QnsrLT5lwsosPSrj/imqkPxt7626Okdfy29wPLKNJ/x1mF6HgZIWNW5eXQA34tqVzWau 9GC7VBRxG52thX2P0lIGf2odBkQZb01N0PFijRsfhuGCh49pMwa+j5DdLWZp+kuPBBqU Z44g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cyphar.com header.s=MBO0001 header.b=kSmWzfYu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cyphar.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t23-20020a656097000000b0053f163363c0si9429559pgu.95.2023.07.25.10.15.37; Tue, 25 Jul 2023 10:15:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cyphar.com header.s=MBO0001 header.b=kSmWzfYu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cyphar.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232428AbjGYQwH (ORCPT + 99 others); Tue, 25 Jul 2023 12:52:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232187AbjGYQwF (ORCPT ); Tue, 25 Jul 2023 12:52:05 -0400 Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [IPv6:2001:67c:2050:0:465::101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DDC92683; Tue, 25 Jul 2023 09:51:37 -0700 (PDT) Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4R9NMl0q8pz9sw0; Tue, 25 Jul 2023 18:51:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cyphar.com; s=MBO0001; t=1690303875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oXu7I2w2GulAbsjkAbhBaZ0d5Ez9Ymu2aocx4QCikLk=; b=kSmWzfYu0h5RiTQdQhuOq6it0MoOiZSf3kDgxT/+cq1LY2gaqgps8UYFoHqeIEJZu3gl3Y 6NfO6pwEzKCD/FvCRHx/mqdIegvQ/xl7XBtbCWyNeZKkLoJYNVo2fbFaa337PF09aPHP6s Pl0K38zR38aZQ86S1uv2GiAEqLJIYLuc9RjcsgJwCXiQ911NIuvw8DS1OGefalEOwy3G4n KQ6maBX4klVBvsIqPSP4EVbp/eKJmPJVCbjW7W/CHYeRncxiKGHJavwOxVN7JsO5FrBQZc nb3oLM1e0fdNJTRxem86wTiDhq20paUp4CP7Y3BaHa+ddyDai81fX7CP4bOPqg== Date: Wed, 26 Jul 2023 02:50:50 +1000 From: Aleksa Sarai To: David Howells Cc: Alexey Gladkov , James.Bottomley@hansenpartnership.com, acme@kernel.org, alexander.shishkin@linux.intel.com, axboe@kernel.dk, benh@kernel.crashing.org, borntraeger@de.ibm.com, bp@alien8.de, catalin.marinas@arm.com, christian@brauner.io, dalias@libc.org, davem@davemloft.net, deepa.kernel@gmail.com, deller@gmx.de, fenghua.yu@intel.com, fweimer@redhat.com, geert@linux-m68k.org, glebfm@altlinux.org, gor@linux.ibm.com, hare@suse.com, hpa@zytor.com, ink@jurassic.park.msu.ru, jhogan@kernel.org, kim.phillips@arm.com, ldv@altlinux.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux@armlinux.org.uk, linuxppc-dev@lists.ozlabs.org, luto@kernel.org, mattst88@gmail.com, mingo@redhat.com, monstr@monstr.eu, mpe@ellerman.id.au, namhyung@kernel.org, paulus@samba.org, peterz@infradead.org, ralf@linux-mips.org, sparclinux@vger.kernel.org, stefan@agner.ch, tglx@linutronix.de, tony.luck@intel.com, tycho@tycho.ws, will@kernel.org, x86@kernel.org, ysato@users.sourceforge.jp, LKML , Arnd Bergmann , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk Subject: Re: Add fchmodat2() - or add a more general syscall? Message-ID: References: <104971.1690300714@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sqz3gv5iaglclup7" Content-Disposition: inline In-Reply-To: <104971.1690300714@warthog.procyon.org.uk> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --sqz3gv5iaglclup7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2023-07-25, David Howells wrote: > Rather than adding a fchmodat2() syscall, should we add a "set_file_attrs= ()" > syscall that takes a mask and allows you to set a bunch of stuff all in o= ne > go? Basically, an interface to notify_change() in the kernel that would = allow > several stats to be set atomically. This might be of particular interest= to > network filesystems. Presumably looking something like statx(2) (except hopefully with extensible structs this time :P)? I think that could also be useful, but given this is a fairly straight-forward syscall addition (and it also would resolve the AT_EMPTY_PATH issue for chmod as well as simplify the glibc wrapper), I think it makes sense to take this and we can do set_statx(2) separately? --=20 Aleksa Sarai Senior Software Engineer (Containers) SUSE Linux GmbH --sqz3gv5iaglclup7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQS2TklVsp+j1GPyqQYol/rSt+lEbwUCZL/9agAKCRAol/rSt+lE b9muAP9aP2TUmAAHS6rOFH9Gf6v2e1/S/NcOkGphCidcAt2ZiwEAzjtee/kbCs2+ akroOcjwVI11LFf34VRyguX0zOzOWQ4= =pGFN -----END PGP SIGNATURE----- --sqz3gv5iaglclup7--