Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <605d12e8a4fdcb238efc9b18fbd2637474de0049.camel@physik.fu-berlin.de>
Subject: Re: [PATCH v2] sparc: Use shared font data
From:   John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To:     "Dr. David Alan Gilbert" <linux@treblig.org>,
        Sam Ravnborg <sam@ravnborg.org>
Cc:     davem@davemloft.net, benh@kernel.crashing.org,
        sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 25 Jul 2023 19:15:08 +0200
In-Reply-To: <ZL/+Bz5C2Mxx0Msw@gallifrey>
References: <20230724235851.165871-1-linux@treblig.org>
         <20230725161040.GA832394@ravnborg.org> <ZL/+Bz5C2Mxx0Msw@gallifrey>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.48.4 
MIME-Version: 1.0
Precedence: bulk

Hi Dave!

On Tue, 2023-07-25 at 16:53 +0000, Dr. David Alan Gilbert wrote:
> * Sam Ravnborg (sam@ravnborg.org) wrote:
> > On Tue, Jul 25, 2023 at 12:58:51AM +0100, linux@treblig.org wrote:
> > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > 
> > > sparc has a 'btext' font used for the console which is almost identical
> > > to the shared font_sun8x16, so use it rather than duplicating the data.
> > > 
> > > They were actually identical until about a decade ago when
> > >    commit bcfbeecea11c ("drivers: console: font_: Change a glyph from
> > >                         "broken bar" to "vertical line"")
> > > 
> > > which changed the | in the shared font to be a solid
> > > bar rather than a broken bar.  That's the only difference.
> > > 
> > > This was originally spotted by PMD which noticed that PPC does
> > > the same thing with the same data, and they also share a bunch
> > > of functions to manipulate the data.  The PPC code and the functions
> > > I'll look at another time if this patch is OK.
> > > 
> > > Tested very lightly with a boot without FS in qemu.
> > > 
> > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > 
> > Looks good, thanks for the fixes.
> > Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> 
> Thanks
> 
> > Let's hope someone picks it up...
> 
> I was hoping Dave would, but I realise Sparc doesn't get much
> these days.
> Of course if anyone feels guilty about their own patches adding code
> they can take this patch to make ~340 lines of penance.

You can ask Andrew Morton to pick it up through his tree. He usually does
that when no one else is willing to pick a patch up.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913