Received: by 2002:ac8:4602:0:b0:405:464a:c27a with SMTP id p2csp2527992qtn; Tue, 25 Jul 2023 11:17:41 -0700 (PDT) X-Google-Smtp-Source: APBJJlHxIB9ClDCz2bXi2SVm2/rUfEannz2Y8mwcUIVBz24w3Vj4XIm+gwr993lI2bhUmgbOIc3d X-Received: by 2002:a17:907:1dc3:b0:99b:5862:1fc9 with SMTP id og3-20020a1709071dc300b0099b58621fc9mr13543867ejc.46.1690309061038; Tue, 25 Jul 2023 11:17:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690309061; cv=none; d=google.com; s=arc-20160816; b=NrnRR3NMcZeJtmzOgP0DaL4ye6plzxiE9MojjiTaB/CcME5OxbLP7IkZPEpuP1Q70F U6tugjJq1PF/Esvfop/wnmWm4YpF+AgbZUxHxIecvR4JkG1HjzefQdZgUuiG16aM4cmL i373JiWWZ7PJyod6IEPi2s19dS+XsA0j/iHcoPKjsseFASHqq1FX7EInqAXxLjanWhum cShQme/KNUkCLV4Nf4aWlHEwObc07lbHp8a7iRLsoLDQs24hhvJfnPtpbEZ6fKs6+D3s HtD+NmCvN3Cv5c/fe/U4T9v5Lx/GvdPQwK3nirmHxHbFWvbRra9t0qSteoZUdeinrVbA lN6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=lvBtawaJ3EexUMJTLs1T6uVkk976jUhaV2eerZFuUz4=; fh=GfIC7OZyrhnNyKHEhvLwLj3bCckYF4KZ+7JAuGdXAg8=; b=xGCszwTkrzGraf4Pjz6lX9l9+do9gTMsYqwF1IQlcikNgO4gf/3e3TJQlOB92uqnXC JV2dNFa1I+hlAu4j5wcl5j7hx3L00piDeZEVFkxyBQMiATNWqqw5NWQ8pNu4YvUAyOOn bMOHwuNK3xl62IRIhOjsAQ4ambUWyqeEjEBJk21pIi5WjQYbOFE/pcs0p62U94mUn4vc 7/KAGdFPLQz8ixvw7CU+ZdDzFh1efpMyv0plU5gd1IkgBZ3pf9hN/7kDTeY4m/NVFay9 q5R6nDf6TziKlsaccz81gcD8rKq3Wc3vZ0sgBG9p0OqghFybs1eKip+o8QY6jhc1/jIa eD3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b="xoVJF9/q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g21-20020a170906869500b00993470737basi7869478ejx.986.2023.07.25.11.17.15; Tue, 25 Jul 2023 11:17:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b="xoVJF9/q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231312AbjGYRnP (ORCPT + 99 others); Tue, 25 Jul 2023 13:43:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229761AbjGYRnO (ORCPT ); Tue, 25 Jul 2023 13:43:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 256AC1B8; Tue, 25 Jul 2023 10:43:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AB9F161839; Tue, 25 Jul 2023 17:43:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1F20C433C8; Tue, 25 Jul 2023 17:43:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1690306992; bh=fu3IBUmM1hIiTky2e88ZAQ1t8ZP4sqKPRBI5GS1mp2k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=xoVJF9/q0IT6pL9/yc5wwBX7EHfCwvlEl4/DiYssHgWeqQNMhcfXcGDzScpcyCIMd tlnZ8bZIOgFu+gE3EABqIhknibOnNkJ9hjO7Qa23BWJSdiOehqY3no7LPHsYODoLUE rXXfP+4vkrQHN/YDiIx2d2B+GU/qfbLduSUExjYY= Date: Tue, 25 Jul 2023 10:43:10 -0700 From: Andrew Morton To: Johannes Weiner Cc: Yosry Ahmed , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: memcg: use rstat for non-hierarchical stats Message-Id: <20230725104310.ac652a03ab92357a162b1f92@linux-foundation.org> In-Reply-To: <20230725140435.GB1146582@cmpxchg.org> References: <20230719174613.3062124-1-yosryahmed@google.com> <20230725140435.GB1146582@cmpxchg.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Jul 2023 10:04:35 -0400 Johannes Weiner wrote: > > Signed-off-by: Yosry Ahmed > > Acked-by: Johannes Weiner > > But I want to be clear: this isn't a regression fix. It's a new > performance optimization for the deprecated cgroup1 code. And it comes > at the cost of higher memory footprint for both cgroup1 AND cgroup2. Thanks. Yosry, could you please send along a suitably modified changelog?