Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230719152007.197710-1-arnaud.ferraris@collabora.com>
 <20230719152007.197710-3-arnaud.ferraris@collabora.com> <CACRpkdZ2Fu8jyyyDd4e1yq8g4bDoj2gCd4KnntST8uYvDNKUZw@mail.gmail.com>
 <0623ebc5-eef8-2c93-040f-eeeabc79ce17@collabora.com>
In-Reply-To: <0623ebc5-eef8-2c93-040f-eeeabc79ce17@collabora.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Tue, 25 Jul 2023 20:22:54 +0200
Message-ID: <CACRpkdY75A4NU3jyZfShNjd+mKhHmnNZY4+1YpAc=RanFBsX6g@mail.gmail.com>
Subject: Re: [PATCH v5 2/2 RESEND] drm: panel: Add novatek nt35596s panel driver
To:     Arnaud Ferraris <arnaud.ferraris@collabora.com>
Cc:     Neil Armstrong <neil.armstrong@linaro.org>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Molly Sophia <mollysophia379@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jul 25, 2023 at 4:16=E2=80=AFPM Arnaud Ferraris
<arnaud.ferraris@collabora.com> wrote:

> Their magic number sequences are quite different, however all the other
> bits (power/reset sequences and timings) fit in, which isn't the case of
> the other novatek panel drivers. Moreover, they have similar (although
> not identical) resolutions.

Hm OK I guess.

> I found an old (2012) datasheet for the NT35596 (without the final "S")
> which is marked "Draft", so I'm really unsure this will be enough to
> make sense of those numbers.

I would try to add the most obvious cases. (Such as "command FF", I
am pretty sure it is clear what that does.)

As I pointed out in some other review, long term we want to support
things such as gamma correction for panels, and then this kind of
information will help greatly, even small pieces.

Yours,
Linus Walleij