Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp81054rwb; Tue, 25 Jul 2023 12:14:57 -0700 (PDT) X-Google-Smtp-Source: APBJJlEKjqe9OANYeM000WmXhSnK6uOnFR8EdxdOXn16eP4/nev22Pi7oaeToouDDL7vZEUPR5vQ X-Received: by 2002:aa7:c459:0:b0:522:2711:871 with SMTP id n25-20020aa7c459000000b0052227110871mr7125959edr.1.1690312497116; Tue, 25 Jul 2023 12:14:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690312497; cv=none; d=google.com; s=arc-20160816; b=qy6Fut9XvXqyb72jgCXMluiyeWLTMO9GRED9WQJlLIfJOiGtmJ4lCfoQ6U0z0cdOcp 9H+ZtUhhkAColQNJvobBbunJnJ4PxfI4G4Q0iLB5yQi5zdqEuAwqOGwJi+zOdy48YFWx Y+2Cx/vQP4zJN27AiUgAxSP9O8gjf1skDkj0GG5PrHXHu65yKKYpr/3/+99ZR3KkJjzZ n/FzBVePreLbn8rTFvzmXc6Dy7cijFZ5aEMz/AM36tgLSy2vOJtrnaVHiyXttVdRVEx9 XYewGEJp4IFrLFJuErAQ7rflsLgQsVNRj+Gtu1ikmGHMkOoG54CzIl3SIfNfsw2tOzzu HajQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=dH5ug7kusOVMuUreMSXFuZF1tdruxcOogVPglkBHdUQ=; fh=Fa4l8on36+TAtg5Dk38UkT6icOFJaAHvEKGIytQYx0g=; b=LOTxeuAOs+R14DJEoqtGb7Zy6RHPECzU3z5J22RXaU2HpjOqrhjUhyhjkPlGGdspX4 YcHHhTdBEUFN8Y/4pGN8ISR0pd1OxxfsJkwF1oTx2FItm4GVS+4m7NDnnl4zVx9temT8 y4G2hiht9zaGiPjAL4BeVprD9EcCxnq76ceEMkTQIsQXZ3PzSyNnI3ash8TvtvmLw+Q9 dwTzhIn+EOq/Iz5hLse6NVkMoWJa8aSPnQNlbb7WMnAZHDWGJ9Vf7Oe7YkcVG5BxMB3I wjSRxhePXAWLZlMFHfPEvhgFQzl46v2eMqGwRZPZiIsS7FgRslN9tLbD+MM1jpCIqoeq TbVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y4-20020a50eb04000000b0052218bc55e8si5737939edp.238.2023.07.25.12.14.33; Tue, 25 Jul 2023 12:14:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231221AbjGYSdS (ORCPT + 99 others); Tue, 25 Jul 2023 14:33:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231740AbjGYSdO (ORCPT ); Tue, 25 Jul 2023 14:33:14 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EC822129; Tue, 25 Jul 2023 11:33:14 -0700 (PDT) Received: from [185.230.175.137] (helo=phil.sntech) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qOMqD-0006Er-BR; Tue, 25 Jul 2023 20:33:01 +0200 From: Heiko Stuebner To: Chukun Pan , Krzysztof Kozlowski , Jonas Karlman , Conor Dooley , Rob Herring Cc: Heiko Stuebner , devicetree@vger.kernel.org, FUKAUMI Naoki , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] arm64: dts: rockchip: Fix regulators and enable SATA on Radxa E25 Date: Tue, 25 Jul 2023 20:32:58 +0200 Message-Id: <169030979754.2939984.9282914456412331786.b4-ty@sntech.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230724145213.3833099-1-jonas@kwiboo.se> References: <20230724145213.3833099-1-jonas@kwiboo.se> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS, T_SCC_BODY_TEXT_LINE,T_SPF_HELO_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 Jul 2023 14:52:16 +0000 (UTC), Jonas Karlman wrote: > Despite its name, the regulator vcc3v3_pcie30x1 has nothing to do with > pcie30x1. Instead, it supply power to VBAT1-5 on the M.2 KEY B port as > seen on page 8 of the schematic [1]. > > pcie30x1 is used for the mini PCIe slot, and as seen on page 9 the > vcc3v3_minipcie regulator is instead related to pcie30x1. > > [...] Applied, thanks! [1/2] arm64: dts: rockchip: Fix PCIe regulators on Radxa E25 commit: a87852e37f782257ebc57cc44a0d3fbf806471f6 [2/2] arm64: dts: rockchip: Enable SATA on Radxa E25 commit: 2bdfe84fbd57a4ed9fd65a67210442559ce078f0 As you can see, I've split them in two. Please check that I didn't mess anything up. Having an "and" in the commit subject is always a very strong indicator that a split is probably a good thing ;-) Best regards, -- Heiko Stuebner