Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Jul 2023 19:36:51 +0100
From:   Conor Dooley <conor@kernel.org>
To:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, ulf.hansson@linaro.org, shawnguo@kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH] dt-bindings: power: fsl,scu-pd: separate out fsl,scu-pd
Message-ID: <20230725-excretory-speed-003064040657@spud>
References: <20230725102900.225262-1-peng.fan@oss.nxp.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="7EZV4UB6EfrGONHL"
Content-Disposition: inline
In-Reply-To: <20230725102900.225262-1-peng.fan@oss.nxp.com>
Precedence: bulk


--7EZV4UB6EfrGONHL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 25, 2023 at 06:29:00PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>=20
> Add an entry dedicated for fsl,scu-pd which could serve i.MX8DXL

Why not just add a soc-specific compatible for the i.MX8DXL?
The current form of this does not look right to me.

>=20
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  .../devicetree/bindings/power/fsl,scu-pd.yaml         | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml b/Do=
cumentation/devicetree/bindings/power/fsl,scu-pd.yaml
> index 407b7cfec783..3a92e4fef7ae 100644
> --- a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> +++ b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> @@ -18,11 +18,14 @@ allOf:
> =20
>  properties:
>    compatible:
> -    items:
> +    oneOf:
>        - enum:
> -          - fsl,imx8qm-scu-pd
> -          - fsl,imx8qxp-scu-pd
> -      - const: fsl,scu-pd
> +          - fsl,scu-pd
> +      - items:
> +          - enum:
> +              - fsl,imx8qm-scu-pd
> +              - fsl,imx8qxp-scu-pd
> +          - const: fsl,scu-pd
> =20
>    '#power-domain-cells':
>      const: 1
> --=20
> 2.37.1
>=20

--7EZV4UB6EfrGONHL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZMAWQwAKCRB4tDGHoIJi
0rfNAQDlWP28k/SoGr0qeOAevMMGAMV+FRHZnsFzjAeh+XfLjQD8CXmyqPBN73TK
+5kkiXUj9PNRUue0TPtJwgbO6qNX/AI=
=bo2G
-----END PGP SIGNATURE-----

--7EZV4UB6EfrGONHL--