Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Jul 2023 20:30:51 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Sebastian Reichel <sebastian.reichel@collabora.com>
Cc:     Eugen Hristev <eugen.hristev@collabora.com>,
        linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        netdev@vger.kernel.org, david.wu@rock-chips.com, heiko@sntech.de,
        krzysztof.kozlowski+dt@linaro.org, kernel@collabora.com
Subject: Re: [PATCH] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay
 defaults in schema
Message-ID: <20230725-sulphuric-syndrome-3eaace57ef43@spud>
References: <20230725155254.664361-1-eugen.hristev@collabora.com>
 <20230725161156.22uscijrot7gbnvj@mercury.elektranox.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="hNlqjw351EVDd4gT"
Content-Disposition: inline
In-Reply-To: <20230725161156.22uscijrot7gbnvj@mercury.elektranox.org>
Precedence: bulk


--hNlqjw351EVDd4gT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 25, 2023 at 06:11:56PM +0200, Sebastian Reichel wrote:
> Hi,
>=20
> On Tue, Jul 25, 2023 at 06:52:54PM +0300, Eugen Hristev wrote:
> > The defaults are specified in the description instead of being specified
> > in the schema.
> > Fix it by adding the default value in the `default` field.
> >=20
> > Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-=
schema")
> > Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
> > ---
>=20
> Maybe also fix the allowed range while at it? I.e.
>=20
> minimum: 0x00
> maximum: 0x7F

Beat me to it! Please do.

--hNlqjw351EVDd4gT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZMAi6wAKCRB4tDGHoIJi
0vL5AQD8BuidIynoyj33cY6xqSwkDbogVJO15KjdNiTQNkRSVQEA74iQMUfeoN34
jQtR5vFXPxgj7VEzcVIMqN35ErvrCQI=
=ORDo
-----END PGP SIGNATURE-----

--hNlqjw351EVDd4gT--