Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp147398rwb; Tue, 25 Jul 2023 13:23:50 -0700 (PDT) X-Google-Smtp-Source: APBJJlHx5zMt+34irQ5Tn6o+ee01AuhOFjRregcA8IBi7IiwD650H5u2nugbHIc+geSqHCyYYHaO X-Received: by 2002:a05:6a00:1591:b0:66c:9e97:aece with SMTP id u17-20020a056a00159100b0066c9e97aecemr321941pfk.10.1690316629924; Tue, 25 Jul 2023 13:23:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690316629; cv=none; d=google.com; s=arc-20160816; b=g23Ul34ArUo+cyD95B2+3axQl8rFmAKohuDQXgf4RXuC7NYkbHhGNZi59vxvElxZWX ptX6ujlaVGcRki1deo6L6oWYaQxL+qVKAv19f/XNLUy3Z3rrUywbjO/Vtxk3hHLW2ryY aL+hJDYQA7VtxCPN5V1/6CSQqwLYtS0y4vis2Dn9ROzTQtD1sCr/i5QW4sPrp4z1p3ao mi2T5ZLzZTs3ZIu0VkLAD3gmr6PRozQQl3WkhP42FJD+PGmhKmGo37+A+GgD8gFLkM6H fWSG/g/reFoKC3K3AISv7gZKjxpJx3UI0Pwz33frPxw8AD8w443yo0jZpVdv6do93XBC LV7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=SyhkrkDRaXfX0rhzthINVAojcDsXOZ/ydnMtXyX0kZc=; fh=0UbEqJuojFqjP6Wubl2g779wagSTieqsMfa+w3rH+r4=; b=KstKGA/qDE+k6xyz4lEPt1l3EzQxkAvTXR9OAyP27ms8AUVLUcy40hextEqhWTSKwb X5w5UG5IWExiBdP/ngl4DRYMp2dtoUdGC7y8epNAsS9k4ETVyiiJQvHrg+S3LgVDQr8z KAl4A495QIw9Azx25LGKphwW3ZpN+HRdhXzQk5XgLQUfg9tvhUq4ZkD/35Q+3feYFD5C 6iwFLGQrB5OCA7K1aMXFK1O64uzICqryPj0kYTDvfX3Y5qUpsxGoGC0nx0ArUA2RN3DF RdCG9fo+Ow4qDfhmnIzvrHQk40KuTr5zGLAv24e6r9cNuqPWA+IUpVu4rKo0LwonzXxy BBCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V2y6Y1HJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p40-20020a056a000a2800b006789229c538si12476045pfh.48.2023.07.25.13.23.36; Tue, 25 Jul 2023 13:23:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V2y6Y1HJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229824AbjGYT4G (ORCPT + 99 others); Tue, 25 Jul 2023 15:56:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbjGYT4F (ORCPT ); Tue, 25 Jul 2023 15:56:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AB4119A1 for ; Tue, 25 Jul 2023 12:56:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8EA6661883 for ; Tue, 25 Jul 2023 19:56:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CFB4C433C7; Tue, 25 Jul 2023 19:56:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690314963; bh=GiXQu/nD8DNTAps01d2gInzs5Y3/qwmhEDn60fHTXNc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V2y6Y1HJ2urzh7TOYLE5dX/DhXm07qPkuUdUmM9FSyxBGbCikHDt7bKkVl1f4ictT jsfMI1oiafgXo3vqvhAmrWGzOpShV20VY8ImYhGtW2Mrzx/eHpj0Bx15JIPvzsH6Hr AyJXL9YDzBa1haqs/6/IVjlYz1XAvBRMh/dbje22tBMFnWPZkxF29wSnamY4p3eHQy qkqyclynQ8VFIbFZ/7n5lTOtHHMbHTR1jIevefLhtKdsgQ8FDf9RCcxeCvTUkd/rjU jsLw39GdxVXXh6Dm8ZxoagaoxwOgM0QkbTbdHJ70qhnl0V9YunOICB46M9DcBQiOb9 otVlAUiij8ckg== Date: Tue, 25 Jul 2023 12:56:01 -0700 From: Jakub Kicinski To: Joe Perches Cc: Lin Ma , jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net/sched: mqprio: Add length check for TCA_MQPRIO_{MAX/MIN}_RATE64 Message-ID: <20230725125601.7ec04aa5@kernel.org> In-Reply-To: <4ce3c7a980be3ce9012ba02a5d9d4285cdf4fd07.camel@perches.com> References: <20230724014625.4087030-1-linma@zju.edu.cn> <20230724160214.424573ac@kernel.org> <63d69a72.e2656.1898a66ca22.Coremail.linma@zju.edu.cn> <20230724175612.0649ef67@kernel.org> <20230725123842.546045f1@kernel.org> <4ce3c7a980be3ce9012ba02a5d9d4285cdf4fd07.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Jul 2023 12:50:00 -0700 Joe Perches wrote: > > > What do you think the "case" is here? > > > > > > Do you think John Fastabend, who hasn't touched the file in 7+ years > > > should be cc'd? Why? > > > > Nope. The author of the patch under Fixes. > > It adds that already since 2019. Which is awesome! But for that to work you have to run get_maintainer on the patchfile not the file paths. Lin Ma used: # ./scripts/get_maintainer.pl net/sched/sch_mqprio.c That's what I keep complaining about. People run get_maintainer on paths and miss out on all the get_maintainer features which need to see the commit message.