Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-592-ga9d4a09b4b-fm-defalarms-20230725.001-ga9d4a09b
Mime-Version: 1.0
Message-Id: <990b6871-169b-4d03-b202-f19294730f8c@app.fastmail.com>
In-Reply-To: <ZMAqPdO2XcIXOCFs@corigine.com>
References: <20230725064403.581634-1-arnd@kernel.org>
 <ZMAqPdO2XcIXOCFs@corigine.com>
Date:   Tue, 25 Jul 2023 22:37:07 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Simon Horman" <simon.horman@corigine.com>,
        "Arnd Bergmann" <arnd@kernel.org>
Cc:     "David S . Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>,
        "Ioana Ciornei" <ioana.ciornei@nxp.com>,
        "Russell King" <linux@armlinux.org.uk>,
        "Robert-Ionut Alexa" <robert-ionut.alexa@nxp.com>,
        "Russell King" <rmk+kernel@armlinux.org.uk>,
        "Vladimir Oltean" <vladimir.oltean@nxp.com>,
        "Wolfram Sang" <wsa+renesas@sang-engineering.com>,
        "Sean Anderson" <sean.anderson@seco.com>,
        "Josua Mayer" <josua@solid-run.com>,
        Netdev <netdev@vger.kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dpaa: avoid linking objects into multiple modules
Content-Type: text/plain
Precedence: bulk

On Tue, Jul 25, 2023, at 22:02, Simon Horman wrote:
> On Tue, Jul 25, 2023 at 08:43:40AM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> 
>> Each object file contains information about which module it gets linked
>> into, so linking the same file into multiple modules now causes a warning:
>> 
>> scripts/Makefile.build:254: drivers/net/ethernet/freescale/dpaa2/Makefile: dpaa2-mac.o is added to multiple modules: fsl-dpaa2-eth fsl-dpaa2-switch
>> scripts/Makefile.build:254: drivers/net/ethernet/freescale/dpaa2/Makefile: dpmac.o is added to multiple modules: fsl-dpaa2-eth fsl-dpaa2-switch
>> 
>> Chang the way that dpaa2 is built by moving the two common files into a
>> separate module with exported symbols instead.
>> 
>> To avoid a link failure when the switch driver is built-in, but the dpio driver
>> is a loadable module, add the same dependency in there that exists for
>> the ethernet driver.
>> 
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Hi Arnd,
>
> overall this looks good to me.
> One thing that I noticed, and I'm not sure if we care,
> is that an x86_64 allmodconfig now reports:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in 
> drivers/net/ethernet/freescale/dpaa2/fsl-dpaa2-common.o

My mistake, I had disabled the warning in modpost.c as it was
generating too much output while I tried to address some
other warnings, so I missed the regression I introduced.

I'll send a v2, adding

MODULE_DESCRIPTION("DPAA2 Ethernet core library");

      Arnd