Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp245893rwb; Tue, 25 Jul 2023 15:16:48 -0700 (PDT) X-Google-Smtp-Source: APBJJlGAwlMUG/o3HEDSkdjiRkGjg2/RqgtBO+LbmRoFkLbV5muHuDWQ3Rbzv88+iRAYXdg0+/0v X-Received: by 2002:a17:906:64c6:b0:99b:c2ce:501c with SMTP id p6-20020a17090664c600b0099bc2ce501cmr106883ejn.19.1690323408402; Tue, 25 Jul 2023 15:16:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690323408; cv=none; d=google.com; s=arc-20160816; b=OgFi1FOYo5Ogj3ZksXZYoN9tWTeSI9JaPKUQ3JI8J5Y8d7P4Od4OPGsP8LIWvX8aqb cFUooMOMGbEti4RkN1J0IWdv3FOKqFGdkqqjAhGjJshJjzkLlnEjCA0mUp+4bk6IFbC0 WaUbzm+mhNef5977/0nKsa0e8Z5fuBnJ+tftlh2maEwqe8J19DHIT3pyl26PUdsChtb1 /0y8e2iPJYXPsLAzr682gZbArXj5qWzzTCd5/DhEJ+/ouXl6LBm5mBfpYIMoYWcHZac2 7Q2w/PEerhVJL1wMcjb6bFIddbitRRd/71ZJ9g4ckjRjpkpFCwsd9jRqrghBRdwOdWMY Q7PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=0NAyxb3rFJ8DVsDZGRmjKUAotFVj47uT2nzJm7HWZdo=; fh=9aMyxxxkrPgtyopTF0ws92R373ENe434X4JpSy6np4k=; b=t4YdxdFAa4YZOzYwQHodx6jIn+bfgilHvCGFfJrvQ/Fh/ZTsudPXI87Rakn3fYBuXS gTHRsYrmfFmiiJx0GaIRvshQrZJimt+0SekyrgjbUSBOHQ6tmKJE1lMlkcFVp3jxtUu/ OBfCZnLkdhvb/Z7BDVU+S+QM+YHCIUomRhasCcWue7jNJfs3WO7FcA3i3TWb4ueKBx/J BP+KJknsXRejVu2mj360UrIGavrnb//ie9eiGAe1poCgCW/oLzRGpuUWiHEQ319B8rvf tajqy7bxSJXyqbltv57goeTrR0WqKGAksoHpNR3tN8vqrDug3NDTK7nes2v6Fp8uRULG ggxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=BfCSapNP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s13-20020a1709066c8d00b0098dfdc3f2desi9061326ejr.676.2023.07.25.15.16.23; Tue, 25 Jul 2023 15:16:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=BfCSapNP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230494AbjGYVxO (ORCPT + 99 others); Tue, 25 Jul 2023 17:53:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230269AbjGYVxN (ORCPT ); Tue, 25 Jul 2023 17:53:13 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 016B71FEC; Tue, 25 Jul 2023 14:53:11 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-26813cd7a8aso1799278a91.2; Tue, 25 Jul 2023 14:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690321990; x=1690926790; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=0NAyxb3rFJ8DVsDZGRmjKUAotFVj47uT2nzJm7HWZdo=; b=BfCSapNPBI0ZoQl7ctCkDeeepZfQfgulGN6gyOx0/0sueOCMg+/WgJwjCPjwW3s7hW As1hkOmgewEGqke6eHhJvmEbq87INwhshGea5/sb/WfzBODNRJK7fhdlZToVMq+A1htr 4ePA7C2h6x9qm2k/fMq/5VJCfu3cr8cuxm1LD0s75OxL9svbACeumsBL+xfUyqbGEgmK svKjR8R3RvK+0HnPwQ+l0b9+sPwzgfQsvvJU8Qg+LRE+n0KAup5JxRsWGQYsYoGkEvcI 9eohhry1vatEoRG1AJ7Fhxb2wYQ3AVE+aSokm9icL/xt4EMOlpExIw/o9wRjVpi42jl9 ptTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690321990; x=1690926790; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0NAyxb3rFJ8DVsDZGRmjKUAotFVj47uT2nzJm7HWZdo=; b=Sz0neua4AU3ODyst+TEeEPBOV5kT8xd99iy9O/YsjJWasX+gds6Y/ZK7Z8CprtGHy1 KK7cPJZM1vL//jCrfPiSCIf1jMql32nI9odwmoPj+4mFjIYcCg8Ek/1C56Z2VfnBpFO1 /PrmpdKyVhwmyaV2nlAZvDIEuzmTy8PmeW4zcKaMV5duRXPzAqOzVoTvFoQF3M5T+qFv YVRPx9SgrFhLi7metZoGWFym0Ukh4AWiyfCzsI2ijX+I7sTCQxctPxDA2A9VHUdljYnZ wY1eqxZt6oLGXxfK2GLnbBw6xh94JJqnEpk3S3P23VyYQYibfaxpdbOj/S4AhFh59b/K j2Zg== X-Gm-Message-State: ABy/qLbLsK1GtXd6eBXFljvQHEdiIlyE/HF2Da3Pnt62GmvecSJhXC87 Lw7ufV2IMf3ewGw2QKWXNrx45/uKxf4= X-Received: by 2002:a17:90b:384d:b0:263:41d2:4e2 with SMTP id nl13-20020a17090b384d00b0026341d204e2mr383740pjb.32.1690321990274; Tue, 25 Jul 2023 14:53:10 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::5:18d]) by smtp.gmail.com with ESMTPSA id cp7-20020a17090afb8700b0026812c28365sm37497pjb.37.2023.07.25.14.53.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jul 2023 14:53:10 -0700 (PDT) Sender: Tejun Heo Date: Tue, 25 Jul 2023 11:53:08 -1000 From: Tejun Heo To: Miaohe Lin Cc: hannes@cmpxchg.org, lizefan.x@bytedance.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cgroup: minor cleanup for cgroup_local_stat_show() Message-ID: References: <20230723031932.3152951-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230723031932.3152951-1-linmiaohe@huawei.com> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 23, 2023 at 11:19:32AM +0800, Miaohe Lin wrote: > Make it under CONFIG_CGROUP_SCHED to rid of __maybe_unused annotation. > Also put cgroup_tryget_css() inside CONFIG_CGROUP_SCHED as it's only > called when CONFIG_CGROUP_SCHED. No functional change intended. > > Signed-off-by: Miaohe Lin Patch doesn't apply to cgroup/for-6.6. Can you please respin? Thanks. -- tejun