Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Tristram.Ha@microchip.com>
To:     <kuba@kernel.org>
CC:     <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
        <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
        <f.fainelli@gmail.com>, <UNGLinuxDriver@microchip.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v5 net-next] net: phy: smsc: add WoL support to
 LAN8740/LAN8742 PHYs
Thread-Topic: [PATCH v5 net-next] net: phy: smsc: add WoL support to
 LAN8740/LAN8742 PHYs
Thread-Index: AQHZu2v70H+1OzGMA0qdZdmnF24a96/Jmo2AgAGUNHA=
Date:   Tue, 25 Jul 2023 23:51:43 +0000
Message-ID: <BYAPR11MB3558593293C41090D57EADE4EC03A@BYAPR11MB3558.namprd11.prod.outlook.com>
References: <1689900053-13118-1-git-send-email-Tristram.Ha@microchip.com>
 <20230724164351.2ecf6faf@kernel.org>
In-Reply-To: <20230724164351.2ecf6faf@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vg5CUcWBLnb6+85r9I61E4sY0lrIJdJ8ihn5PxNU9d4fPCVi+L6tnF/zVWoX?=
 =?us-ascii?Q?816pR8xSw5OCfqCp020bHpaRwstuINqR4Okm+3yFdCWPYF7+C5WNXyBwWnib?=
 =?us-ascii?Q?mEOf/SKrXJD8ILkdXvdvtRwGU9vtvaPKw1D10u73ZxDbLQbYACI2V5N7HN9I?=
 =?us-ascii?Q?K8NNBCU0iTNjvqBd6gw5p9DnRwU6/BgsqKrlNyC7nGVtdxFpxv412TSEeTUJ?=
 =?us-ascii?Q?mU6ySv3nBUnz48djIt8ooUaDN7rVojTdPsdMp7cRlcbrxOgBLtGIpSrk2pdq?=
 =?us-ascii?Q?5mKX1l1xzv5uUQ9PbCNX3HQzsaMHX1nB9nnUCNXb6n9PRUnXs5LLR/by9kuH?=
 =?us-ascii?Q?fIvPNWl7t9DG0dNrnA+O0s3Pivfecy8KcZFXXJay+5SEU8BKGoN/RwR3b0Lf?=
 =?us-ascii?Q?FomxLnraDH1MlxDuWl7SuND9RquSWhg7OLEwW/d/MgkaQ77ZGQo/tjkcOQis?=
 =?us-ascii?Q?KTlJUpY6DG393cXJSQq7zw3U5LEhfcLhlALWF9PSwzHs2rI6oW8J15VOETqU?=
 =?us-ascii?Q?nEqQ5aA5FlGhXUhd0gyWqC5Ho7jN5DiV9J0VZ6HTjaJVhfTXZa9ag4zT8fTg?=
 =?us-ascii?Q?Nr+z+clLPtfB7DEDGFEj/w0XSiKaEpNz1oDDByZ1er0CPFeoP8xEj7JWSN2H?=
 =?us-ascii?Q?Twr9d1OAgCd70spOagoWoa7hm8QAk9hrAx8FPnSfioodp9fFBaMqwo7Jo3/v?=
 =?us-ascii?Q?D5TV7d9yPltE/mdvvhq/m+nONyGN+7+cmMrGITw+w4fucFObyqOANDVNK5GN?=
 =?us-ascii?Q?+Frlnrz6ewl1yWYw35T/CkewZSCVpr4OymSlp3mQQ3xEzaesK9cCx8ben12U?=
 =?us-ascii?Q?Aa07/K8HFQVy8pgNkU2jbueXgxTwsQXSCAMa5WDvjHFbqGruDgqjxQ9zeq0j?=
 =?us-ascii?Q?av6SAFgU6qe1/kcRKdlHEPUyj+KkUvH7YY5Gj/UI9DOpbD+xtHeWsaSNAA7d?=
 =?us-ascii?Q?SSQyQ7LSeXIjD7hSAwbOkS/RD+NFHYH2hZHs1+LSCygBg1hr6SNFs3ALkDeX?=
 =?us-ascii?Q?cQP4MMc0i7VIQdkrvHDIbpaPZ6ioU9qfcyIucS1Eo6tGpdI3eT5jUpRsHqPq?=
 =?us-ascii?Q?VHN/VA9S4c5E9pLLtedwMLhMKlbUrsQ0cMdUH/O8HgiE9wd4A5799vz7Rllc?=
 =?us-ascii?Q?OnonrIpzxeko0fV6AyJUHf5X+xFUL26wIVAncdvn7OXOlle4gTYFokaLjQpI?=
 =?us-ascii?Q?h98tsHMkqfWuOYbAZjfRLy22IbagygOj5z/HzFjhKcRJgjY0c/XaOCPVSFab?=
 =?us-ascii?Q?XL+s+gfGENIlouhRMa/TDfPfhtLz+WtTVHeLavyoNAQgrupRwujxf533roSS?=
 =?us-ascii?Q?oCW/pEkg0xguoJ3MCz6HYT1ZHrV4OvxmZ2P7k9rfeW9w9iY21vBnQM0TJlp5?=
 =?us-ascii?Q?xRdMjwKShT2QiV3yRj44M2idJhVtQJhmIIF/55eNtzC3lA+9GKLTprxCVPm9?=
 =?us-ascii?Q?3ZyvLq9Li3Wuy2M+diGZZFrdXXbJIPC4oX2pJbRZKQ/r07n8qGN9lXlbsYKp?=
 =?us-ascii?Q?O3iriZq678SNXwVK0RB3PEljOt0ScMH4T4DfnOjo3Ng1ezOZrFjvv2J5sQoH?=
 =?us-ascii?Q?SqCqTyv/kXMBTO63/J9bcIgfb4g44/uLMKchYZya?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3558.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c751be7-4650-4bda-520a-08db8d6a1996
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2023 23:51:43.7805
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EciqXoTqIDDizpz7/z9H62U8WalqdrmSPNnOcG4O8qxj1Bp0bh5V8+QUrjp19t95CmwexXZPMu+a/e80khMZWHFdTio8AWbCJCj6dLAV/GM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5916
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Thu, 20 Jul 2023 17:40:53 -0700 Tristram.Ha@microchip.com wrote:
> > +#include <linux/inetdevice.h>
> > +#include <net/addrconf.h>
> > +#include <net/if_inet6.h>
> > +#include <net/ipv6.h>
>=20
> You don't need these includes any more, right?
>=20
> >  #include <linux/smscphy.h>
> >
> >  /* Vendor-specific PHY Definitions */
>=20
> > +static int lan874x_set_wol(struct phy_device *phydev,
> > +                        struct ethtool_wolinfo *wol)
> > +{
> > +     struct net_device *ndev =3D phydev->attached_dev;
> > +     struct smsc_phy_priv *priv =3D phydev->priv;
> > +     u16 val, val_wucsr;
> > +     u8 data[128];
> > +     u8 datalen;
> > +     int rc;
> > +
> > +     if (wol->wolopts & WAKE_PHY)
> > +             return -EOPNOTSUPP;
>=20
> You're not advertising the support for WAKE_PHY, so you don't have to
> check if it was requested. See recent commit 55b24334c0f2.

They will be removed in next update.