Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     Conor Dooley <conor@kernel.org>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "conor+dt@kernel.org" <conor+dt@kernel.org>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: RE: [PATCH] dt-bindings: power: fsl,scu-pd: separate out fsl,scu-pd
Thread-Topic: [PATCH] dt-bindings: power: fsl,scu-pd: separate out fsl,scu-pd
Thread-Index: AQHZvuIo+RWSoLABrUiHrp6dtY69Sa/K0C+AgABgB2A=
Date:   Wed, 26 Jul 2023 00:21:10 +0000
Message-ID: <DU0PR04MB94171BDFA6FF61A644138F688800A@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20230725102900.225262-1-peng.fan@oss.nxp.com>
 <20230725-excretory-speed-003064040657@spud>
In-Reply-To: <20230725-excretory-speed-003064040657@spud>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N2z6IekH9zkIf6HzJKXKKQYv+BrWhZO79ZssRyN1m3WZ6mOz33p3hCjImHep?=
 =?us-ascii?Q?q8n7zlUYr+3WZM1zYvADI2MwRANySPKMDBk40oa7pid+vWACDU6fl67sJdhb?=
 =?us-ascii?Q?xpvHS4963kFfzElbrco9ByqS+T/yKTV/Bi30kbf/7gaALJUfOIBjWDOwCSeH?=
 =?us-ascii?Q?GOgaiibdWxqCiD121TYl3hfxNs5QkQ17RShSmgo45hxfDKl7VrDAxuOQtM5r?=
 =?us-ascii?Q?CgxNA2JR62Y8SF8GY11R1Ce1EfWb8boywdgFWSV/I/+vXVEvrDMTb70edzu7?=
 =?us-ascii?Q?Pw6qJsSAg3TnjxGC8Jiok3MWmPwR2IkEi0X3tVUvshxzTFj7vzVavHRzC+hm?=
 =?us-ascii?Q?rDLhqMkPd57lhNQGGr1yzN+zssVuswr2fVJWa2SC4U1s0lUNIU+UhvEG+5B8?=
 =?us-ascii?Q?umDpSlDHnEdvASnFkM2Uds3fNn/s55XQBr7pBRTF028cjRcSH0GEwIVWYODp?=
 =?us-ascii?Q?xQKBdRY9NvkJ60vrIqO8ImHTrRaJLMxf76eF7anckBQ0P948h7HhOBzs2Izh?=
 =?us-ascii?Q?DIOsruKvexkYO2cFF73AEHWl+A729uLB6BoPjetzWmL9D8PP2cNAmt68BxPZ?=
 =?us-ascii?Q?BMLlVSoqb6hI7GoEcTsE/eB49ZMPtjoafkI+xPTtQmvcS6vLGSoCpJKONmhz?=
 =?us-ascii?Q?Yglt4SMk0JBcl/gKkFfZTIaVDZMQneNU3V3dEo5SV+GKVdhg9iLHsll9DFUM?=
 =?us-ascii?Q?tWsmPY4qeiPWBhGsKUfrv9y8ZyFzC4umVDBYeJnXpHT4/ox2WYExIhFu84D/?=
 =?us-ascii?Q?TokScl6caiCUvMkCocfpDo48ip/DMqtn+aMP0i/sK2vA5rJ7FA8ucMEkiOl3?=
 =?us-ascii?Q?hO21999zRMdfwkegvAWpRHnBOXtFW7m67H9oVZUzmAxNYvzOV5DK9imGmuVG?=
 =?us-ascii?Q?roG3xLZnNU8zTF7DVu883NU6RWMTdQ7BtILeowIKOX041PLEufWriJG+d8XO?=
 =?us-ascii?Q?Zum3zyoLFbHkJYix5RM2dkuINwdUIpg+79MJw+XcXeI0ggeoeQtMS7Qw1MdA?=
 =?us-ascii?Q?aaeAiZnstAhiQQ3npaArZgLONiL2rj6VZWDKPhdvs0Ucfn8i8asc/fVaPP8B?=
 =?us-ascii?Q?9CfzKzewENiipaRBAVCmEVLEBiqrxpOvhWaMDY+6+VrMj1SUIXiP2wEjXaSD?=
 =?us-ascii?Q?02S+JEEGrMxaurCCJdoH3rXD9f4WQlUTSxsG8fFOHsJ7ALgeO9QcYiw+uq2v?=
 =?us-ascii?Q?sTThIAFRNY8oiv8ydxBEto9Q67JFcjDqvGRgFH8BOgrjol+AM3wpX8P0/ffO?=
 =?us-ascii?Q?EaO5hDajID4Bpp+qj5MbeHIyeClqKzpd2nhrlndpIQ2T3CFGL3e9LaqKwWA9?=
 =?us-ascii?Q?rPzydqMBP1EzoQIUQ5PgAucyhbRnZUh/hitQaAhKmMTiiiELM04C9qD/3IGM?=
 =?us-ascii?Q?+/e5mR3z0QayW9ip3kiN8Oqr+jxnTKA1rgwjs9w7xsCQShJAAbb9ROqykOI6?=
 =?us-ascii?Q?3r5B6Qc5GeEtJ2mCqZCP/5J4BGIDwbdYjSCrHnBgWhy6dT8MOdR/YAFF69Af?=
 =?us-ascii?Q?MtBV4GgcGXico2s0Jnm2nfIOKMkvLe+JFbYqlWvzV97pUettCfVBEx09xmK1?=
 =?us-ascii?Q?rRljvTrYzjIA38iIlc4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0af12edd-7e7b-49b0-de9f-08db8d6e366a
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2023 00:21:10.1459
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: eqzqQnsKWDzovRTqDQ4dvfIAex2vJWU9LpKyGeEknnkQsmdOZardYzQBfVlmHH1FC1dH/vDNq5eBq+c/UZS3zw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7388
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH] dt-bindings: power: fsl,scu-pd: separate out fsl,scu=
-pd
>=20
> On Tue, Jul 25, 2023 at 06:29:00PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Add an entry dedicated for fsl,scu-pd which could serve i.MX8DXL
>=20
> Why not just add a soc-specific compatible for the i.MX8DXL?
> The current form of this does not look right to me.

I could add one dedicated for i.MX8DXL.

Thanks,
Peng.

>=20
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  .../devicetree/bindings/power/fsl,scu-pd.yaml         | 11 +++++++----
> >  1 file changed, 7 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> > index 407b7cfec783..3a92e4fef7ae 100644
> > --- a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> > +++ b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> > @@ -18,11 +18,14 @@ allOf:
> >
> >  properties:
> >    compatible:
> > -    items:
> > +    oneOf:
> >        - enum:
> > -          - fsl,imx8qm-scu-pd
> > -          - fsl,imx8qxp-scu-pd
> > -      - const: fsl,scu-pd
> > +          - fsl,scu-pd
> > +      - items:
> > +          - enum:
> > +              - fsl,imx8qm-scu-pd
> > +              - fsl,imx8qxp-scu-pd
> > +          - const: fsl,scu-pd
> >
> >    '#power-domain-cells':
> >      const: 1
> > --
> > 2.37.1
> >