Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230725093005.3499455-1-lerobert@google.com> <87sf9ctifg.wl-tiwai@suse.de>
 <CAOM6g_Db8qwbDmbWSSLKqUHsSMLUYxFtpqKi1cWsXsXTE9B+vA@mail.gmail.com> <87lef4thir.wl-tiwai@suse.de>
In-Reply-To: <87lef4thir.wl-tiwai@suse.de>
From:   Robert Lee <lerobert@google.com>
Date:   Wed, 26 Jul 2023 09:47:13 +0800
Message-ID: <CAOM6g_DVKpEhnVStpNWmPoXyHNUuNTA+CNbdPxasObGcXtGEpQ@mail.gmail.com>
Subject: Re: [PATCH] ALSA: compress: add opus codec define
To:     Takashi Iwai <tiwai@suse.de>
Cc:     vkoul@kernel.org, perex@perex.cz, tiwai@suse.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Yes, but we still need this change to let the sound system can use the
codec. or do you have any suggestions?

Thanks,
Robert.

Takashi Iwai <tiwai@suse.de> =E6=96=BC 2023=E5=B9=B47=E6=9C=8825=E6=97=A5 =
=E9=80=B1=E4=BA=8C =E4=B8=8B=E5=8D=886:25=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Tue, 25 Jul 2023 12:14:56 +0200,
> Robert Lee wrote:
> >
> > Thanks for reply so quickly.
> > And yes, there are other changes but it is inside our offload pcm
> > driver to handle it.
> > Currently we only use it to decode, and we don't need additional option=
 for it.
>
> It means still a downstream-only change :)
>
> It's nice to upstream changes in general, but from the upstream POV,
> only changing this gives no benefit.  Let's tie with the actual use
> case *in the upstream*.
>
>
> thanks,
>
> Takashi
>
> >
> > Thanks,
> > Robert.
> >
> > Takashi Iwai <tiwai@suse.de> =E6=96=BC 2023=E5=B9=B47=E6=9C=8825=E6=97=
=A5 =E9=80=B1=E4=BA=8C =E4=B8=8B=E5=8D=886:05=E5=AF=AB=E9=81=93=EF=BC=9A
> > >
> > > On Tue, 25 Jul 2023 11:30:05 +0200,
> > > Robert Lee wrote:
> > > >
> > > > Add to support decode Opus codec in Ogg container.
> > > >
> > > > Signed-off-by: Robert Lee <lerobert@google.com>
> > >
> > > The change makes sense only when it's really used.  So usually it's
> > > better to put into a series that actually implements its usage.
> > >
> > >
> > > thanks,
> > >
> > > Takashi
> > >
> > > > ---
> > > >  include/uapi/sound/compress_params.h | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/include/uapi/sound/compress_params.h b/include/uapi/so=
und/compress_params.h
> > > > index ddc77322d571..bac5797bcb02 100644
> > > > --- a/include/uapi/sound/compress_params.h
> > > > +++ b/include/uapi/sound/compress_params.h
> > > > @@ -43,7 +43,8 @@
> > > >  #define SND_AUDIOCODEC_BESPOKE               ((__u32) 0x0000000E)
> > > >  #define SND_AUDIOCODEC_ALAC                  ((__u32) 0x0000000F)
> > > >  #define SND_AUDIOCODEC_APE                   ((__u32) 0x00000010)
> > > > -#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_APE
> > > > +#define SND_AUDIOCODEC_OPUS                  ((__u32) 0x00000011)
> > > > +#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_OPUS
> > > >
> > > >  /*
> > > >   * Profile and modes are listed with bit masks. This allows for a
> > > > --
> > > > 2.41.0.487.g6d72f3e995-goog
> > > >
> >